From patchwork Sat Jun 24 08:42:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Jacques Hiblot X-Patchwork-Id: 11250 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp6291980vqr; Sat, 24 Jun 2023 02:28:47 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4Wfbk7NWsPLodVKMNB1+nBps0QZw963ZmCb3FmSBInaKxBkhAS4wX4690VBtatdIC9mgTW X-Received: by 2002:a05:6a20:7290:b0:120:7282:2166 with SMTP id o16-20020a056a20729000b0012072822166mr22222332pzk.18.1687598927637; Sat, 24 Jun 2023 02:28:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687598927; cv=none; d=google.com; s=arc-20160816; b=pLItpv8exYXASb+uoC0VJFj2GMmhctipPl0klqSFpxG49UxVjGv3C7WEbzrs5OgmsK Lr13QhknRCNcVg7lpVxRpKUYhWNQ+OXf3OkSoqepGiWd7TCbmuCK5j+08zy6DwKo0v0w RLb19aLKJnPV6BsCeXrlh805kqyemTQubUklCUoB0BR6vGMqgNkTLlyB9/ldQY3XijlZ snaGW8oi/+bXjS52sgOXNyv9I4Dpkt3tFk1DzgLnaflKszT6+MV6fytSMqWZ7ShAgOf3 iiulHz/qEGZgxRcVDpYTpJL4+3V1y1Xur5yxvNZ62PPHbgK0D7xFwUMkxdD0BqP/KhXp 39nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=BCOegMAKO0jZ3Um2wgQwCoX2lTTh6YzEXMARiddqJKM=; fh=opu+cKmZC/uSMG2qmKGC187UT+r4xRWK2Hiwit6u2Dg=; b=c3jg7p7BatT+xky1a8GJKVX1w+zkHAAk9bLbiL4kbz2JnOnlmgcovFdP6BOLRUYqr4 rSjJ8TvWY+aVCcNQcNRnMwiWBR7d8fsVEiaZZCllz1HqQXiK0rI1XEU/yrEfzC69cCSm qgJVsXyC0QS4Tg7hF+6YMXIQ5Czldj1JE96HZWYoQfEsvzsDtlKlXVpFG8q0g+hTGAlU 6DiqAperi9HPHRZ34b8155WfaxJH1zh7bOeBpDKt5VXzuv2b9xvyZjJpdMHQcxXznbZh y5JjqKul+e6dV2lYag4wx/9Nlb4pj8LiJm3R1ZD+6rYnQsEdEF/vhSBk4LTEEoL2ilRT K+4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p5-20020a056a0026c500b00666acab17acsi52964pfw.318.2023.06.24.02.28.34; Sat, 24 Jun 2023 02:28:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232931AbjFXJUx (ORCPT + 99 others); Sat, 24 Jun 2023 05:20:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232845AbjFXJUt (ORCPT ); Sat, 24 Jun 2023 05:20:49 -0400 Received: from 10.mo563.mail-out.ovh.net (10.mo563.mail-out.ovh.net [46.105.78.6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71B531BCA for ; Sat, 24 Jun 2023 02:20:48 -0700 (PDT) Received: from director1.derp.mail-out.ovh.net (director1.derp.mail-out.ovh.net [51.68.80.175]) by mo563.mail-out.ovh.net (Postfix) with ESMTPS id E1C1322EFF; Sat, 24 Jun 2023 08:42:33 +0000 (UTC) Received: from director1.derp.mail-out.ovh.net (director1.derp.mail-out.ovh.net. [127.0.0.1]) by director1.derp.mail-out.ovh.net (inspect_sender_mail_agent) with SMTP for ; Sat, 24 Jun 2023 08:42:33 +0000 (UTC) Received: from pro2.mail.ovh.net (unknown [10.109.143.168]) by director1.derp.mail-out.ovh.net (Postfix) with ESMTPS id 857EE2011E3; Sat, 24 Jun 2023 08:42:33 +0000 (UTC) Received: from traphandler.com (88.161.25.233) by DAG1EX1.emp2.local (172.16.2.1) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Sat, 24 Jun 2023 10:42:32 +0200 From: Jean-Jacques Hiblot To: , , , , CC: , , , Jean-Jacques Hiblot Subject: [PATCH v10 0/5] Add a multicolor LED driver for groups of monochromatic LEDs Date: Sat, 24 Jun 2023 10:42:12 +0200 Message-ID: <20230624084217.3079205-1-jjhiblot@traphandler.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [88.161.25.233] X-ClientProxiedBy: DAG2EX1.emp2.local (172.16.2.11) To DAG1EX1.emp2.local (172.16.2.1) X-Ovh-Tracer-Id: 12427964648445917659 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrgeegjedgtdejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvfevufffkffoggfgtghisehtkeertdertddtnecuhfhrohhmpeflvggrnhdqlfgrtghquhgvshcujfhisghlohhtuceojhhjhhhisghlohhtsehtrhgrphhhrghnughlvghrrdgtohhmqeenucggtffrrghtthgvrhhnpeejuefhkeelgffhlefhtefhgeektdevvdfgkeeltdehgeeujeeutdehkeeuhffftdenucfkpheptddrtddrtddrtddpkeekrdduiedurddvhedrvdeffeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepughirhgvtghtohhruddruggvrhhprdhmrghilhdqohhuthdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepjhhjhhhisghlohhtsehtrhgrphhhrghnughlvghrrdgtohhmpdhnsggprhgtphhtthhopedupdhrtghpthhtoheplhhinhhugidqlhgvughssehvghgvrhdrkhgvrhhnvghlrdhorhhgpdfovfetjfhoshhtpehmohehieef X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769575733107529282?= X-GMAIL-MSGID: =?utf-8?q?1769575733107529282?= Some HW design implement multicolor LEDs with several monochromatic LEDs. Grouping the monochromatic LEDs allows to configure them in sync and use the triggers. The PWM multicolor LED driver implements such grouping but only for PWM-based LEDs. As this feature is also desirable for the other types of LEDs, this series implements it for any kind of LED device. changes v9->v10: - updated comments and kconfig description - renamed all 'led_mcg_xxx' into 'leds_gmc_xxx' changes v8->v9: - rebased on top of lee-leds/for-leds-next - updated kernel version and date for /sys/class/leds//color in Documentation/ABI/testing/sysfs-class-led - dropped patch "leds: class: simplify the implementation of devm_of_led_get()" because __devm_led_get() is now used by devm_led_get() changes v7->v8: - consistently use "LEDs group multicolor" throughout the code. - rename some variables with more explicit names. - improve comments. - use the 100-characters per line limit. changes v6->v7: - in led_mcg_probe() increment the counter at the end of the loop for clarity. changes v5->v6: - restore sysfs access to the leds when the device is removed changes v4->v5: - Use "depends on COMPILE_TEST || OF" in Kconfig to indicate that OF is a functional requirement, not just a requirement for the compilation. - in led_mcg_probe() check if devm_of_led_get_optional() returns an error before testing for the end of the list. - use sysfs_emit() instead of sprintf() in color_show(). - some grammar fixes in the comments and the commit logs. changes v2->v3, only minor changes: - rephrased the Kconfig descritpion - make the sysfs interface of underlying LEDs read-only only if the probe is successful. - sanitize the header files - removed the useless call to dev_set_drvdata() - use dev_fwnode() to get the fwnode to the device. changes v1->v2: - Followed Rob Herrings's suggestion to make the dt binding much simpler. - Added a patch to store the color property of a LED in its class structure (struct led_classdev). Jean-Jacques Hiblot (5): devres: provide devm_krealloc_array() leds: provide devm_of_led_get_optional() leds: class: store the color index in struct led_classdev dt-bindings: leds: Add binding for a multicolor group of LEDs leds: Add a multicolor LED driver to group monochromatic LEDs Documentation/ABI/testing/sysfs-class-led | 9 + .../bindings/leds/leds-group-multicolor.yaml | 64 +++++++ drivers/leds/led-class.c | 45 +++++ drivers/leds/rgb/Kconfig | 12 ++ drivers/leds/rgb/Makefile | 1 + drivers/leds/rgb/leds-group-multicolor.c | 165 ++++++++++++++++++ include/linux/device.h | 13 ++ include/linux/leds.h | 3 + 8 files changed, 312 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/leds-group-multicolor.yaml create mode 100644 drivers/leds/rgb/leds-group-multicolor.c