Message ID | 20230624053120.643409-1-senozhatsky@chromium.org |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp6224551vqr; Fri, 23 Jun 2023 23:04:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7AfmsGB6jbN6Dru98yPV3dR3WcugNhJ0xN46+ZtWaX/+Sikr8BDAO2/Y4f6uakPpL6K1Ij X-Received: by 2002:ad4:5bc7:0:b0:62d:fec9:9658 with SMTP id t7-20020ad45bc7000000b0062dfec99658mr28708363qvt.47.1687586688812; Fri, 23 Jun 2023 23:04:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687586688; cv=none; d=google.com; s=arc-20160816; b=ba6gv5GogJVpo1Qs08x9d7HGQVRjHnVoITwPsVkA557tCvF9nj2u/h0AUhIAVh0Jts W05dRW4GteOMA2Zr7OyFUiz8B6iwlo3aYzcsDT3EzgMLpnINAC1v1KP6FAK855GHEaD5 NtC+rCdLeknNYa74MzxF3C4E01UH41PGd27ziccwDIRUNXQ4rp593JTs+HF5j8Ecmdq4 anVZ0SRgsK9cBHCApLssVOVfYjhlFMNtEhioWq/W5sZXPoTzQMP/gKN6IqH8w0UNKRpD OKN3pXS2Sp+70zhoPNtLwtRQGo14X+mHRu5vyjUMQVwvVg9nlsOKOK7zW5gUElKNt3VI PvXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=CpNamKrNpDCdbcF9XbjJPNcFm86c8B3puQQnd+r/HGw=; fh=P133Y9g7Tn7h5nZ3sRbktjmxBfSwq4h947lDRKnjDeg=; b=hZ7aH96um2XndQFLbtqFnP+HRO8j12ww0V5U4+kpkHh0PbNGJADO5SZxDbYDyXg4Hx /2Y6Vkw4EaDIyrF2qDzwm/kz0rToTOgcA3Iq9KvMmR9AH+ES54uUv/jhOye1gXfG0w3p 3cXQAGuOPtBnF/66hLR/u5zxOcUscOSBpoXLsCq5EBF976lfCVGDEAHTOMy0d9X21ACs 9MFrao9u5vtA/gB2lT/b6RwUrMBGQ+uyaL2Vv+lqpAzlowrOD2RQQjWIX9a3UnLW4zZZ QMdcCQ0UBaZ+oOiojg+auW4RlfqC19bMLrzDAAGaGmdGq4GQkYlt1sZTC4yMS97UdASE sEgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Z5+8hPZy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j30-20020a63231e000000b005429248576asi934424pgj.128.2023.06.23.23.04.36; Fri, 23 Jun 2023 23:04:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Z5+8hPZy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230369AbjFXFbb (ORCPT <rfc822;maxin.john@gmail.com> + 99 others); Sat, 24 Jun 2023 01:31:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229615AbjFXFb2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 24 Jun 2023 01:31:28 -0400 Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C715D26AB for <linux-kernel@vger.kernel.org>; Fri, 23 Jun 2023 22:31:27 -0700 (PDT) Received: by mail-qv1-xf33.google.com with SMTP id 6a1803df08f44-630038f13daso12157176d6.3 for <linux-kernel@vger.kernel.org>; Fri, 23 Jun 2023 22:31:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1687584687; x=1690176687; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CpNamKrNpDCdbcF9XbjJPNcFm86c8B3puQQnd+r/HGw=; b=Z5+8hPZyJNdpvO1yM9cQ9dK7OuaewDHHeNyPLe429wvaxApbqQBbUA5sankYu8AUqX ks5KYxFWZmAJAIQVezo+Hc3LixlxGubI1fok7hnxormr+lUYcmWo4b6XUfojKHXA6kA7 +vb7NGqYAuA9q04SEl7mCsh4fsNgLUZKMJS6Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687584687; x=1690176687; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CpNamKrNpDCdbcF9XbjJPNcFm86c8B3puQQnd+r/HGw=; b=S79KNqDMVUVCKKf2nOMNGNH1tlq9xJLPt7e+R12vHN0M/JCW8iF7a0UK2LfTKoJdNL Swx0Zvk/siTGJfnjQ3XGKS+YKjvH6/emmIiVUe0KQGElblvRiijp4YegWbdjVJucksvV H86n0qbg/BCqAiCpy+sBGVv2PLJWKM3vw6IWl7doWM5uB0MYyOZ1kVj8uyga5Vj4nQ/I s5Qpv7nS/v0abE++RKztuaXzVfiVRecxnduQEiV98PH5y4yStWY0UxGge2i1fpw8TFtn WZRdd6PLnbuSA0CrPe6ymyHU3539IJeOSMS+IU3FwIdQLker/r89Ot/BOVcpBh7xWQKR ZQfQ== X-Gm-Message-State: AC+VfDwuOtDUJnsWxBZkfnWjhmqLtVU8/rzwbaxedBZeS0oOP7Q2i3hl /gkmjZZGniHgSAtTOSLgyGHijQ== X-Received: by 2002:a05:6214:2302:b0:628:74d6:ba89 with SMTP id gc2-20020a056214230200b0062874d6ba89mr26510620qvb.60.1687584686929; Fri, 23 Jun 2023 22:31:26 -0700 (PDT) Received: from tigerii.tok.corp.google.com ([2401:fa00:8f:203:d7fc:8a97:4a18:6a18]) by smtp.gmail.com with ESMTPSA id 16-20020a17090a0c1000b002563e8a0225sm567069pjs.48.2023.06.23.22.31.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jun 2023 22:31:26 -0700 (PDT) From: Sergey Senozhatsky <senozhatsky@chromium.org> To: Andrew Morton <akpm@linux-foundation.org>, Minchan Kim <minchan@kernel.org> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky <senozhatsky@chromium.org> Subject: [PATCHv2 0/3] zsmalloc: small compaction improvements Date: Sat, 24 Jun 2023 14:12:13 +0900 Message-ID: <20230624053120.643409-1-senozhatsky@chromium.org> X-Mailer: git-send-email 2.41.0.162.gfafddb0af9-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769468299089645199?= X-GMAIL-MSGID: =?utf-8?q?1769562899582616827?= |
Series |
zsmalloc: small compaction improvements
|
|
Message
Sergey Senozhatsky
June 24, 2023, 5:12 a.m. UTC
Hi, A tiny series that can reduce the number of find_alloced_obj() invocations (which perform a linear scan of sub-page) during compaction. Inspired by Alexey Romanov's findings. v2: -- picked up a patch from Minchan Minchan Kim (1): zsmalloc: remove zs_compact_control Sergey Senozhatsky (2): zsmalloc: do not scan for allocated objects in empty zspage zsmalloc: move migration destination zspage inuse check mm/zsmalloc.c | 50 ++++++++++++++++++++------------------------------ 1 file changed, 20 insertions(+), 30 deletions(-)
Comments
On (23/06/24 14:12), Sergey Senozhatsky wrote: > Hi, > A tiny series that can reduce the number of > find_alloced_obj() invocations (which perform a linear > scan of sub-page) during compaction. Inspired by Alexey > Romanov's findings. > > v2: > -- picked up a patch from Minchan > > Minchan Kim (1): > zsmalloc: remove zs_compact_control > > Sergey Senozhatsky (2): > zsmalloc: do not scan for allocated objects in empty zspage > zsmalloc: move migration destination zspage inuse check Just for the record, A synthetic zsmalloc fragmentation+compaction test (100% reproducible) num find_tagged_obj() calls num iterations in find_tagged_obj() base 545699 812899 patch #1 460701 691821 patch #2 422372 651372 // lower is better patch #1 is "zsmalloc: do not scan for allocated objects in empty zspage" patch #2 is "zsmalloc: move migration destination zspage inuse check"