From patchwork Wed Jun 21 11:44:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Ghiti X-Patchwork-Id: 11098 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp4317927vqr; Wed, 21 Jun 2023 05:18:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4nnxACFkIhOOgAtm9hP9T/gM2WVacPMfQkcJzhnSQcND8xzsgSDoJXmmMeJ1ByYivdjDtq X-Received: by 2002:a05:6a20:3d29:b0:11f:3f5b:b4fa with SMTP id y41-20020a056a203d2900b0011f3f5bb4famr18216104pzi.48.1687349887205; Wed, 21 Jun 2023 05:18:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687349887; cv=none; d=google.com; s=arc-20160816; b=rxWHLvCrR9/vKOtFX96McsOui4E3fDGkBagX2O2IGHEfqpfKqakTmPnsYxY2maMdpp eODiYTuE0Oz0vKh74hMpaFi6AVDK95xc4XNOncwg3Vq6/WpWK98ay2+CZFQDSJeolXLK MqjTrtclg7TY2vDusXPJeeYGBAiyHtXIWDKbRhY9pcvKQ/0anRqm5lJ31cWHgeHzzeeo blLx+QVR3+rjcFTK1GSNKv02XmFTFZASdhUkbq6eT1m47sSRMg5OQcp7fzIRjuJqS4CA SJiEFIqXBXfAu66OnqScDqZ2Q7ZGHmN6o3MqEh2QCoVpEOLXEA6jwDqvnw9yEV9P7v/1 KPog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=GHn9t4zMhJxxvPoRVF2VtnqYo/UVxkvWAxyDQV5WVfE=; b=tVvimRixPii6Ie/BLRB0UqujsFuqNVjX/9hZJjzQz+R19NiCiGDYCfIzpkOFAvcign pkFbzAbU6lKi71ijqVN9boxCWxlGhqgQo7/xB1CyR9NitW4WKNZnzbmbjlMmhHNUzRt0 Bn+qURy5ob2HSVY4vADobJF4FkTmGZX/T6ofDSHtwWWdcQr6/zhIOBq7DQwLw8B/wzNE biTMn9Vf9oCL9M+p9KKIDmn+TPVZsVPyy2OMWYCGfQiT5+SUN1soJvuw9IY6z/JDGJE5 Gv/zjM1N4sIr7LdeUNy0sHVdq79XqBdHtF6se4gDUBWDzcg9+5/tuiX8DXRqGmGr+Wzr neJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rivosinc-com.20221208.gappssmtp.com header.s=20221208 header.b=E1avIA9i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x3-20020a170902fe8300b001aaf2ced278si676264plm.430.2023.06.21.05.17.51; Wed, 21 Jun 2023 05:18:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@rivosinc-com.20221208.gappssmtp.com header.s=20221208 header.b=E1avIA9i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229894AbjFULoq (ORCPT + 99 others); Wed, 21 Jun 2023 07:44:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229732AbjFULoo (ORCPT ); Wed, 21 Jun 2023 07:44:44 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5087A1B4 for ; Wed, 21 Jun 2023 04:44:43 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-311367a3e12so4873130f8f.2 for ; Wed, 21 Jun 2023 04:44:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1687347882; x=1689939882; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GHn9t4zMhJxxvPoRVF2VtnqYo/UVxkvWAxyDQV5WVfE=; b=E1avIA9iFt+MBS8GQNcN3VKRL+WvabL4YWMug9M85jOqFCJQKSA5FY+vr6OUMsQfBn Sg3QZkk1tAzdbD1pP46Ta0Ni0UYk1fR3HlQr7SXsQgJgdyA1pPfZ7BU3siVqo2eM/Ns3 FcCY5GW0V43NrMMwNfg7xOmjuWL3YDmsW/PvW5reoqtybhivRJ506NEoyvCEee8ozGMj /UG5/ptCroa0uQY112o44OaAxj5tTdWUs1/2UuLXk6dSveHGaXuaZppX4vTJW+ernkko g6W93n6cvaEdJQJewJPpbOQ98TFyKOLFmPTQelX+nI7FoYmOfLOFtnw0Rxi8He/cLf3p D4QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687347882; x=1689939882; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GHn9t4zMhJxxvPoRVF2VtnqYo/UVxkvWAxyDQV5WVfE=; b=Nq/f9pou4QbGScImN7ysyOa8PiLAtEhc1AhOxoLwiAaiFbEhjpbec4adC80G7Vjsxb 63FxSVwgEU+T3Yc2jWjNaWYVCqjdQabFJQZaXphO1ezGZ52w+z4aX994V6C2cq30Dqhz VDtWK06BtiFjVeiBqfX8g02VsOrfmrCKSIPm9YUQLJyTzqGT+JnKhszjxgy2pp/Ns9Ig X2FSJIUPea3ONdVUs+PlS1+yelO5E4Nc3L0pg10UGSqbdCHxS1CN9zjKuyUNtUZN29As 2KNo6RPSKsXwhCMN4Uhv95l7DodIyIj1Bk6Qa3jP9DRAwbdR/WZtt5yLxOCR2QYcvQHK 2GUA== X-Gm-Message-State: AC+VfDwOaQ2xnJeYHIrPSkoN6zLimS8Z8bYcMim2QhXcT84iPy8mHqWx ebNuXJ+Z1XkUWOm86mU15TPj+TMDZHT+18XUjmY= X-Received: by 2002:adf:fa06:0:b0:311:15e3:e09d with SMTP id m6-20020adffa06000000b0031115e3e09dmr13371125wrr.36.1687347881744; Wed, 21 Jun 2023 04:44:41 -0700 (PDT) Received: from alex-rivos.ba.rivosinc.com (amontpellier-656-1-456-62.w92-145.abo.wanadoo.fr. [92.145.124.62]) by smtp.gmail.com with ESMTPSA id l15-20020a5d674f000000b003112f836d4esm4254272wrw.85.2023.06.21.04.44.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jun 2023 04:44:41 -0700 (PDT) From: Alexandre Ghiti To: Ard Biesheuvel , linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Cc: Alexandre Ghiti Subject: [RFC PATCH 0/1] zboot: Garbage collect unused functions Date: Wed, 21 Jun 2023 13:44:38 +0200 Message-Id: <20230621114439.42851-1-alexghiti@rivosinc.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769314595512111069?= X-GMAIL-MSGID: =?utf-8?q?1769314595512111069?= This patch is meant to solve the issue reported by lkp in [1] with the KASLR series support for RISC-V. The problem in [1] is caused by the addition of new functions in efi-stub-helper.c which reference symbols that are not defined in the context of zboot. Those functions are not used in zboot but it causes those link errors. I can move those new functions around so that the problem disappears, but I believe that fixing that using the linker garbage collection is more sane. That's an RFC, I'll include it in my KASLR series if that's the right direction. [1] https://lore.kernel.org/oe-kbuild-all/202306080741.ArdxyO6n-lkp@intel.com/ Alexandre Ghiti (1): libstub: zboot: Use -ffunction-sections + --gc-sections drivers/firmware/efi/libstub/Makefile | 1 + drivers/firmware/efi/libstub/Makefile.zboot | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)