mbox series

[v6,0/5] Improve PTT filter interface and some fixes

Message ID 20230621092804.15120-1-yangyicong@huawei.com
Headers
Series Improve PTT filter interface and some fixes |

Message

Yicong Yang June 21, 2023, 9:27 a.m. UTC 
  From: Yicong Yang <yangyicong@hisilicon.com>

This series tends to improve the PTT's filter interface in 2 aspects (Patch 2&3):
- Support dynamically filter updating to response to hotplug
  Previous the supported filter list is settled down once the driver probed and
  it maybe out-of-date if hotplug events happen later. User need to reload the
  driver to update list. Patch 1/2 enable the driver to update the list by
  registering a PCI bus notifier and the filter list will always be the latest.
- Export the available filters through sysfs
  Previous user needs to calculate the filters and filter value using device's
  BDF number, which requires the user to know the hardware well. Patch 3/3 tends
  to export the available filter information through sysfs attributes, the filter
  value will be gotten by reading the file. This will be more user friendly.

In order to support above function, this series also includes a patch 1/4 to factor
out the allocation and release function of PTT filters.

Also includes an improvement and a fix. Patch 4 tends to set proper PMU capability
to avoid collecting unnecessary data to save the storage. Patch 5 fix an improper
use of pci_irq_vector() which have potential problem.

Change since v5:
- PERF_PMU_CAP_EXCLUSIVE is still needed so keep it as is, thanks Junhao for pointing it
Link: https://lore.kernel.org/all/01c39cb9-e56a-862b-2d99-024b7ba5a769@huawei.com/

Change since v4:
- Add tags for Patch 2,3,5 and tweak some comments/docs in Patch 3
Link: https://lore.kernel.org/all/20230606142244.10939-1-yangyicong@huawei.com/

Change since v3:
- Addressed the comment from Jonathan. Add tags for Patch 1 and 4. Thanks.
- Add one bugfix in Patch 5/5
Link: https://lore.kernel.org/linux-pci/20230523093228.48149-1-yangyicong@huawei.com/

Change since v2:
- Fix one possible issue for dereferencing a NULL pointer
Link: https://lore.kernel.org/linux-pci/20230331070310.5465-1-yangyicong@huawei.com/

Change since v1:
- Drop the patch for handling the cpumask since it seems to be redundant
- Refine of the codes per Jonathan
- Add Patch 1/4 for refactor the filters allocation and release
- Thanks the review of Jonathan.
Link: https://lore.kernel.org/linux-pci/d496ee4f-641a-a726-ab3f-62b587422b61@huawei.com/T/#m47e4de552d69920035214b3e91080cdc185f61f5

Yicong Yang (5):
  hwtracing: hisi_ptt: Factor out filter allocation and release
    operation
  hwtracing: hisi_ptt: Add support for dynamically updating the filter
    list
  hwtracing: hisi_ptt: Export available filters through sysfs
  hwtracing: hisi_ptt: Advertise PERF_PMU_CAP_NO_EXCLUDE for PTT PMU
  hwtracing: hisi_ptt: Fix potential sleep in atomic context

 .../ABI/testing/sysfs-devices-hisi_ptt        |  52 ++
 Documentation/trace/hisi-ptt.rst              |  12 +-
 drivers/hwtracing/ptt/hisi_ptt.c              | 444 ++++++++++++++++--
 drivers/hwtracing/ptt/hisi_ptt.h              |  56 +++
 4 files changed, 526 insertions(+), 38 deletions(-)

Comments

Suzuki K Poulose June 21, 2023, 11:05 a.m. UTC | #1 
On Wed, 21 Jun 2023 17:27:59 +0800, Yicong Yang wrote:
> From: Yicong Yang <yangyicong@hisilicon.com>
> 
> This series tends to improve the PTT's filter interface in 2 aspects (Patch 2&3):
> - Support dynamically filter updating to response to hotplug
>   Previous the supported filter list is settled down once the driver probed and
>   it maybe out-of-date if hotplug events happen later. User need to reload the
>   driver to update list. Patch 1/2 enable the driver to update the list by
>   registering a PCI bus notifier and the filter list will always be the latest.
> - Export the available filters through sysfs
>   Previous user needs to calculate the filters and filter value using device's
>   BDF number, which requires the user to know the hardware well. Patch 3/3 tends
>   to export the available filter information through sysfs attributes, the filter
>   value will be gotten by reading the file. This will be more user friendly.
> 
> [...]

Applied, thanks!

[1/5] hwtracing: hisi_ptt: Factor out filter allocation and release operation
      commit: a3ecaba7017f5d02d1ad60229cc14d5f0cda0c20
[2/5] hwtracing: hisi_ptt: Add support for dynamically updating the filter list
      commit: 556ef09392dbc2d0b9aad5fd880d5d11addfc40d
[3/5] hwtracing: hisi_ptt: Export available filters through sysfs
      commit: 6373c463ac894e41cab24469d1947ff91aaea486
[4/5] hwtracing: hisi_ptt: Advertise PERF_PMU_CAP_NO_EXCLUDE for PTT PMU
      commit: 45c90292ad0e275ef4b870838b3b5273b3ef8ade
[5/5] hwtracing: hisi_ptt: Fix potential sleep in atomic context
      commit: 6c50384ef8b94a527445e3694ae6549e1f15d859

Best regards,