From patchwork Mon Jun 19 16:52:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 10996 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp3146541vqr; Mon, 19 Jun 2023 10:16:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5j6tYvBLt6VZZ1gQc2ehHxY4JjOx7B1ozr6Pa1Q9F6jlQxy9FZH3CCdJknRGfzpdRilKF+ X-Received: by 2002:a05:6870:a4c1:b0:1a6:4c71:8d8 with SMTP id k1-20020a056870a4c100b001a64c7108d8mr8243533oal.31.1687195009349; Mon, 19 Jun 2023 10:16:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687195009; cv=none; d=google.com; s=arc-20160816; b=y/wEOXT4HA15IxC5Pc9lI9t4DT25ioPv4jcmn4UWIGHu/BymfptMOpk6KADl1VVhxO T8rhiD2MxELVjv+NqT42UZZxFYh+3ma8ApxbAWlSESpVTgILAqJnop65jvC1IJBz9sEm NCBYC7eUvMNUyY59lBLHCux9rZNQTzlsQNLriuCCKqkT6r1YqtXLsYMBYRy2ahaJWE4f UrhIgdVz+hZw5cgH5dlOeCHLyWXsN9UpXTJhPjJqqra/4wCzGZTntt9o5G83pXOme890 u3KbC0LJal5fbKseTwPYNkEbPqB2emVQrNqyKZZ9fjAeo9yIudC0/n6jlha/AF+1fZ3J mGxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Cpo15BY2JHXHdSym8b6/SAAWwUCiMEB1iTus7BKnbPY=; b=N/p9ch4AfyFSeRjlZlAxawhR4lAqx+B+/oBALSRuqJNDgM8OdU6ftGMuodyORbiAh6 EMIvdmvi7o6220c0iYyAYx5DK7gCh5OFl1bY7defDT8HkckYBn57+IwhwAej4VzeaUyt CsQDERP3VnzJOTxI8L3lFi8R2knmG+y2QfSLbi/H06A7HBOiLI8VO2F7b6GSYcIu3kjy /LQ+ujPy+xgTVL6bWVnaUsv7Jkz7helRCq78NIR5+lDPhyJH3JIN7tjawd8xjFQ4jwH0 tHVMIKPoy2a64QJpiJoQmI3gLADzOrTL1vRlmP82ZbbNVGi5Vrip4JUuIZYPwJkxcITk SLHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SbzA+ryt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o5-20020a637e45000000b0054f993d7f29si14978687pgn.563.2023.06.19.10.16.36; Mon, 19 Jun 2023 10:16:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SbzA+ryt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229844AbjFSRD5 (ORCPT + 99 others); Mon, 19 Jun 2023 13:03:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231368AbjFSRDv (ORCPT ); Mon, 19 Jun 2023 13:03:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC5C510C4 for ; Mon, 19 Jun 2023 10:03:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3289B60E55 for ; Mon, 19 Jun 2023 17:03:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 153AAC433C0; Mon, 19 Jun 2023 17:03:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687194224; bh=kZcG68CKxsF0yfm9NzXeng4kRKcnmTVTpToRWIdUohQ=; h=From:To:Cc:Subject:Date:From; b=SbzA+ryt2mcqUhfBIGRUperz+RWLFvNbD4pn26hux6htCBKOPgyTdJ4+R/BjqdgIh 1n8xFzLKDfA2RGRFwHVu+/DZ1e5VyxbjeJHQQ93/nRaUu9UJkz9OBtU3oxI1N6nHm7 7wChsSxoA2pd20L7rcgzOp/aEoZoy9b/QZhmwxp2/DB5wjGEsfas2zCqLZoP6qv0Sn PdFUMyQcxOclIgdNhIpGXE1XEC3wfblY0LR72hR4qkKcfgi1YG7bC4vezTHIPb09rD Vx5tm4owkbVIIHI2s6qWtVLa7CoFVn54R9XCUEbUGtSUs2SrTS3ffB6O/kygjSs2EG /AgMeU2YU+kiA== From: Jisheng Zhang To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Simon Horman Subject: [PATCH net-next v3 0/2] net: stmmac: fix & improve driver statistics Date: Tue, 20 Jun 2023 00:52:18 +0800 Message-Id: <20230619165220.2501-1-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769152193944003465?= X-GMAIL-MSGID: =?utf-8?q?1769152193944003465?= improve the stmmac driver statistics: 1. don't clear network driver statistics in .ndo_close() and .ndo_open() cycle 2. avoid some network driver statistics overflow on 32 bit platforms 3. use pcpu statistics where necessary to remove frequent cacheline ping pongs. NOTE: v1 and v2 are back ported from an internal LTS tree, I made some mistakes when backporting and squashing. Now, net-next + v3 has been well tested with 'ethtool -s' and 'ip -s link show'. Since v2: - fix ethtool .get_sset_count, .get_strings and per queue stats couting. - fix .ndo_get_stats64 only counts the last cpu's pcpu stats. - fix typo: s/iff/if in commit msg. - remove unnecessary if statement brackets since we have removed one LoC. Since v1: - rebase on net-next - fold two original patches into one patch - fix issues found by lkp - update commit msg Jisheng Zhang (2): net: stmmac: don't clear network statistics in .ndo_open() net: stmmac: use pcpu 64 bit statistics where necessary drivers/net/ethernet/stmicro/stmmac/common.h | 54 +++-- .../net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 15 +- .../ethernet/stmicro/stmmac/dwmac100_dma.c | 7 +- .../ethernet/stmicro/stmmac/dwmac4_descs.c | 16 +- .../net/ethernet/stmicro/stmmac/dwmac4_lib.c | 15 +- .../net/ethernet/stmicro/stmmac/dwmac_lib.c | 10 +- .../ethernet/stmicro/stmmac/dwxgmac2_descs.c | 6 +- .../ethernet/stmicro/stmmac/dwxgmac2_dma.c | 13 +- .../net/ethernet/stmicro/stmmac/enh_desc.c | 20 +- drivers/net/ethernet/stmicro/stmmac/hwif.h | 12 +- .../net/ethernet/stmicro/stmmac/norm_desc.c | 15 +- .../ethernet/stmicro/stmmac/stmmac_ethtool.c | 108 +++++++--- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 190 +++++++++++++----- 13 files changed, 312 insertions(+), 169 deletions(-)