From patchwork Mon Jun 19 10:08:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Kauer X-Patchwork-Id: 10970 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2893343vqr; Mon, 19 Jun 2023 03:21:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4N1IhZ0iJlEpqzQ4TcAu1ocfMvyopszlEfC54d5b3OlyZ+2NqSUixwKb9wwkKszMDvI5es X-Received: by 2002:a05:6a20:1606:b0:110:390f:6806 with SMTP id l6-20020a056a20160600b00110390f6806mr9477706pzj.57.1687170108721; Mon, 19 Jun 2023 03:21:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687170108; cv=none; d=google.com; s=arc-20160816; b=cxW0pihRseo3dELYAzBfukr/i0cfotXgN+N2cGAsbhc23girv4f+TrlUDX78hnZ5sW oTPPl/3ZbkywRBj6BsQqD9JwG0aXitMlHhjR+hjVM9gvVS/IZoC1dQbzolShkSwVH+ZR 9+D0bbkg6hlIzcsyzYlRtaIlPh34cf1sQmh+brtyw8mWKDBNODZe3S+6CshLetZ5ONYW praC5xKRG3Cv4UupjbEledQTfihkOXvH6GeuPFtwcO89UDxO0Isy5faIhChQRtZ3MO7N V1JvpQ1muUylROiAMBjtWlyEzSAqKkIbI1TS2MIixnM5QRYPl207Ll8w731YNuwbcAS1 fW7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:dkim-signature:dkim-signature:from; bh=UfXg5kiqedtrj71y05Um//hTyaY890VMSarbops9Qv0=; b=uG/GkRaNpNS5i3Cuw0S/s5oRvVljnf/pdOBOAmhGiEV3lCND1Ayk4ic1xiqFdIbAPN T8+5LK3e/EkTc7jkj1lpv7jHi7ZSg+uZRDex3sOZyam82dsxg8w5x8c31WaJ1l4juSGJ wJyhn9OkKB1mFrq0OovA0Z6UUPy/n4Qv5Q5NN0MGDY9qv8dngOwWwaRPBdIkraqEy7On qOuUzoVTzgFF0LCXXZIOuxGAG2K74UCjbt02lzK8aZqvs2MpB2NQdEOP5oXpblukWNcs ZYgzMy7hek7/P9dwvip+NFUtWXOl3lqR9Its+BHt00cNGkAXgcIGx4JavKXWDXv+bJ52 gpHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=CfxdODnt; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=LCAJK6sI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z192-20020a6333c9000000b00530b6228f91si8878653pgz.895.2023.06.19.03.21.34; Mon, 19 Jun 2023 03:21:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=CfxdODnt; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=LCAJK6sI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231499AbjFSKJT (ORCPT + 99 others); Mon, 19 Jun 2023 06:09:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230369AbjFSKJR (ORCPT ); Mon, 19 Jun 2023 06:09:17 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C643E62; Mon, 19 Jun 2023 03:09:08 -0700 (PDT) From: Florian Kauer DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1687169346; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=UfXg5kiqedtrj71y05Um//hTyaY890VMSarbops9Qv0=; b=CfxdODntikelGjFSsAFgP5n/2oYhcQzDEtPk1mXUdkWJlGRNp8c+OIK74oGnhT7GMTg4c9 Ec0BqJABi9heLcGLTe0dbkV4KT1zTqc1pbPh/8Po6Xj/LosB4b3oJJ2TNuHmK2YfLUpRi4 wywZMMAVITUYT2pjbeVRXZ1/6GfGz7sPyuno/iLjdo2yTZ6/AVX59rNrgocCGP2FPOEkr9 I+qmdqgeAgVMf6B3aBotL251iEcaO48dfxxfNKdLZBwGyUD3lmpJBjRsPY/9fABQ16PVm+ 9Fh0PQ8svXSM6DovMixcJyYL6+kUvBVvh7X+lNefrZYbR3OuzQelsIJGecvvuA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1687169346; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=UfXg5kiqedtrj71y05Um//hTyaY890VMSarbops9Qv0=; b=LCAJK6sIZF73m7TU3iMW18qkDQ0HbpxquUVo9rcjk3DVqKKA3A8OcyvITTCz7WcUHUT3OF qM5dTIH0Noj9VBAA== To: Jesse Brandeburg , Tony Nguyen , Vinicius Costa Gomes , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Tan Tee Min , Muhammad Husaini Zulkifli , Aravindhan Gunasekaran , Malli C Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kurt@linutronix.de, florian.kauer@linutronix.de Subject: [PATCH net v2 0/6] igc: Fix corner cases for TSN offload Date: Mon, 19 Jun 2023 12:08:52 +0200 Message-Id: <20230619100858.116286-1-florian.kauer@linutronix.de> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769126083800362940?= X-GMAIL-MSGID: =?utf-8?q?1769126083800362940?= The igc driver supports several different offloading capabilities relevant in the TSN context. Recent patches in this area introduced regressions for certain corner cases that are fixed in this series. Each of the patches (except the first one) addresses a different regression that can be separately reproduced. Still, they have overlapping code changes so they should not be separately applied. Especially #4 and #6 address the same observation, but both need to be applied to avoid TX hang occurrences in the scenario described in the patches. Signed-off-by: Florian Kauer Reviewed-by: Kurt Kanzenbach Acked-by: Vinicius Costa Gomes Reviewed-by: Muhammad Husaini Zulkifli --- v2: - Rebased onto net. #1-#2 needed adaptations, others unmodified. - Extend #3 commit message that it only regards i225. --- Florian Kauer (6): igc: Rename qbv_enable to taprio_offload_enable igc: Do not enable taprio offload for invalid arguments igc: Handle already enabled taprio offload for basetime 0 igc: No strict mode in pure launchtime/CBS offload igc: Fix launchtime before start of cycle igc: Fix inserting of empty frame for launchtime drivers/net/ethernet/intel/igc/igc.h | 2 +- drivers/net/ethernet/intel/igc/igc_main.c | 10 ++++----- drivers/net/ethernet/intel/igc/igc_tsn.c | 26 ++++++++++++++++++++--- 3 files changed, 29 insertions(+), 9 deletions(-)