mbox series

[v2,0/2] Support bridge/connector by Tegra HDMI

Message ID 20230618085046.10081-1-clamor95@gmail.com
Headers
Series Support bridge/connector by Tegra HDMI |

Message

Svyatoslav Ryhel June 18, 2023, 8:50 a.m. UTC 
  This patch adds support for the bridge/connector attached to the
HDMI output, allowing to model the hardware properly. It keeps
backwards compatibility with existing bindings and is required
by devices which have a simple or MHL bridge connected to HDMI
output like ASUS P1801-T or LG P880/P895 or HTC One X.

Tested on ASUS Transformers which have no dedicated bridge but
have type d HDMI connector directly available. Tests went smoothly.

---

Chandes from v1:
- no changes, re-sending

---

Maxim Schwalm (1):
  drm/tegra: output: hdmi: Support bridge/connector

Svyatoslav Ryhel (1):
  ARM: tegra: transformers: add connector node

 arch/arm/boot/dts/tegra20-asus-tf101.dts      | 22 ++++++++--
 .../dts/tegra30-asus-transformer-common.dtsi  | 21 ++++++++-
 drivers/gpu/drm/tegra/hdmi.c                  | 44 ++++++++++++++-----
 3 files changed, 71 insertions(+), 16 deletions(-)

Comments

Thierry Reding July 27, 2023, 3:09 p.m. UTC | #1 
On Sun, Jun 18, 2023 at 11:50:44AM +0300, Svyatoslav Ryhel wrote:
> This patch adds support for the bridge/connector attached to the
> HDMI output, allowing to model the hardware properly. It keeps
> backwards compatibility with existing bindings and is required
> by devices which have a simple or MHL bridge connected to HDMI
> output like ASUS P1801-T or LG P880/P895 or HTC One X.
> 
> Tested on ASUS Transformers which have no dedicated bridge but
> have type d HDMI connector directly available. Tests went smoothly.

If I understand correctly, we still need the drm/tegra patch to be
applied before the DT change, otherwise the driver won't know what to do
about the connector, right?

That shouldn't be big problem, but it means that the patches need to be
staged in correctly to avoid breaking things.

Thierry
Svyatoslav Ryhel July 27, 2023, 4:24 p.m. UTC | #2 
27 липня 2023 р. 18:09:22 GMT+03:00, Thierry Reding <thierry.reding@gmail.com> написав(-ла):
>On Sun, Jun 18, 2023 at 11:50:44AM +0300, Svyatoslav Ryhel wrote:
>> This patch adds support for the bridge/connector attached to the
>> HDMI output, allowing to model the hardware properly. It keeps
>> backwards compatibility with existing bindings and is required
>> by devices which have a simple or MHL bridge connected to HDMI
>> output like ASUS P1801-T or LG P880/P895 or HTC One X.
>> 
>> Tested on ASUS Transformers which have no dedicated bridge but
>> have type d HDMI connector directly available. Tests went smoothly.
>
>If I understand correctly, we still need the drm/tegra patch to be
>applied before the DT change, otherwise the driver won't know what to do
>about the connector, right?
>
>That shouldn't be big problem, but it means that the patches need to be
>staged in correctly to avoid breaking things.

Patchset contains drm/tegra patch

>Thierry
Thierry Reding July 27, 2023, 4:52 p.m. UTC | #3 
On Thu, Jul 27, 2023 at 07:24:56PM +0300, Svyatoslav Ryhel wrote:
> 
> 
> 27 липня 2023 р. 18:09:22 GMT+03:00, Thierry Reding <thierry.reding@gmail.com> написав(-ла):
> >On Sun, Jun 18, 2023 at 11:50:44AM +0300, Svyatoslav Ryhel wrote:
> >> This patch adds support for the bridge/connector attached to the
> >> HDMI output, allowing to model the hardware properly. It keeps
> >> backwards compatibility with existing bindings and is required
> >> by devices which have a simple or MHL bridge connected to HDMI
> >> output like ASUS P1801-T or LG P880/P895 or HTC One X.
> >> 
> >> Tested on ASUS Transformers which have no dedicated bridge but
> >> have type d HDMI connector directly available. Tests went smoothly.
> >
> >If I understand correctly, we still need the drm/tegra patch to be
> >applied before the DT change, otherwise the driver won't know what to do
> >about the connector, right?
> >
> >That shouldn't be big problem, but it means that the patches need to be
> >staged in correctly to avoid breaking things.
> 
> Patchset contains drm/tegra patch

I understand, but my point is that if we apply the DT patch before the
driver patch, then the display won't be correctly initialized because
the old driver code only looks within the HDMI node for the additional
properties. Only after the drm/tegra patch is applied will the move in
DT be recognized by the driver.

So for now I've picked up the drm/tegra patch and then I'll apply the DT
change later on.

Thierry