From patchwork Wed Jun 14 16:18:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 10775 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp79550vqr; Wed, 14 Jun 2023 09:36:52 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ63PJIKo95gDBO7PcL9vpq3fEAKamlU2xQAJ6lwUTHHykY97bbvbSidDGnmOsgfMCoEnVKp X-Received: by 2002:a17:907:9686:b0:974:419d:7847 with SMTP id hd6-20020a170907968600b00974419d7847mr17138770ejc.71.1686760612660; Wed, 14 Jun 2023 09:36:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686760612; cv=none; d=google.com; s=arc-20160816; b=PDNO0wVuds3UBk5JueK5UbTLMzPSIw1Haed02XaQYra6uDAsP1QFGCC7enyKUg9Ziz Ea5fG/b6dWiGreHSmV+E2ToNcKQOBvnc0kMvODB3VfqWV7v5It2f6nuETI8LPZqYPoVO l1GfNNWeZhmkzEJPZ9tadeT0h+CWfiTrFMQ/IIk0ITDpJyfJ+j1XP2cSdWJki5mJhf4D +BInd34vwOq1SiuPtpJ4h71hk1sWusT5eN1b33R6q4Jqi9eaoqZhdTfvMmPpb9seqh0e jN4IgsMgKwnw7LvIpWr4UC4fMBAnv4jOfFZvty11nIQCG6ltyaxhGyObAUr9p8d1x+JQ Prhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=fwYvLOvhyNb9MeG5iKgzRLFWStHiNO2IIZf5MNrIZ30=; b=L9evpYW4wGvgN4KeEKykWo1f0l5MjMLWi5XvjUZHKHabM/bX3DAYwEBACdaj0F3K3T SCzsUs8fVBOQR3mgcrKtjsy2XCEccAopnsrtBJy7r84autCcbg+QBhiSfKxh1a3GRNyJ zf36WU2/5jDM2NLp4oXMI9OopehzCUk6lLIOSOMkATd0FMo6jrMfri4RofoWqqz1Y1Iy fyhCgKy0xoRlGxH6Pp4tl+MJjvXVx+7J1gsnKQ6WSIxjkt73uLh4owGWNmxcYq6NvjvA ULOhy8eX5oU0ag2ps4gOm75MI+wFgspWN2AL9BkU8xwmLt8e9koBg2j7MyWEvDdDg8LW JTeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Fnq/3Nj4"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h22-20020a170906585600b009827e8c1b4dsi653334ejs.140.2023.06.14.09.36.20; Wed, 14 Jun 2023 09:36:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Fnq/3Nj4"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233790AbjFNQaQ (ORCPT + 99 others); Wed, 14 Jun 2023 12:30:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233699AbjFNQaL (ORCPT ); Wed, 14 Jun 2023 12:30:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BCC41FF5 for ; Wed, 14 Jun 2023 09:30:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 221DE61868 for ; Wed, 14 Jun 2023 16:30:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA3BFC433C8; Wed, 14 Jun 2023 16:30:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686760209; bh=9llC9DY9BE1LH+xc2pnl/22XEd3kSEENXwtBayoRpmc=; h=From:To:Cc:Subject:Date:From; b=Fnq/3Nj4MccrkPzv3Rq/CX3+iFa7JOQNucgcVaZ391g94TPoDfPbOxu6HRJquclaF nj/Rn8QMm+L+klMX8LFuwwsCcLyMWfPMyWDCJbDaxe5uUDr8Ftm8dksbP4M+LMRVhs pYNLBDGTt24/m+eKyUAuDVDcQXT+wavNLkvybREsquzx/IHQ7nmZSxnTpB7jkluVPG v5LIE6KhNkXhG6ih0rPOUHFykTdBAEFULWkxdzuuQeJEsxRVtdsr6SOHY+pKxuZdtM s3JEAGXFOJ6MvSlznDY6hb8PeFwPBTuRlonB8JNYzWJ2TiL4TzK4lxVQT6mg72eyGU gn4vGFfOPvLCg== From: Jisheng Zhang To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: [PATCH 0/3] net: stmmac: fix & improve driver statistics Date: Thu, 15 Jun 2023 00:18:44 +0800 Message-Id: <20230614161847.4071-1-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768696696173971418?= X-GMAIL-MSGID: =?utf-8?q?1768696696173971418?= patch1 and patch2 fix two issues in net driver statistics: 1. network driver statistics are cleared in .ndo_close() and .ndo_open() cycle 2. some network driver statistics overflow on 32 bit platforms patch3 use pcpu statistics where necessary to remove frequent cacheline ping pongs. Jisheng Zhang (3): net: stmmac: don't clear network statistics in .ndo_open() net: stmmac: fix overflow of some network statistics net: stmmac: use pcpu statistics where necessary drivers/net/ethernet/stmicro/stmmac/common.h | 54 +++-- .../net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 15 +- .../ethernet/stmicro/stmmac/dwmac100_dma.c | 7 +- .../ethernet/stmicro/stmmac/dwmac4_descs.c | 13 +- .../net/ethernet/stmicro/stmmac/dwmac4_lib.c | 17 +- .../net/ethernet/stmicro/stmmac/dwmac_lib.c | 10 +- .../ethernet/stmicro/stmmac/dwxgmac2_descs.c | 6 +- .../ethernet/stmicro/stmmac/dwxgmac2_dma.c | 9 +- .../net/ethernet/stmicro/stmmac/enh_desc.c | 20 +- drivers/net/ethernet/stmicro/stmmac/hwif.h | 12 +- .../net/ethernet/stmicro/stmmac/norm_desc.c | 15 +- .../ethernet/stmicro/stmmac/stmmac_ethtool.c | 100 ++++++--- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 190 +++++++++++++----- 13 files changed, 304 insertions(+), 164 deletions(-)