mbox series

[next-next,v4,0/2] Add support for partial store and forward

Message ID 20230613054340.12837-1-pranavi.somisetty@amd.com
Headers
Series Add support for partial store and forward |

Message

Somisetty, Pranavi June 13, 2023, 5:43 a.m. UTC 
  Add support for partial store and forward mode in Cadence MACB.

Link for v1:
https://lore.kernel.org/all/20221213121245.13981-1-pranavi.somisetty@amd.com/

Changes v2:
1. Removed all the changes related to validating FCS when Rx checksum
offload is disabled.
2. Instead of using a platform dependent number (0xFFF) for the reset
value of rx watermark, derive it from designcfg_debug2 register.
3. Added a check to see if partial s/f is supported, by reading the
designcfg_debug6 register.
4. Added devicetree bindings for "rx-watermark" property.
Link for v2:
https://lore.kernel.org/all/20230511071214.18611-1-pranavi.somisetty@amd.com/

Changes v3:
1. Fixed DT schema error: "scalar properties shouldn't have array keywords"
2. Modified description of rx-watermark in to include units of the watermark value
3. Modified the DT property name corresponding to rx_watermark in pbuf_rxcutthru to
"cdns,rx-watermark".
4. Followed reverse christmas tree pattern in declaring variables.
5. Return -EINVAL when an invalid watermark value is set.
6. Removed netdev_info when partial store and forward is not enabled.
7. Validating the rx-watermark value in probe itself and only write to the register
in init.
8. Writing a reset value to the pbuf_cuthru register before disabing partial store
and forward is redundant. So removing it.
9. Removed the platform caps flag.
10. Instead of reading rx-watermark from DT in macb_configure_caps,
reading it in probe.
11. Changed Signed-Off-By and author names on the macb driver patch.
Link for v3:
https://lore.kernel.org/all/20230530095138.1302-1-pranavi.somisetty@amd.com/

Changes v4:
1. Modified description for "rx-watermark" property in the DT bindings.
2. Changed the width of the rx-watermark property to uint32.
3. Removed redundant code and unused variables.
4. When the rx-watermark value is invalid, instead of returning EINVAL,
do not enable partial store and forward. 

Maulik Jodhani (1):
  net: macb: Add support for partial store and forward

Pranavi Somisetty (1):
  dt-bindings: net: cdns,macb: Add rx-watermark property

 .../devicetree/bindings/net/cdns,macb.yaml    | 11 ++++++++
 drivers/net/ethernet/cadence/macb.h           | 12 +++++++++
 drivers/net/ethernet/cadence/macb_main.c      | 27 +++++++++++++++++++
 3 files changed, 50 insertions(+)

Comments

patchwork-bot+netdevbpf@kernel.org June 15, 2023, 7:50 a.m. UTC | #1 
Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Mon, 12 Jun 2023 23:43:38 -0600 you wrote:
> Add support for partial store and forward mode in Cadence MACB.
> 
> Link for v1:
> https://lore.kernel.org/all/20221213121245.13981-1-pranavi.somisetty@amd.com/
> 
> Changes v2:
> 1. Removed all the changes related to validating FCS when Rx checksum
> offload is disabled.
> 2. Instead of using a platform dependent number (0xFFF) for the reset
> value of rx watermark, derive it from designcfg_debug2 register.
> 3. Added a check to see if partial s/f is supported, by reading the
> designcfg_debug6 register.
> 4. Added devicetree bindings for "rx-watermark" property.
> Link for v2:
> https://lore.kernel.org/all/20230511071214.18611-1-pranavi.somisetty@amd.com/
> 
> [...]

Here is the summary with links:
  - [net-next,v4,1/2] dt-bindings: net: cdns,macb: Add rx-watermark property
    https://git.kernel.org/netdev/net-next/c/5b32c61a2dac
  - [net-next,v4,2/2] net: macb: Add support for partial store and forward
    https://git.kernel.org/netdev/net-next/c/cae4bc06b3e4

You are awesome, thank you!