From patchwork Sat Jun 10 00:51:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rae Moar X-Patchwork-Id: 10575 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1277246vqr; Fri, 9 Jun 2023 17:52:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6wdlQNs786aq0xIRJQaNez89X6vo/QCvohx+V38pFMZhGM79JKubNGTGcvoejttI5Wlxyb X-Received: by 2002:a05:6a00:14c2:b0:658:12ca:385b with SMTP id w2-20020a056a0014c200b0065812ca385bmr3101765pfu.22.1686358370656; Fri, 09 Jun 2023 17:52:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686358370; cv=none; d=google.com; s=arc-20160816; b=VHaCwdkVklxjmX34rCKDoScDSh+s/3RsvAkpr+Z27qGzUwF7sJcr1bVoPNgWAxVGHA begmWAVH8rdtP8NHH/MY5FXiKNudXX0FhMhZXmxJsTjrDpkZlaE4JhWN+YdtGTaezGFu UK+M2XirhQsKKiikJyGeNhiGhZYM46WlM9umCZ54dYXwxzzAs8zYNw3pHyL0yktyIWTM i45kAaFwmHNuN9mQDeuJbSuGG4Ae5Ov/66L8DR8YQU3w6ZxSA3EnIXPJNH385DN7ugyW 8TvSJ5Yln0AQV/FRBoReTJ8WxZqXHCmTbXM2sQJqPysyBTAq8bqXPU5yj3+803yIczLw BrGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:mime-version:date :dkim-signature; bh=Wg++2gE8/jht9e+KkYaoylKtJ1FY+uAMq5VBMWkg2vI=; b=T4GEqCrq6U3P6X3C23lXrJYMmUt9BARxOUxWAw9AFtK9IqtYUJh5EeLNkzCU/2W/Fx KWaQJCXcHxu5sj4ZilmKXn72Q4LZPTiNAf9cr8x4r0Bx1pDtXgaOgpciqPadtrp98IdT Bj4L7uIJxh8NwQYs4S5xFBCztv2B5f3NVVMygnblREjn34iXmyjZGQ/mv/RdTZLMzLcO 4Jaw8ydEaXEai/sVckAhu7WFXoybCzU4k87KLUOgAzqQgEP1W13Kdqz+ukt94OPQ/n4I Kjja4jkejLFZJ9+iI2VD2htilUTbom/ZVSxF/kcKoRvDkgpPoUlaigPcoJjQ9xT3Mapq jydQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=vZa0uQJu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bs8-20020a632808000000b0054b4670f5e0si460063pgb.39.2023.06.09.17.52.32; Fri, 09 Jun 2023 17:52:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=vZa0uQJu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230295AbjFJAwK (ORCPT + 99 others); Fri, 9 Jun 2023 20:52:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231154AbjFJAwI (ORCPT ); Fri, 9 Jun 2023 20:52:08 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77C1C19D for ; Fri, 9 Jun 2023 17:52:07 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-ba8338f20bdso3214190276.0 for ; Fri, 09 Jun 2023 17:52:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686358326; x=1688950326; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=Wg++2gE8/jht9e+KkYaoylKtJ1FY+uAMq5VBMWkg2vI=; b=vZa0uQJub1/SthRtIpRIUdBcECAOCf4iTZtfveOCEH2qhZXN6OXSLQU4rxA4XAuWzc rrF2wOzq4rqLr6cV80saM9nYxWLvo2dzC2QqLpKrmAn1QFps3fMUVaLZpX+hs6doupWf +pcjaEgSTskPgaJ+dIkjcli6C7/q6N210FLnQScBFO/2EXIWNa4dYsshbKQ4hJK7OqOp K3eLXaGxkOgCzqdEkUJPZgzhf8YRFJ4BmCoXVPCvTSlou9mIQf835BE68v9uc1K8AR9K naQ/WX8z5MCpfalOCjg4+ro4EyFf4vZOzWQX2gmnoKO08v9Kvq1jPYFGpDGQW6QQZ9aL 30zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686358326; x=1688950326; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Wg++2gE8/jht9e+KkYaoylKtJ1FY+uAMq5VBMWkg2vI=; b=GlCtfm5ux38ZcYdM5jt9kPErNc6ZUEPbTyNDCHmUDMaTmfp169i895LFbKDI2qLL3w elvcSJvBzYUXEecItpHIx1q+sW2E8oFFR1NNYIs5qc/z2bTTwEEy7dOUNQpTwZfk0v+t 1/XR9KRVlxQE7DCl616xEAkWXvjeKwooDvav6wYP701GKKmTu2BfDX05/Ga+YGxhBRZ8 Dfb+i/xZ4X43qlUTrGy3ba70qiWvSmN9m4chg/0eLmDLYEAjJge6Gp3yRLJ/YiA/xqF8 rfFpAFEa2QJYQ7GOaHycXneJszhoic6cJTxXauep3uyS8jQEQepPiBOA1KB3wR6cR84F yppw== X-Gm-Message-State: AC+VfDxXyx2lDlvQLHXjDdEticbVQU2/bW6J9DZNJ2T62k+PfEtyCFYq nWwna+rA9UqJEomXeLgcjcsWoT4pfA== X-Received: from rmoar-specialist.c.googlers.com ([fda3:e722:ac3:cc00:2b:7d90:c0a8:45d3]) (user=rmoar job=sendgmr) by 2002:a5b:b4a:0:b0:bac:f608:7113 with SMTP id b10-20020a5b0b4a000000b00bacf6087113mr1547448ybr.4.1686358326518; Fri, 09 Jun 2023 17:52:06 -0700 (PDT) Date: Sat, 10 Jun 2023 00:51:43 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.41.0.162.gfafddb0af9-goog Message-ID: <20230610005149.1145665-1-rmoar@google.com> Subject: [RFC v1 0/6] kunit: Add test attributes API From: Rae Moar To: shuah@kernel.org, davidgow@google.com, dlatypov@google.com, brendan.higgins@linux.dev Cc: linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, keescook@chromium.org, linux-hardening@vger.kernel.org, jstultz@google.com, tglx@linutronix.de, sboyd@kernel.org, Rae Moar X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768274914721160179?= X-GMAIL-MSGID: =?utf-8?q?1768274914721160179?= Hello everyone, This is an RFC patch series to propose the addition of a test attributes framework to KUnit. There has been interest in filtering out "slow" KUnit tests. Most notably, a new config, CONFIG_MEMCPY_SLOW_KUNIT_TEST, has been added to exclude particularly slow memcpy tests (https://lore.kernel.org/all/20230118200653.give.574-kees@kernel.org/). This proposed attributes framework would be used to save and access test associated data, including whether a test is slow. These attributes would be reportable (via KTAP and command line output) and some will be filterable. This framework is designed to allow for the addition of other attributes in the future. These attributes could include whether the test is flaky, associated test files, etc. Note that this could intersect with the discussions on how to format test-associated data in KTAP v2 that I am also involved in (https://lore.kernel.org/all/20230420205734.1288498-1-rmoar@google.com/). If the overall idea seems good, I'll make sure to add tests/documentation, and more patches marking existing tests as slow to the patch series. Thanks! Rae Rae Moar (6): kunit: Add test attributes API structure kunit: Add speed attribute kunit: Add ability to filter attributes kunit: tool: Add command line interface to filter and report attributes kunit: memcpy: Mark tests as slow using test attributes kunit: time: Mark test as slow using test attributes include/kunit/attributes.h | 41 ++++ include/kunit/test.h | 62 ++++++ kernel/time/time_test.c | 2 +- lib/kunit/Makefile | 3 +- lib/kunit/attributes.c | 280 +++++++++++++++++++++++++ lib/kunit/executor.c | 89 ++++++-- lib/kunit/executor_test.c | 8 +- lib/kunit/kunit-example-test.c | 9 + lib/kunit/test.c | 17 +- lib/memcpy_kunit.c | 8 +- tools/testing/kunit/kunit.py | 34 ++- tools/testing/kunit/kunit_kernel.py | 6 +- tools/testing/kunit/kunit_tool_test.py | 41 ++-- 13 files changed, 536 insertions(+), 64 deletions(-) create mode 100644 include/kunit/attributes.h create mode 100644 lib/kunit/attributes.c base-commit: fefdb43943c1a0d87e1b43ae4d03e5f9a1d058f4