From patchwork Thu Jun 8 08:44:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artem Savkov X-Patchwork-Id: 10469 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp144496vqr; Thu, 8 Jun 2023 02:12:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4HlHeD9g8megQXw1wdXXiIMPEQGyMN9QsCCkfzUHYvL9lxSKc+7jfo9bj9EcZLjrElaVhG X-Received: by 2002:a05:6359:31c:b0:123:1a41:3d8 with SMTP id ef28-20020a056359031c00b001231a4103d8mr5848779rwb.29.1686215520045; Thu, 08 Jun 2023 02:12:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686215520; cv=none; d=google.com; s=arc-20160816; b=YTkFVKPJ4Gkv/fHr8DZJXkYEAhiUF3OugSXwIjtaWkB+dtnpC01HeAqvvFDbYVyGNN knnaAIfNGwCllXJT03i0tOl1cPiXJ5vip3WGgH53XfffPXqE0RwblkncEAJZXbGgv4XT ZdZaes0ULysi1Fla6bvCb9AwOWYZfRJxYRmN2zRc1Ja2pWU1soCyU9luQ9lfY5MnK1Bd bldsBSKLEG+abiqMi4cNKfaUWJBwseYLl2nfUAVUPIvKTDmKRKLP+69ZW5f+IWwMGAfi 2/SjmvDd0OrQFoE2dg087eNzl57eDeAe8XdYHvWBsZHr2IZeGrTJriYtPLiVWEnUcwpO T96g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=fj2mCkYLNG5L67gHa0q5WGVDFbE4zI2Uml3ICcP6iqo=; b=EPhBeK3SYXxT/8pV3q4eeHphQT3OqzSkIFkspq2fTeZxrsYJETpOnPFwNXK5DF6E2X BgwMgzRIExSCunbySwm8JiZ9RRPIrbSyzF+JaJtycmB7EV2NiE8NFF7jpgmkjJTowIaU HRrZSr3PWjcaFLdzaFbGIdUc72BpvJNCg9xzpV9MD0xj6nO/5Bw5dS9k9idIU5guG/BM dBFib23Ntro4Gt0Rbgs0SSsMlLxafWNG0T8TLfSeKt91smJSWZsdd/bnUNDYIN2LJQUa 0mOpMtPjycZ044EbK4DruNOFM8OV3EItsdYXOMxkJ/e3TAEStTO3s6I19ASBGf+yLZgc vmIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZYUXH9OA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 67-20020a630246000000b00517a2ca5ecbsi701107pgc.692.2023.06.08.02.11.47; Thu, 08 Jun 2023 02:11:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZYUXH9OA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235496AbjFHIpM (ORCPT + 99 others); Thu, 8 Jun 2023 04:45:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229589AbjFHIpI (ORCPT ); Thu, 8 Jun 2023 04:45:08 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA89F2709 for ; Thu, 8 Jun 2023 01:44:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686213865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=fj2mCkYLNG5L67gHa0q5WGVDFbE4zI2Uml3ICcP6iqo=; b=ZYUXH9OAr7JYYHT5qHCNrbBnSjUIQVrl0UZZCZe0XwWYNkT/fanpZ10FUD2MDSVAvzqtfN vqavw+hxO2WlqTASvNgv12ZKMwKUwZ3sdzvR7btASwDNVPSxdUrs6m72OPTb2EhR2jxGOm XRN8W74lcHgDzCSVvsQ+1ohTTlfdD8c= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-226-7ktfpiYxMjyevyMBmDPXZQ-1; Thu, 08 Jun 2023 04:44:21 -0400 X-MC-Unique: 7ktfpiYxMjyevyMBmDPXZQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 76463802BF5; Thu, 8 Jun 2023 08:44:20 +0000 (UTC) Received: from samus.usersys.redhat.com (unknown [10.43.17.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id C498C40CFD46; Thu, 8 Jun 2023 08:44:18 +0000 (UTC) From: Artem Savkov To: linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , Namhyung Kim Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , linux-kernel@vger.kernel.org, Artem Savkov Subject: [PATCH v2 0/2] perf tools: annotation browser from c2c tui Date: Thu, 8 Jun 2023 10:44:05 +0200 Message-Id: <20230608084407.140323-1-asavkov@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768125124843541485?= X-GMAIL-MSGID: =?utf-8?q?1768125124843541485?= These patches add ability to start annotation browser from c2c report tui. The idea comes from Arnaldo's "Profiling Data Structures" talk [1]. [1]: http://vger.kernel.org/~acme/prez/linux-plumbers-2022/ v1->v2: Addressed comments from Namhyung Kim - No longer saving evsel for each hist entry, using evlist__first instead. - Factored out preparations to call annotation browser to do_annotate() function - Other small fixes and adjustments. Artem Savkov (2): perf util: move symbol__new_unresolved() to util/symbol.c perf tools: allow running annotation browser from c2c-report tools/perf/builtin-c2c.c | 73 +++++++++++++++++++++++++++++++--- tools/perf/ui/browsers/hists.c | 22 ---------- tools/perf/util/symbol.c | 22 ++++++++++ tools/perf/util/symbol.h | 1 + 4 files changed, 91 insertions(+), 27 deletions(-)