Message ID | 20230607203333.26669-1-risbhat@amazon.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp498618vqr; Wed, 7 Jun 2023 14:42:10 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4/s5aniHrjlD+AcvNJfGRNrMKCW5sUXceGiFjETeNCJOR969ycthipSNreYSJ/DxEQVn+x X-Received: by 2002:a17:902:f550:b0:1ac:b449:3528 with SMTP id h16-20020a170902f55000b001acb4493528mr6423669plf.46.1686174130066; Wed, 07 Jun 2023 14:42:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686174130; cv=none; d=google.com; s=arc-20160816; b=Nv7+zUOZqU65JMfpLM7waEU0ADX6OoCjHqPLP8oR/DzxbMrkggdGbR0U2m92zDbBvz 2L0Qpl85g78hCx4S8OwzNQglzgLVCYZ/YQDQbdH9V05ICFwqsXrrW6GF3d6KuXWyIfjW ZRaMsv7Z2WFMyrsYuFdUrKdy3FVXheHUdd5/nKOlz5UEq2asWy1LZxDo1svFKYSVKexu VM7nZM7P3j5HvUUhyUc6jwIp4MJbeO7FXuH1OxH4a8BJyQ4OYWHUg/A1VBu1qpqyyVzX x8IHffyIkEyO2sAufT2zmOC2ROHpoj2za0tz9k5tvDVtm50Wf0AOdxPAHuRIM4iIHaWO kQ7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=JFQnltE05obEPa/KtKPh+QioRvgaOvNdBJH+YPUUyrY=; b=kKEMyIDIpXnZQy64UEsP9Bi05GNH5HSeMPLHyk5rI4EXBk3BuJRDXK7/4fiJxrUoxE geDTXMO69bGjcxJ1BRqPt89mFjCgRHh6nKaBQ1PQ7MyjBvDNTQJAjPy7/Yjb6pxCKcgY uaKKUaEk7GwSluJ01lK0yCVXtmcVp82WmYKukO12lSD1hanqp0rAY/CEmbo/bGFpTnps 3yvFo2cZxPplsxqqyj5bEk6HO4829R9hH/PVKqxfpV3o32/d46s76ocug4/5lHUuFoKm CHrbBtIKz3vebWyiUK+e6nn8dINKEbqXZHvdhbtPe12fO4vOybJsFjIGWVV6nth+OaNO X9sg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=lzkTE7pP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w20-20020a170902c79400b001b23b699747si122pla.10.2023.06.07.14.41.55; Wed, 07 Jun 2023 14:42:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=lzkTE7pP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233838AbjFGUdm (ORCPT <rfc822;literming00@gmail.com> + 99 others); Wed, 7 Jun 2023 16:33:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233802AbjFGUdj (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 7 Jun 2023 16:33:39 -0400 Received: from smtp-fw-6002.amazon.com (smtp-fw-6002.amazon.com [52.95.49.90]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70F2E184; Wed, 7 Jun 2023 13:33:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1686170019; x=1717706019; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=JFQnltE05obEPa/KtKPh+QioRvgaOvNdBJH+YPUUyrY=; b=lzkTE7pPMPsptBoV40x+i9DKEraVwEBa5KZw/s+ehCtJ6jgCw4P/By7D UoNErAupcnC7+vRricJkh4mglPDR0FvC4O2ue4SMUIpzyUihIO4NryLi+ h6kFOnrAkcGmxMOlb27O0C57ETe8u+wEaVNtEyUgAAw/LtaMSd9DHtY2I Q=; X-IronPort-AV: E=Sophos;i="6.00,225,1681171200"; d="scan'208";a="337509663" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-iad-1e-m6i4x-3e1fab07.us-east-1.amazon.com) ([10.43.8.6]) by smtp-border-fw-6002.iad6.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2023 20:33:38 +0000 Received: from EX19MTAUWB002.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1e-m6i4x-3e1fab07.us-east-1.amazon.com (Postfix) with ESMTPS id 7CA1D804AF; Wed, 7 Jun 2023 20:33:36 +0000 (UTC) Received: from EX19D002UWA004.ant.amazon.com (10.13.138.230) by EX19MTAUWB002.ant.amazon.com (10.250.64.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Wed, 7 Jun 2023 20:33:34 +0000 Received: from EX19MTAUWA001.ant.amazon.com (10.250.64.204) by EX19D002UWA004.ant.amazon.com (10.13.138.230) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Wed, 7 Jun 2023 20:33:34 +0000 Received: from dev-dsk-risbhat-2b-8bdc64cd.us-west-2.amazon.com (10.189.73.169) by mail-relay.amazon.com (10.250.64.204) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Wed, 7 Jun 2023 20:33:34 +0000 Received: by dev-dsk-risbhat-2b-8bdc64cd.us-west-2.amazon.com (Postfix, from userid 22673075) id 53423222F; Wed, 7 Jun 2023 20:33:34 +0000 (UTC) From: Rishabh Bhatnagar <risbhat@amazon.com> To: <gregkh@linuxfoundation.org> CC: <sfrench@amazon.com>, <stable@vger.kernel.org>, <linux-cifs@vger.kernel.org>, <linux-kernel@vger.kernel.org>, "Rishabh Bhatnagar" <risbhat@amazon.com> Subject: [PATCH v2 5.4 0/2] Backport few dfs related fixes to cifs Date: Wed, 7 Jun 2023 20:33:31 +0000 Message-ID: <20230607203333.26669-1-risbhat@amazon.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768073149365260930?= X-GMAIL-MSGID: =?utf-8?q?1768081724283466700?= |
Series |
Backport few dfs related fixes to cifs
|
|
Message
Rishabh Bhatnagar
June 7, 2023, 8:33 p.m. UTC
Recently we have been seeing kernel panic in cifs_reconnect function while accessing tgt_list. Looks like tgt_list is not initialized correctly. There are fixes already present in 5.10 and later trees. Backporting them to 5.4 CIFS VFS: \\172.30.1.14 cifs_reconnect: no target servers for DFS failover BUG: unable to handle page fault for address: fffffffffffffff8 #PF: supervisor read access in kernel mode #PF: error_code(0x0000) - not-present page PGD 260e067 P4D 260e067 PUD 2610067 PMD 0 Oops: 0000 [#1] SMP PTI RIP: 0010:cifs_reconnect+0x51d/0xef0 [cifs] RSP: 0018:ffffc90000693da0 EFLAGS: 00010282 RAX: fffffffffffffff8 RBX: ffff8887fa63b800 RCX: fffffffffffffff8 Call Trace: cifs_handle_standard+0x18d/0x1b0 [cifs] cifs_demultiplex_thread+0xa5c/0xc90 [cifs] kthread+0x113/0x130 Paulo Alcantara (2): cifs: get rid of unused parameter in reconn_setup_dfs_targets() cifs: handle empty list of targets in cifs_reconnect() fs/cifs/connect.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-)
Comments
Rishabh Bhatnagar <risbhat@amazon.com> writes: > Recently we have been seeing kernel panic in cifs_reconnect function > while accessing tgt_list. Looks like tgt_list is not initialized > correctly. There are fixes already present in 5.10 and later trees. > Backporting them to 5.4 > > CIFS VFS: \\172.30.1.14 cifs_reconnect: no target servers for DFS > failover > BUG: unable to handle page fault for address: fffffffffffffff8 > #PF: supervisor read access in kernel mode > #PF: error_code(0x0000) - not-present page > PGD 260e067 P4D 260e067 PUD 2610067 PMD 0 > Oops: 0000 [#1] SMP PTI > RIP: 0010:cifs_reconnect+0x51d/0xef0 [cifs] > RSP: 0018:ffffc90000693da0 EFLAGS: 00010282 > RAX: fffffffffffffff8 RBX: ffff8887fa63b800 RCX: fffffffffffffff8 > Call Trace: > cifs_handle_standard+0x18d/0x1b0 [cifs] > cifs_demultiplex_thread+0xa5c/0xc90 [cifs] > kthread+0x113/0x130 > > Paulo Alcantara (2): > cifs: get rid of unused parameter in reconn_setup_dfs_targets() > cifs: handle empty list of targets in cifs_reconnect() > > fs/cifs/connect.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) Looks good.
On Thu, Jun 08, 2023 at 05:54:26PM -0300, Paulo Alcantara wrote: > Rishabh Bhatnagar <risbhat@amazon.com> writes: > > > Recently we have been seeing kernel panic in cifs_reconnect function > > while accessing tgt_list. Looks like tgt_list is not initialized > > correctly. There are fixes already present in 5.10 and later trees. > > Backporting them to 5.4 > > > > CIFS VFS: \\172.30.1.14 cifs_reconnect: no target servers for DFS > > failover > > BUG: unable to handle page fault for address: fffffffffffffff8 > > #PF: supervisor read access in kernel mode > > #PF: error_code(0x0000) - not-present page > > PGD 260e067 P4D 260e067 PUD 2610067 PMD 0 > > Oops: 0000 [#1] SMP PTI > > RIP: 0010:cifs_reconnect+0x51d/0xef0 [cifs] > > RSP: 0018:ffffc90000693da0 EFLAGS: 00010282 > > RAX: fffffffffffffff8 RBX: ffff8887fa63b800 RCX: fffffffffffffff8 > > Call Trace: > > cifs_handle_standard+0x18d/0x1b0 [cifs] > > cifs_demultiplex_thread+0xa5c/0xc90 [cifs] > > kthread+0x113/0x130 > > > > Paulo Alcantara (2): > > cifs: get rid of unused parameter in reconn_setup_dfs_targets() > > cifs: handle empty list of targets in cifs_reconnect() > > > > fs/cifs/connect.c | 15 ++++++++------- > > 1 file changed, 8 insertions(+), 7 deletions(-) > > Looks good. Now queued up, thanks. greg k-h