From patchwork Wed Jun 7 18:09:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aleksandr Mikhalitsyn X-Patchwork-Id: 10443 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp392145vqr; Wed, 7 Jun 2023 11:13:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7D4NK2lv6K8LJmEbLriIkHfK83TZXbo+6tZGU2q6tu50mDZbDpzIRq/mFOwRh+5hD01F6/ X-Received: by 2002:a17:90b:e0e:b0:253:6a05:1bce with SMTP id ge14-20020a17090b0e0e00b002536a051bcemr2280676pjb.35.1686161625286; Wed, 07 Jun 2023 11:13:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686161625; cv=none; d=google.com; s=arc-20160816; b=fhmqD33K9MbC1zbW4x6cAlqB1IOadIOzrO0K1U55siT5YouMvGv+UazVosY3OuvU8v wlbcpJk4nYu43PNtipaRQdf9Z2UCQGDqx7Wuc8GO9poSRms8vV44iVEFmMlGc5WBs8/i zHUcTiHdllSxhd+ur4a1BmsqikJ6F/Bb9FlgVUdYeWKzKNpJ/UkhlYVRCxWIq+CweBO1 v9YRXmA2+6h2757lkGtuve0rwfmV5VqKf1PqnpLGEDaWF14+Xsr4YIkXr0GzO4zznGQF 3+VB4YFMarkBrYj93vrlbt2K2iBHdQlFwc4lWXcEp0skpXcVZlLuPWDONu2ERvXiU3C3 hVfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=OHIZE55DRONU2M77dhxlQwcXUrc0vedFNZBupvTYJA8=; b=eRwY1I2ivGRgeE1hPVFcNtvviII+hRqODJl73LsJkyOF/7e/j8iOHcCL7aoGUe75QG kwy9A+sRBqLEcqpFkJjTfIOBgZeuCXhfNXBOy2H2017tbhAygkRtdQpzxeW/v1/6ohJ0 G2C4S4KbdN6bRulHzS2AWkoFyUI7mnl+GOQeB0J2g7u9OCfJSgNZXtWEdEj1yYx7t259 C3soBTmpX9ILvjZ9Txh5USaMaOYdzks2koGrz97F1CC1wjZTNIU6pFKYbsE2eGvV5WEw MjQbClFLnPCHCxjK4k3GPGbbnwD3czWPgOop21e7mjcJo0XykFaEpPWvwKDb3nwLJpbs HNuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=gPC5Y0Us; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u63-20020a17090a51c500b00256cba1cadesi1439131pjh.50.2023.06.07.11.13.31; Wed, 07 Jun 2023 11:13:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=gPC5Y0Us; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232508AbjFGSKj (ORCPT + 99 others); Wed, 7 Jun 2023 14:10:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232463AbjFGSKe (ORCPT ); Wed, 7 Jun 2023 14:10:34 -0400 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 401AD1FD8 for ; Wed, 7 Jun 2023 11:10:30 -0700 (PDT) Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id CB4B93F120 for ; Wed, 7 Jun 2023 18:10:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1686161427; bh=OHIZE55DRONU2M77dhxlQwcXUrc0vedFNZBupvTYJA8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=gPC5Y0UsSZYELzEqb69inSSTH6gr4kpnUJDuIxYwTx3BqDW6OyaEUlHHPs3Z3eZZ/ ZPq4mTxMxWu8DWtgReSENb8S1Tv+8V6suuNvVjwQ5b1kkFCl5J8HVdO507hszu4nDp 3I43FreBgN1m5iX5DbuH+9ldRyB3bDmHtLwMUALHx6DVfVI0jvOZ6Hgy+9wO5UmZvV OEaW1ar/jqUDmQZ0BDhINaASq8mqvtrDgyVYw/WqfsZlfM99bsAHQRoFUPL9/TRgnM v2vWFR7gOtWvVUf2j05otLJzk1Nv0c1IKNonhp8nYdkZ/TOizvvsGnTyo8Xi89kRcF nNywfm0XWu1jA== Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-977d0333523so459035666b.0 for ; Wed, 07 Jun 2023 11:10:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686161427; x=1688753427; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OHIZE55DRONU2M77dhxlQwcXUrc0vedFNZBupvTYJA8=; b=AXswmkzLi73phee9oEJk+9eXsJNIgg890Y3r2P8EVnFQjp8xJKnuIs9afJhHCSCV3O T8hEnEI2lWcaTq968u6OhusVASAKT6mjzqHexPvCq8faGfq4/9RV42UD+3VK55DH5Z7c VVsPr28N06XnSz/vefhTLzGyfNuUJcaGAaL8lGbsIpvnqnk0heHzi0VDQb7C54vvWNxL iFWhbQsKjjXlYZYSO6xKpmSXBwDYmTE1GQqMloufzcUw9KWaHUrQEHCBC7+W22NLmobf otwY8XHaGrWnIGD2FaQs6D6MtBGTAQoUwDq0X5A8Qm8h/rBWYC+RdXq4/R9uytEO6u16 P6aA== X-Gm-Message-State: AC+VfDzdophdZtvvs5rYlhCm95lC6epUDysBhrKjvU53aZVnXkrmcA0N 7O9s/wKeFObtdM+swQ/7WH4Ne8/HaU4sq0H1X/Q6KYfTYVgyNze83Ji27otWkzsN3BaHNU9ba5R mcqSo2RATD/+cmLCS58Xro93vDil+K+97Ah7X0UQ6TQ== X-Received: by 2002:a17:907:7214:b0:961:2956:2ed9 with SMTP id dr20-20020a170907721400b0096129562ed9mr7225599ejc.25.1686161427446; Wed, 07 Jun 2023 11:10:27 -0700 (PDT) X-Received: by 2002:a17:907:7214:b0:961:2956:2ed9 with SMTP id dr20-20020a170907721400b0096129562ed9mr7225583ejc.25.1686161427163; Wed, 07 Jun 2023 11:10:27 -0700 (PDT) Received: from amikhalitsyn.local (dslb-002-205-064-187.002.205.pools.vodafone-ip.de. [2.205.64.187]) by smtp.gmail.com with ESMTPSA id oz17-20020a170906cd1100b009745edfb7cbsm7170494ejb.45.2023.06.07.11.10.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 11:10:26 -0700 (PDT) From: Alexander Mikhalitsyn To: xiubli@redhat.com Cc: brauner@kernel.org, stgraber@ubuntu.com, linux-fsdevel@vger.kernel.org, Alexander Mikhalitsyn , Ilya Dryomov , Jeff Layton , ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 00/14] ceph: support idmapped mounts Date: Wed, 7 Jun 2023 20:09:43 +0200 Message-Id: <20230607180958.645115-1-aleksandr.mikhalitsyn@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766791385985146616?= X-GMAIL-MSGID: =?utf-8?q?1768068612704784578?= Dear friends, This patchset was originally developed by Christian Brauner but I'll continue to push it forward. Christian allowed me to do that :) This feature is already actively used/tested with LXD/LXC project. Git tree (based on https://github.com/ceph/ceph-client.git master): https://github.com/mihalicyn/linux/tree/fs.idmapped.ceph In the version 3 I've changed only two commits: - fs: export mnt_idmap_get/mnt_idmap_put - ceph: allow idmapped setattr inode op and added a new one: - ceph: pass idmap to __ceph_setattr In the version 4 I've reworked the ("ceph: stash idmapping in mdsc request") commit. Now we take idmap refcounter just in place where req->r_mnt_idmap is filled. It's more safer approach and prevents possible refcounter underflow on error paths where __register_request wasn't called but ceph_mdsc_release_request is called. I can confirm that this version passes xfstests. Links to previous versions: v1: https://lore.kernel.org/all/20220104140414.155198-1-brauner@kernel.org/ v2: https://lore.kernel.org/lkml/20230524153316.476973-1-aleksandr.mikhalitsyn@canonical.com/ v3: https://lore.kernel.org/lkml/20230607152038.469739-1-aleksandr.mikhalitsyn@canonical.com/#t Kind regards, Alex Original description from Christian: ======================================================================== This patch series enables cephfs to support idmapped mounts, i.e. the ability to alter ownership information on a per-mount basis. Container managers such as LXD support sharaing data via cephfs between the host and unprivileged containers and between unprivileged containers. They may all use different idmappings. Idmapped mounts can be used to create mounts with the idmapping used for the container (or a different one specific to the use-case). There are in fact more use-cases such as remapping ownership for mountpoints on the host itself to grant or restrict access to different users or to make it possible to enforce that programs running as root will write with a non-zero {g,u}id to disk. The patch series is simple overall and few changes are needed to cephfs. There is one cephfs specific issue that I would like to discuss and solve which I explain in detail in: [PATCH 02/12] ceph: handle idmapped mounts in create_request_message() It has to do with how to handle mds serves which have id-based access restrictions configured. I would ask you to please take a look at the explanation in the aforementioned patch. The patch series passes the vfs and idmapped mount testsuite as part of xfstests. To run it you will need a config like: [ceph] export FSTYP=ceph export TEST_DIR=/mnt/test export TEST_DEV=10.103.182.10:6789:/ export TEST_FS_MOUNT_OPTS="-o name=admin,secret=$password and then simply call sudo ./check -g idmapped ======================================================================== Alexander Mikhalitsyn (2): fs: export mnt_idmap_get/mnt_idmap_put ceph: pass idmap to __ceph_setattr Christian Brauner (12): ceph: stash idmapping in mdsc request ceph: handle idmapped mounts in create_request_message() ceph: allow idmapped mknod inode op ceph: allow idmapped symlink inode op ceph: allow idmapped mkdir inode op ceph: allow idmapped rename inode op ceph: allow idmapped getattr inode op ceph: allow idmapped permission inode op ceph: allow idmapped setattr inode op ceph/acl: allow idmapped set_acl inode op ceph/file: allow idmapped atomic_open inode op ceph: allow idmapped mounts fs/ceph/acl.c | 6 +++--- fs/ceph/dir.c | 4 ++++ fs/ceph/file.c | 10 ++++++++-- fs/ceph/inode.c | 29 +++++++++++++++++------------ fs/ceph/mds_client.c | 27 +++++++++++++++++++++++---- fs/ceph/mds_client.h | 1 + fs/ceph/super.c | 2 +- fs/ceph/super.h | 3 ++- fs/mnt_idmapping.c | 2 ++ include/linux/mnt_idmapping.h | 3 +++ 10 files changed, 64 insertions(+), 23 deletions(-)