From patchwork Mon Jun 5 17:05:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 10316 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2842731vqr; Mon, 5 Jun 2023 10:27:30 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6uSihy5OsKqBtbSL1PQrMmvnj73FwHluxR31eRjotJ6IBno0InSAtofRxGgC1Cv8hM4I+H X-Received: by 2002:a05:6a20:3948:b0:10b:855b:a39f with SMTP id r8-20020a056a20394800b0010b855ba39fmr8669124pzg.44.1685986050611; Mon, 05 Jun 2023 10:27:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685986050; cv=none; d=google.com; s=arc-20160816; b=zBNvnqe7+zw6NJLUeXnnjtZyNzzs+4Cezx5SGZUnXnZIuabebWGaPpOJ8pB29cVwjQ 40Q6jm0KE6cF7hfqEpDZhEQJQrWsyOSoUBczNUll0nu/+thOUOqqxugdmYbY+sUyvSZt kOD6j7/muvVMUetCDZtTl1nNoMn+7pKzCgaag017Bw+wm6y0sp8nYtc9AY+VAa6J9tEq HJ73A0K+PN2OxuOZ68Eofw7a3ezj0OjvQuVdiHmVLspFBlWnzppqQ2ENCB7QTlORQlbH w90sETYGdG61tmmsf5f0XL04a663VD/470xVwbIi72/sMtCC6BLkQwMMUvzoMyV0iyz4 j+Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=JWVyYKrCozahW36iJhimrL5h+3fNBbNlV1G6FEYMjGo=; b=ZJsTpv6z8VLq5x0YHr5TjxKnrUGaLL1bwmxGvpRa0dWD8egNwXfnLz8qTMRP4hf1Na i6+KkpwVT9L+DFZWsXngIyoLohgbrrWiyonB3juQFAEUFJACXJxYAChIqXOciKemzbAe kFsKmMBKtJZ1gtduiZEJob7qzOc1Sjpo8WPQLH+O61r2kw3MwMjkVOq7lR5iOqvYlj2x qCEdx8V4UwSixKlzNfOHECH0MR0JxMlX5QZqv9Pzp5w3QA+Vws2Qi8nXKrgNsO+lRRWQ TTbBFUB7kZLnapbpUnFBI8jdz6QARNNFBOeEiSnnIPbEcKhvUlqXymF9cuY2VAenUBoq POww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="hq4be/5W"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r17-20020a638f51000000b0053f0cdab820si5876931pgn.259.2023.06.05.10.27.18; Mon, 05 Jun 2023 10:27:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="hq4be/5W"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235280AbjFERGK (ORCPT + 99 others); Mon, 5 Jun 2023 13:06:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235181AbjFERGA (ORCPT ); Mon, 5 Jun 2023 13:06:00 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 860C2CD; Mon, 5 Jun 2023 10:05:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685984758; x=1717520758; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=yNqEF3trYoU7hnGxpDpvi8nhlncENBsYKi1m/ukv08Q=; b=hq4be/5W6Z8JGFSbLxh4Q45s/wDXvLzCR3v1jDywRINqCA6+eqtI4UW4 9xNuLmfraX1dldD2iXKD9XtV5V9zGiszQD/IdD6UEEVF/QWmRyAWFZTAz fDsS0YrgbKTgU6cmhXm2l7vQ8J8M4xCRhMFn6/kbzB5vC12vhTQq+juiW n3TGfkWUfCyMSYXDJjnrjgKo30mtV8tlYIwLpJHIyiuvCYQXelJUsFu6y wOC8w62JQY+r1NeQ4pePG5p61iw0NvtIDuIFoG9tJK2zsLWSfQt0s6yDk w+Gze3ia34R56QhkbSu/Zy0WzHoCSWKOh3QQFylsTTImC9LJ/QTBwF/Oi Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10732"; a="356431394" X-IronPort-AV: E=Sophos;i="6.00,218,1681196400"; d="scan'208";a="356431394" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2023 10:05:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10732"; a="773807506" X-IronPort-AV: E=Sophos;i="6.00,218,1681196400"; d="scan'208";a="773807506" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga008.fm.intel.com with ESMTP; 05 Jun 2023 10:05:49 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 86EF6204; Mon, 5 Jun 2023 20:05:56 +0300 (EEST) From: Andy Shevchenko To: Kees Cook , Greg Kroah-Hartman , Andy Shevchenko , Cezary Rojewski , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Theodore Ts'o" , Jan Kara , Andy Shevchenko , "Rafael J. Wysocki" Subject: [PATCH v3 0/3] lib/string_helpers et al.: Change return value of strreplace() Date: Mon, 5 Jun 2023 20:05:50 +0300 Message-Id: <20230605170553.7835-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761162594990678847?= X-GMAIL-MSGID: =?utf-8?q?1767884509181243011?= It's more convenient to have strreplace() to return the pointer to the string itself. This will help users to make their code better. The patch 1 kills the only user of the returned value of strreplace(), Patch 2 converts the return value of strreplace(). And patch 3 shows how it may be useful. That said, the series can be routed via fs tree, with or without the last patch. In v3: - rebased on top of latest Linux Next In v2: - removed not anymore used variable (LKP) - added tag (Jan) - fixed wording (Kees) - actually return the pointer to the string itself Andy Shevchenko (3): jbd2: Avoid printing outside the boundary of the buffer lib/string_helpers: Change returned value of the strreplace() kobject: Use return value of strreplace() fs/jbd2/journal.c | 6 ++---- include/linux/string.h | 2 +- lib/kobject.c | 3 +-- lib/string_helpers.c | 12 ++++++++---- 4 files changed, 12 insertions(+), 11 deletions(-)