From patchwork Mon Jun 5 13:34:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miquel Raynal X-Patchwork-Id: 10302 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2710207vqr; Mon, 5 Jun 2023 07:06:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5siLj47kGpuBAGDVeIA4kEvxhawvQqRf6bETn9O1WfjktQWkYzKxza2/xj0KMy4l4dw2Q7 X-Received: by 2002:a05:6a00:8ce:b0:65b:bb3b:3c10 with SMTP id s14-20020a056a0008ce00b0065bbb3b3c10mr1425240pfu.33.1685973993945; Mon, 05 Jun 2023 07:06:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685973993; cv=none; d=google.com; s=arc-20160816; b=BZqo3qpBKjbcTTd6oxE4N1NsYGIHC1wd2NtDdQeMBQoAkRXHCkyvvR0KC5FZ9TzXSO mhDJcHLYww/naUQv20uFuog8fAD9VvJxLzt4G5bbCWzLWKeUEgvylTArB7CYaN1T+12Y 3EYYZ6zDXG2N0mzcIjiaatrPSkzI89voF/VzAOnh1spP8H98il0voD+jf9fhmKGA5z8y VpSIEpScXJB+xkobw6eYjR/GkR7RYm1AcEnju41Mam9C+n3W3xbC0IQ2y1dxPEtHY+ul LwrZa/zm6F1uVfYQvC9R31UJw9W1pSuC+wCYdF4sZXFrQEsSYHSgn6n037GBr6293LGw 5cbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=yE7sF+x8K7tNSjAqK5ooKbbzOAL8pI+zrE1bWZC1X0I=; b=wL0DQsr+S7LUyG4lZtH56i+mu3qPl3gc6fViRd/5iXZoovsuWEht11q9ufbCpAciZ5 cmaoVLiQcTXOK2zv8OWvjLRL2Vqha4qrd+rGqQMSv9HuefXSp2JbQE/u38T+wcE1+Zjg 3Xy9Ex/WOvgy3onLGzZbSaU0n0pN06fuj0EO7Zn3k17WCusYMILURBAjx9Y8zboFQaRn hgqNKPiwdJlNskScwvjFaLls6c/UDFPdnMmdYIU4cWNdGzmiGf6Ug3My6r5d3Q3UgUDM GHTncHou7Sa3IL/bN0NCKKEudNRoV9l51xxNqoiuCnCGWARfFTQsmn4+l9/duwlVh5dS wHiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=o52rbI88; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y29-20020aa79e1d000000b00658e15b952asi2318361pfq.213.2023.06.05.07.06.19; Mon, 05 Jun 2023 07:06:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=o52rbI88; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234114AbjFENef (ORCPT + 99 others); Mon, 5 Jun 2023 09:34:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231808AbjFENe1 (ORCPT ); Mon, 5 Jun 2023 09:34:27 -0400 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05204DA for ; Mon, 5 Jun 2023 06:34:24 -0700 (PDT) X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1685972063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=yE7sF+x8K7tNSjAqK5ooKbbzOAL8pI+zrE1bWZC1X0I=; b=o52rbI88Qw4niNvd6Va7s2dzsikCu0r09ARrjR70Ib0+CBoAOpBdAzBeGdb5TUux9rNzWv A5wYFEjm443h1fCv4O5nUBoddOsM6KUyYI8j5dIhe94NQ4YxEv7gc0zDkuj7DcOdyAmMLE ne8QnhYFSKnodkG/SVuqgStE7P4iy1zQODtfQOmCH/Bo9EhgzxZc4fpWAp/aaR+/arixty adxgadjXhgeFOE420BV8LYHLvEwrAt0hmLsHRI7LxkWXDnBGYtdRVFFNDfzzuvBDh2PIfd O1/PQkL67k9xW6HucqymcgWrVHiLSPGi3y6F1YGXSqkbe1DX8YW8IRbTbCL21Q== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id B5C22FF807; Mon, 5 Jun 2023 13:34:22 +0000 (UTC) From: Miquel Raynal To: Greg Kroah-Hartman Cc: Luka Perkov , Robert Marko , Thomas Petazzoni , , Srinivas Kandagatla , Rafael J Wysocki , Miquel Raynal Subject: [PATCH v3 0/4] NVMEM cells in sysfs Date: Mon, 5 Jun 2023 15:34:18 +0200 Message-Id: <20230605133422.45840-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767871866550410827?= X-GMAIL-MSGID: =?utf-8?q?1767871866550410827?= Hello, As part of a previous effort, support for dynamic NVMEM layouts was brought into mainline, helping a lot in getting information from NVMEM devices at non-static locations. One common example of NVMEM cell is the MAC address that must be used. Sometimes the cell content is mainly (or only) useful to the kernel, and sometimes it is not. Users might also want to know the content of cells such as: the manufacturing place and date, the hardware version, the unique ID, etc. Two possibilities in this case: either the users re-implement their own parser to go through the whole device and search for the information they want, or the kernel can expose the content of the cells if deemed relevant. This second approach sounds way more relevant than the first one to avoid useless code duplication, so here is a series bringing NVMEM cells content to the user through sysfs. Here is a real life example with a Marvell Armada 7040 TN48m switch: $ nvmem=/sys/bus/nvmem/devices/1-00563/ $ for i in `ls -1 $nvmem/cells/*`; do basename $i; hexdump -C $i | head -n1; done country-code 00000000 54 57 |TW| crc32 00000000 bb cd 51 98 |..Q.| device-version 00000000 02 |.| diag-version 00000000 56 31 2e 30 2e 30 |V1.0.0| label-revision 00000000 44 31 |D1| mac-address 00000000 18 be 92 13 9a 00 |......| manufacture-date 00000000 30 32 2f 32 34 2f 32 30 32 31 20 31 38 3a 35 39 |02/24/2021 18:59| manufacturer 00000000 44 4e 49 |DNI| num-macs 00000000 00 40 |.@| onie-version 00000000 32 30 32 30 2e 31 31 2d 56 30 31 |2020.11-V01| platform-name 00000000 38 38 46 37 30 34 30 2f 38 38 46 36 38 32 30 |88F7040/88F6820| product-name 00000000 54 4e 34 38 4d 2d 50 2d 44 4e |TN48M-P-DN| serial-number 00000000 54 4e 34 38 31 50 32 54 57 32 30 34 32 30 33 32 |TN481P2TW2042032| vendor 00000000 44 4e 49 |DNI| Here is a list of known limitations though: * It is currently not possible to know whether the cell contains ASCII or binary data, so by default all cells are exposed in binary form. * For now the implementation focuses on the read aspect. Technically speaking, in some cases, it could be acceptable to write the cells, I guess, but for now read-only files sound more than enough. A writable path can be added later anyway. * The sysfs entries are created when the device probes, not when the NVMEM driver does. This means, if an NVMEM layout is used *and* compiled as a module *and* not installed properly in the system (a usermode helper tries to load the module otherwise), then the sysfs cells won't appear when the layout is actually insmod'ed because the sysfs folders/files have already been populated. Changes in v3: * Patch 1 is new: fix a style issue which bothered me when reading the core. * Patch 2 is new: Don't error out when an attribute group does not contain any attributes, it's easier for developers to handle "empty" directories this way. It avoids strange/bad solutions to be implemented and does not cost much. * Drop the is_visible hook as it is no longer needed. * Stop allocating an empty attribute array to comply with the sysfs core checks (this check has been altered in the first commits). * Fix a missing tab in the ABI doc. Changes in v2: * Do not mention the cells might become writable in the future in the ABI documentation. * Fix a wrong return value reported by Dan and kernel test robot. * Implement .is_bin_visible(). * Avoid overwriting the list of attribute groups, but keep the cells attribute group writable as we need to populate it at run time. * Improve the commit messages. * Give a real life example in the cover letter. Miquel Raynal (4): sysfs: Improve readability by following the kernel coding style sysfs: Skip empty folders creation ABI: sysfs-nvmem-cells: Expose cells through sysfs nvmem: core: Expose cells through sysfs Documentation/ABI/testing/sysfs-nvmem-cells | 19 +++ drivers/nvmem/core.c | 128 +++++++++++++++++++- fs/sysfs/group.c | 12 +- 3 files changed, 151 insertions(+), 8 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-nvmem-cells