mbox series

[v3,0/8] RK3588 ADC support

Message ID 20230603185340.13838-1-shreeya.patel@collabora.com
Headers
Series RK3588 ADC support |

Message

Shreeya Patel June 3, 2023, 6:53 p.m. UTC 
  This patch series adds ADC support for RK3588 and updates
the DT bindings for the same.

To test ADC support on Rock 5B board, a voltage divider circuit
was created using the gpio pin 22 ( SARADC_IN4 ) and few more
tests were ran for testing the buffer and trigger support using
the iio_generic_buffer tool.

Changes in v3
  - Add bitfield.h header file in patch 2.
  - Add a Reviewed-by tag in patch 2.
  - Do not remove clock enabling and disabling from the suspend and
    resume functions respectively in patch 3

Changes in v2
  - Add from address in patches 1 and 2.
  - Create separate patches for adding new device support and changes to
    the old device code.
  - Make use of FIELD_PREP in patch 2.
  - Move the enablement of clocks at it's original position in patch 3
  - Add Reviewed-by tag in patches 4 and 5.
  - Add an Acked-by tag in patch 8.

Shreeya Patel (8):
  iio: adc: rockchip_saradc: Add callback functions
  iio: adc: rockchip_saradc: Add support for RK3588
  iio: adc: rockchip_saradc: Make use of devm_clk_get_enabled
  iio: adc: rockchip_saradc: Use of_device_get_match_data
  iio: adc: rockchip_saradc: Match alignment with open parenthesis
  iio: adc: rockchip_saradc: Use dev_err_probe
  arm64: dts: rockchip: Add DT node for ADC support in RK3588
  dt-bindings: iio: adc: Add rockchip,rk3588-saradc string

 .../bindings/iio/adc/rockchip-saradc.yaml     |   1 +
 arch/arm64/boot/dts/rockchip/rk3588s.dtsi     |  12 +
 drivers/iio/adc/rockchip_saradc.c             | 246 +++++++++++-------
 3 files changed, 168 insertions(+), 91 deletions(-)

Comments

Andy Shevchenko June 3, 2023, 8:50 p.m. UTC | #1 
Sun, Jun 04, 2023 at 12:23:32AM +0530, Shreeya Patel kirjoitti:
> This patch series adds ADC support for RK3588 and updates
> the DT bindings for the same.
> 
> To test ADC support on Rock 5B board, a voltage divider circuit
> was created using the gpio pin 22 ( SARADC_IN4 ) and few more
> tests were ran for testing the buffer and trigger support using
> the iio_generic_buffer tool.

Well done!

For patches 1-6
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
(with one nit-pick to be addressed)

> Changes in v3
>   - Add bitfield.h header file in patch 2.
>   - Add a Reviewed-by tag in patch 2.
>   - Do not remove clock enabling and disabling from the suspend and
>     resume functions respectively in patch 3
> 
> Changes in v2
>   - Add from address in patches 1 and 2.
>   - Create separate patches for adding new device support and changes to
>     the old device code.
>   - Make use of FIELD_PREP in patch 2.
>   - Move the enablement of clocks at it's original position in patch 3
>   - Add Reviewed-by tag in patches 4 and 5.
>   - Add an Acked-by tag in patch 8.
> 
> Shreeya Patel (8):
>   iio: adc: rockchip_saradc: Add callback functions
>   iio: adc: rockchip_saradc: Add support for RK3588
>   iio: adc: rockchip_saradc: Make use of devm_clk_get_enabled
>   iio: adc: rockchip_saradc: Use of_device_get_match_data
>   iio: adc: rockchip_saradc: Match alignment with open parenthesis
>   iio: adc: rockchip_saradc: Use dev_err_probe
>   arm64: dts: rockchip: Add DT node for ADC support in RK3588
>   dt-bindings: iio: adc: Add rockchip,rk3588-saradc string
> 
>  .../bindings/iio/adc/rockchip-saradc.yaml     |   1 +
>  arch/arm64/boot/dts/rockchip/rk3588s.dtsi     |  12 +
>  drivers/iio/adc/rockchip_saradc.c             | 246 +++++++++++-------
>  3 files changed, 168 insertions(+), 91 deletions(-)
> 
> -- 
> 2.30.2
>
Jonathan Cameron June 4, 2023, 10:27 a.m. UTC | #2 
On Sat, 3 Jun 2023 23:50:09 +0300
andy.shevchenko@gmail.com wrote:

> Sun, Jun 04, 2023 at 12:23:32AM +0530, Shreeya Patel kirjoitti:
> > This patch series adds ADC support for RK3588 and updates
> > the DT bindings for the same.
> > 
> > To test ADC support on Rock 5B board, a voltage divider circuit
> > was created using the gpio pin 22 ( SARADC_IN4 ) and few more
> > tests were ran for testing the buffer and trigger support using
> > the iio_generic_buffer tool.  
> 
> Well done!
> 
> For patches 1-6
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> (with one nit-pick to be addressed)

Addressed the nit whilst applying and picked up 1-6,8.
Applied them to the togreg branch of iio.git, but initially I'll just
push that out as testing for 0-day to take a look and see what we missed.

As normal 7 should go via appropriate SoC tree


> 
> > Changes in v3
> >   - Add bitfield.h header file in patch 2.
> >   - Add a Reviewed-by tag in patch 2.
> >   - Do not remove clock enabling and disabling from the suspend and
> >     resume functions respectively in patch 3
> > 
> > Changes in v2
> >   - Add from address in patches 1 and 2.
> >   - Create separate patches for adding new device support and changes to
> >     the old device code.
> >   - Make use of FIELD_PREP in patch 2.
> >   - Move the enablement of clocks at it's original position in patch 3
> >   - Add Reviewed-by tag in patches 4 and 5.
> >   - Add an Acked-by tag in patch 8.
> > 
> > Shreeya Patel (8):
> >   iio: adc: rockchip_saradc: Add callback functions
> >   iio: adc: rockchip_saradc: Add support for RK3588
> >   iio: adc: rockchip_saradc: Make use of devm_clk_get_enabled
> >   iio: adc: rockchip_saradc: Use of_device_get_match_data
> >   iio: adc: rockchip_saradc: Match alignment with open parenthesis
> >   iio: adc: rockchip_saradc: Use dev_err_probe
> >   arm64: dts: rockchip: Add DT node for ADC support in RK3588
> >   dt-bindings: iio: adc: Add rockchip,rk3588-saradc string
> > 
> >  .../bindings/iio/adc/rockchip-saradc.yaml     |   1 +
> >  arch/arm64/boot/dts/rockchip/rk3588s.dtsi     |  12 +
> >  drivers/iio/adc/rockchip_saradc.c             | 246 +++++++++++-------
> >  3 files changed, 168 insertions(+), 91 deletions(-)
> > 
> > -- 
> > 2.30.2
> >   
>
Heiko Stübner June 6, 2023, 5:07 p.m. UTC | #3 
On Sun, 4 Jun 2023 00:23:32 +0530, Shreeya Patel wrote:
> This patch series adds ADC support for RK3588 and updates
> the DT bindings for the same.
> 
> To test ADC support on Rock 5B board, a voltage divider circuit
> was created using the gpio pin 22 ( SARADC_IN4 ) and few more
> tests were ran for testing the buffer and trigger support using
> the iio_generic_buffer tool.
> 
> [...]

Applied, thanks!

[7/8] arm64: dts: rockchip: Add DT node for ADC support in RK3588
      commit: ec084cbddbbe3a778ee06ccc0c59cee23b5cbaf4

I've moved the node to its correct position (by @address)
and also renamed the node to a more generic adc@...

Best regards,