From patchwork Sat Jun 3 14:52:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Demi Marie Obenour X-Patchwork-Id: 10260 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1700676vqr; Sat, 3 Jun 2023 07:54:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5fQWe7jh1sen0kziLoEM0gLe44ti8qRH/jotSZcQ5SVFzTwffAiYFHLajyd06tbDIFJdTr X-Received: by 2002:a05:6a00:21ca:b0:643:aa8d:8cd7 with SMTP id t10-20020a056a0021ca00b00643aa8d8cd7mr12771732pfj.32.1685804052063; Sat, 03 Jun 2023 07:54:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685804052; cv=none; d=google.com; s=arc-20160816; b=IOpDcur716AxRsWQR2Vzfpbb/3erbTjM09J2jgDu/E2EdHUOGxhCBitf/UGowJ1Llb f88f/DmNOEGMoma2AOWQ6IDg+/1aiYep92LposQKYjxE7LWWaCn/Notvf7Z+uewKtPHm DTqMcM7MIzs/JAUA/bOYcup7Z9OWfTfgkIDwrU2XB5lh5qtkqJfK4Mz6QZLlPkUa2kmP QorlBcQU6dd5dlwc9VHdLiXHW7v0wXFE/1kmh1wJQWAeN52hPUM0ejrp1nYO7iuKVCn1 r3+41/t2aZpa+IPm+4g3odR0RqGTXTagEm79ZdsLnGibqkwUbgl6w3ptWd+RQqojNysk Ivzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :feedback-id:dkim-signature:dkim-signature; bh=XTRiEXC0hJuFUbypDKl52aPAQLwWCJPaXPAmCQQTCu4=; b=BUA+0yOQ0RVXDP/u4O5OrCCu/Pl2A8q7wlw0Svz/grbVEuE3wzUNS3I5g60S/vCetP ErkQsN19lsjFmFeEnU5JagH+nuoSa7jCdakmN3CuBpj8gL13WnYgjlaKZCZheukyTbsH vNHU439QzNrw02VGoaQWw/DqRZ1bUUp8QiMR8WmkCMd0JR1sDyQyKi15v6o/6sewRomi Qx/lpYR1FXyKvgMGVLLyR+V88o8qPBxeWfaOWLcyGeRhtTkG3VAvZ94Cy57yI646YQUr MS6F6anHBVWSoh2rfAoQcHynOQep1F2Jk30WVuw+InnNtZGZCo5qgC2cNuutaad8WSdd A4Iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@invisiblethingslab.com header.s=fm1 header.b="lBydP/cc"; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=YMNMJlvr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i3-20020aa796e3000000b0064fbe0ad004si1454596pfq.90.2023.06.03.07.53.59; Sat, 03 Jun 2023 07:54:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@invisiblethingslab.com header.s=fm1 header.b="lBydP/cc"; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=YMNMJlvr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229823AbjFCOxM (ORCPT + 99 others); Sat, 3 Jun 2023 10:53:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229509AbjFCOxK (ORCPT ); Sat, 3 Jun 2023 10:53:10 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 897D0A2 for ; Sat, 3 Jun 2023 07:53:09 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 00C155C00CE; Sat, 3 Jun 2023 10:53:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 03 Jun 2023 10:53:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1685803988; x=1685890388; bh=XTRiEXC0hJ uFUbypDKl52aPAQLwWCJPaXPAmCQQTCu4=; b=lBydP/ccutXAtieqnl+EWmcf87 fR/wqnWzGPOEygQCrxEv1MVIIiuSSayoJeKj339a8hkECWQVfBpwhU2bRpNVQk2l DduJhuiI/cKOiQ4R3KHtIAI3TlmSDXP9lEBc2hHWuR4X0C6RDez53mCyEHFc0Tbd 6BsZSK0QXEdAawt6RLqsjh0n54D+VsnvKG7D1IF7Wb0goCY30D6C9V/HyVzse5Fz tv+XDf5KCm1FCpH0zFlK0OFoeiMQ41BJOC1HhUEf9GJoP3TgZahMxEFFLb8Jeh8m LceHQzKuSbbGFMffuheGqTw1TJkCPMlAseAj+BgierpCIx4mBNQ1hTzVJM3w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1685803988; x= 1685890388; bh=XTRiEXC0hJuFUbypDKl52aPAQLwWCJPaXPAmCQQTCu4=; b=Y MNMJlvr03psqYltvkbWVcQDz7aUp4h+68Tnin6gSkBDFE8qnaFo2uL/0b9EmC0rI rMiGeWYgfRJpkrvMXzwyhPEQbklO3mkeMLfyQbUzoj8pJ/CuJ9uf+/DdKQd7u6p8 LEImr53UDSSxB5+VH3DeGOfFMSzjVFdBPq2M0oG5WZawKQCSAbMeXN+Auhv1a1D8 h8axfWn4QkstEP3ck/6KrVPh2m7UMrgR7hwzu5LP7M3vkN4tY0MKSg2XupyP8/4b QuYXuVpfFL8bi/y1L26NM28UfmV2+84NuNUDmRhAywW8pea46BChWAOjlOcNX6gt DT1Cues+smgFk+AdKflEQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeelhedgkedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepjeffjefggfeugeduvedvjeekgfeh gffhhfffjeetkeelueefffetfffhtdduheetnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 3 Jun 2023 10:53:08 -0400 (EDT) From: Demi Marie Obenour To: Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com Cc: Demi Marie Obenour , linux-kernel@vger.kernel.org Subject: [PATCH v2 0/6] Several device-mapper fixes Date: Sat, 3 Jun 2023 10:52:38 -0400 Message-Id: <20230603145244.1538-1-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230601212456.1533-1-demi@invisiblethingslab.com> References: <20230601212456.1533-1-demi@invisiblethingslab.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767537572667729920?= X-GMAIL-MSGID: =?utf-8?q?1767693669667396827?= This series contains several miscellaneous fixes to input validation in device-mapper. The only potentially controversial commits should be the last two, which prevent creating devices named ".", "..", or "control". The other patches fix input validation problems that have existed since at least the beginning of git history. Changes since v1: - Fix silly mistake (using sizeof() on a pointer) caught by 0day bot. Demi Marie Obenour (6): device-mapper: Check that target specs are sufficiently aligned device-mapper: Avoid pointer arithmetic overflow device-mapper: structs and parameter strings must not overlap device-mapper: Avoid double-fetch of version device-mapper: Refuse to create device named "control" device-mapper: "." and ".." are not valid symlink names drivers/md/dm-ioctl.c | 91 ++++++++++++++++++++++++++++++++++--------- 1 file changed, 72 insertions(+), 19 deletions(-)