From patchwork Fri Jun 2 01:15:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Christopherson X-Patchwork-Id: 10198 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp724739vqr; Thu, 1 Jun 2023 18:26:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6WPIQKePgQEinAEB4HI3dlFDAUuNgynmbisfel9KLLlVzwTjrXo9gS+epRpiZn0KGJTl1Y X-Received: by 2002:aca:d10:0:b0:397:f93e:e160 with SMTP id 16-20020aca0d10000000b00397f93ee160mr854470oin.39.1685669185222; Thu, 01 Jun 2023 18:26:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685669185; cv=none; d=google.com; s=arc-20160816; b=lkSRtsUgi+YrKPLQtRS+s6XEBAkoJN1huEu7mj5Bc71m1R3OE4rJg24pJbnsupq21c oYzx8btKf+zXAUVWsbPzaB2iB5POx8N4rUnsPO9AVW3vPeKiD6e25/sutpg9HkkYr49L B3t+I7xQKYY0ZhwalrfoH0j+ZRYdZUgJkdaHL+xh3FxQhQPZCYPo3cqpEugFENMrjC20 rl1E5uDsIo/nZ3xMvfmNNZod42LhNvQYIk8fhhcMV0NgdBH/uy9xDJM6QA8l9g3v2rCe K7i0sUfjnR4p2YZW3jAMSNyx4lCRXIpkLOKi1TvQQShmpfurkVcdRa7knxMb8bigxcQt zxIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:mime-version:date :reply-to:dkim-signature; bh=0tlzbGXwY0mpJeijrUSkgUG6k3pOYpSjtTcL5wAkHcw=; b=ZTiLfuHpXs7WPgyNLpFpef7/Ny1KES8zu5qVbXrbySRjty1MZvjM0FUUtArEsnT4z1 LctkG8S9Ha+Ttfi762z9GHzfe6MdfVBvUKMw0KqUsT3anpOHqT9IEt+qLNwiMM3q5yWa IHDJufuNEWlxeUCnal/yGsKSe/Om2cX0yGGxsM/qbwAl+uZDGHMwdazFPTMKAabI1esp Z4QSpn8kpoTcNoWQVukkQlTVCzvWLJrRxm/ddJJ6szAvK1BUstYwD48n5v6vRmbS4Mlv B8+IBYhO1aUU2K2yBLu3H4Mnkpo9SGZ2tAi/YmziAh507QJ8y2T4RN+o8d8v9Z+gnGH9 PqHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=RFiNfGYR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r24-20020a63fc58000000b0051f179c48e7si97588pgk.866.2023.06.01.18.26.10; Thu, 01 Jun 2023 18:26:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=RFiNfGYR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232090AbjFBBP0 (ORCPT + 99 others); Thu, 1 Jun 2023 21:15:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233250AbjFBBPW (ORCPT ); Thu, 1 Jun 2023 21:15:22 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B15E9195 for ; Thu, 1 Jun 2023 18:15:21 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-ba8337ade1cso2064059276.2 for ; Thu, 01 Jun 2023 18:15:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685668521; x=1688260521; h=cc:to:from:subject:message-id:mime-version:date:reply-to:from:to:cc :subject:date:message-id:reply-to; bh=0tlzbGXwY0mpJeijrUSkgUG6k3pOYpSjtTcL5wAkHcw=; b=RFiNfGYRqxpzHS/rqpX2OkiuJOxtydzugc22q7Nm4RhSlapGiF5FGII5Q26nABlhrx rbNh+IA7n7rZjl1nwMmh7QCEKe9sWmX+t8dpIK3F9QFNG9e+zu5KBmr72+hRNDKgwdlz a9LvCUFcC/FXIkPYxcfBkPLSE46KR/Q3NtVqc1tFWZGGd4AUvu6ogQbOqHlju3DpG7MM Q90DSCchF7KgvTcaNOB49whFZNtkgeZYLhcaUWjwyoHha+DUlSDuMZ7HQ5vCEJYBDEaW tGa66bh6kSZpfN91b62iNdfNvgPbTwbJUl1LUgp72pWoNzcj5x3SqPLRu4bwbJoikNB5 IjUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685668521; x=1688260521; h=cc:to:from:subject:message-id:mime-version:date:reply-to :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0tlzbGXwY0mpJeijrUSkgUG6k3pOYpSjtTcL5wAkHcw=; b=dNFT9PkcUoNRUXvc0QWf9j1aQIdCkiJaHIxyo6z9S4Pr4jDzBWeVgInUfWMPbbWFE/ Y1GtckPE99aubicWbJ8YQUUiCfPGCTJVpX/+Ivd+8TxwU3cj1CQeI3T9UImkEtfiMs2K KH4WFSXfFJTU0HWnGCEMVJLQhjBt5Hy1fYmGk9PFsMSnq+3OHfvrlbO/oDQiSUwjic+R Eexg4k+adSjT2amef9QdVyZRFFyXWiGZIaWNZAHvvyvaIEma/Bga0HqWfdcc6Wk8NCMO nNOT2mGcIFIx79l+llZ1uvzcAQVBJRad230PMQBQLWutiS+USSqHa6FqBlYXaS7Lmpp/ muMQ== X-Gm-Message-State: AC+VfDyLxXgmD4CIwq4uUUUjmXJzo8Z5fEejQLCR8U/EeeDQ+EzgCrvl mHmGkvsxp9icOM01SRVDowFJwuG2eoQ= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:102f:b0:bb1:3606:6a29 with SMTP id x15-20020a056902102f00b00bb136066a29mr755797ybt.3.1685668521018; Thu, 01 Jun 2023 18:15:21 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 1 Jun 2023 18:15:15 -0700 Mime-Version: 1.0 X-Mailer: git-send-email 2.41.0.rc2.161.g9c6817b8e7-goog Message-ID: <20230602011518.787006-1-seanjc@google.com> Subject: [PATCH 0/3] KVM: x86: Use "standard" mmu_notifier hook for APIC page From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Gunthorpe , Alistair Popple , Robin Murphy X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767552251672256693?= X-GMAIL-MSGID: =?utf-8?q?1767552251672256693?= Convert VMX's handling of mmu_notifier invalidations of the APIC-access page from invalidate_range() to KVM's standard invalidate_range_{start,end}(). KVM (ab)uses invalidate_range() to fudge around not stalling vCPUs until relevant in-flight invalidations complete. Abusing invalidate_range() works, but it requires one-off code in KVM, sets a bad precedent in KVM, and is blocking improvements to mmu_notifier's definition of invalidate_range() due to KVM's usage diverging wildly from the original intent of notifying IOMMUs of changes to shared page tables. Clean up the mess by hooking x86's implementation of kvm_unmap_gfn_range() and stalling vCPUs by re-requesting KVM_REQ_APIC_PAGE_RELOAD until the invalidation completes. Sean Christopherson (3): KVM: VMX: Retry APIC-access page reload if invalidation is in-progress KVM: x86: Use standard mmu_notifier invalidate hooks for APIC access page KVM: x86/mmu: Trigger APIC-access page reload iff vendor code cares arch/x86/kvm/mmu/mmu.c | 4 ++++ arch/x86/kvm/vmx/vmx.c | 50 ++++++++++++++++++++++++++++++++++++---- arch/x86/kvm/x86.c | 14 ----------- include/linux/kvm_host.h | 3 --- virt/kvm/kvm_main.c | 18 --------------- 5 files changed, 49 insertions(+), 40 deletions(-) base-commit: 39428f6ea9eace95011681628717062ff7f5eb5f Reviewed-by: Paolo Bonzini