From patchwork Wed Nov 29 18:00:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ira Weiny X-Patchwork-Id: 17292 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a5a7:0:b0:403:3b70:6f57 with SMTP id d7csp517156vqn; Wed, 29 Nov 2023 10:02:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IERANObBbAgnTZl9jb6ZjxhDuz9p5ipY0TriuDo6/cKslAce9qnTKASX7ZUpM2IveCznI2b X-Received: by 2002:a17:90a:ce97:b0:285:9f2d:3a5d with SMTP id g23-20020a17090ace9700b002859f2d3a5dmr15935274pju.31.1701280936333; Wed, 29 Nov 2023 10:02:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701280936; cv=none; d=google.com; s=arc-20160816; b=pstSGpNi7qTiIOG4kNJiz9/SgfJbgVeLxLFdhAoMT8yAD7cZkvEdKIHNDClkVefSn+ 2ILE0Rq9MJUDXe/rS6kebKM2QaJQufEfYWn/8COqg5953I6sW4OpwHO2CJiKjfF3k49O ir9mKjEMwlulBQj5EMSKw59jhyG3YPbOQn95D2RenFkPDQLh6W68vmfuztvXxnVqo7pI VjaNa4mkllbkwKsJl3tmB4tzK/ArIaIs8Q0iEN8+/v4hVG+LmPfgN7etTEyTg03UBnVJ dK87CQZ9WdW+3EXBRS7tqL4wqgRwRyCvrvLglohujVSsxxPnwqwI+rgudfstrn/47i4h esKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:content-transfer-encoding:mime-version :message-id:date:subject:from:dkim-signature; bh=7Xr23Pa2zQZ0QX6PM/oHgc1Ma79+lKX4mcXRM7Kuknw=; fh=ooyHxRI2wofYX0BZXsqrgCR3CEVFl26oPigvpILVPuw=; b=lpYu+JT78b5Y+XF5ALazgxo8YP1EsrOLR52+EmkhrpebeLN387I+6A7OUoanxO0oU2 wfXJmAnCj3GR5glkwngNMsDTcPTVHfU+wzTw31gGaozOSLom70XtDzDzTfblnNXMAi/Y O6Hiz6U4g6n37X1Bb5cgygZoHo74SDnukG930e7/riXuByjdcxN5yIIgIOL1FeNFI/Rl zk041sNdNZeiQmeS/05B23yfAtajBctka63Cg1GszGry4VaCN8v1W2AuHOs5LENwXZdq UuNzOm1bOU6EErt3kPBzlzzLqqRDBadBaoYoVlZtFSa6V48yMJReXcV57QIg3vl0Kwgv 05gQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ivUyYVOK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id s11-20020a17090aad8b00b002859a1a8995si1801726pjq.17.2023.11.29.10.02.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 10:02:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ivUyYVOK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 2E63C807D246; Wed, 29 Nov 2023 10:00:52 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230303AbjK2SAn (ORCPT + 99 others); Wed, 29 Nov 2023 13:00:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbjK2SAm (ORCPT ); Wed, 29 Nov 2023 13:00:42 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8ECA90; Wed, 29 Nov 2023 10:00:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701280848; x=1732816848; h=from:subject:date:message-id:mime-version: content-transfer-encoding:to:cc; bh=o8Db8liVmIHRdeM+5hCUQllrxeYOIsuUtygP4rZCS0k=; b=ivUyYVOK0SzKZvBprryD3V8+MzBT36tLoVuKOCMoZiAkXFEDAqogDUcE 5ZM/adanMA0z1uYOmwQMuyaAQGJ55AjU0/5fXOR2fnnn6qJM6fNo3LoqQ 4cIhez/tNh53rKXcicsSIBkvwpb4gaHAmouekHcNN7aiY/AUZyZ2qOojM pdoqgzktY+xD09G2kazIxa6F5cEBCna3hRwuE4UovvwCkJc4TF2NRBFx3 Q+tfWLgSrror1poPCuGXg6lnfrBYbwuCYXeQfv/UDtcSg+veCUvu0mkQ7 Zj0GKKPhSuCHxGFfJl6PiTm6NLV7ZHS8xDradr3mKALyVgIWYT4K5n1yC g==; X-IronPort-AV: E=McAfee;i="6600,9927,10909"; a="457524454" X-IronPort-AV: E=Sophos;i="6.04,237,1695711600"; d="scan'208";a="457524454" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2023 10:00:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10909"; a="835096088" X-IronPort-AV: E=Sophos;i="6.04,237,1695711600"; d="scan'208";a="835096088" Received: from iweiny-desk3.amr.corp.intel.com (HELO localhost) ([10.212.127.168]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2023 10:00:47 -0800 From: Ira Weiny Subject: [PATCH 0/6] efi/cxl-cper: Report CPER CXL component events through trace events Date: Wed, 29 Nov 2023 10:00:40 -0800 Message-Id: <20230601-cxl-cper-v1-0-d19f1ac18ab6@intel.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAEh8Z2UC/3XNwQ7CIAwG4FcxnMVQQDY8+R7GA3TFkehmYFk0y 95dtpMx7vi3/fpPLFOKlNlpN7FEY8yx70qA/Y5h67ob8diUzKSQShgBHF93jk9KXJoQsFYWDRp Wzr3LxH1yHbYLeLg8UFoWz0QhvtaOy7XkNuahT++1coRl+uf7CFxwa73TKtShqsQ5dgPdD9g/2 PJklFtQFqhANxaVcV7IX6i2oCpQQG0bA6GyR/ML9RbUBerKeysggDrSN5zn+QPOq80lZAEAAA= = To: Dan Williams , Jonathan Cameron , Smita Koralahalli , Shiju Jose Cc: Yazen Ghannam , Davidlohr Bueso , Dave Jiang , Alison Schofield , Vishal Verma , Ard Biesheuvel , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, Ira Weiny X-Mailer: b4 0.13-dev-0f7f0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1701280847; l=2858; i=ira.weiny@intel.com; s=20221222; h=from:subject:message-id; bh=o8Db8liVmIHRdeM+5hCUQllrxeYOIsuUtygP4rZCS0k=; b=nVI1Spi5q3bjD7WM7Z73eDy8dLzwKcTFPYLnS378pMwWKsaf3ZJvQ4cJ5b4lgpmWktsObnxY2 5c4Z4KbBtuLDlVz2L1qr7RuXYf8Ndlwh5TzpNIAm4pYDknzMxhFh5V+ X-Developer-Key: i=ira.weiny@intel.com; a=ed25519; pk=brwqReAJklzu/xZ9FpSsMPSQ/qkSalbg6scP3w809Ec= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 29 Nov 2023 10:00:52 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783922358733826913 X-GMAIL-MSGID: 1783922358733826913 Series status/background ======================== Smita has been a great help with this series. This includes testing the last RFC version enough that I feel confident to make this a V1 with the change suggested.[1] [1] https://lore.kernel.org/all/7ec6d2af-c860-9b05-7eaf-c82f50f8e66e@amd.com/ Cover letter ============ CXL Component Events, as defined by EFI 2.10 Section N.2.14, wrap a mostly CXL event payload in an EFI Common Platform Error Record (CPER) record. If a device is configured for firmware first CXL event records are not sent directly to the host. The CXL sub-system uniquely has DPA to HPA translation information. It also already has event format tracing. Restructure the code to make sharing the data between CPER/event logs most efficient. Then send the CXL CPER records to the CXL sub-system for processing. With event logs the events interrupt the driver directly. In the EFI case events are wrapped with device information which needs to be matched with memdev devices. A number of alternatives were considered to match the memdev with the CPER record. The most robust was to find the PCI device via Bus, Device, Function and match it to the memdev driver data. CPER records are identified with GUID's while CXL event logs contain UUID's. The UUID is reported for all events. While the UUID is redundant for the known events the UUID's are already used by rasdaemon. To keep compatibility UUIDs are injected for CPER records based on the record type. Signed-off-by: Ira Weiny --- Changes from RFC: - iweiny: remove RFC - Smita: Use pragma pack for the entire cper structure - Link to v4: https://lore.kernel.org/r/20230601-cxl-cper-v4-0-47bb901f135e@intel.com --- Ira Weiny (6): cxl/trace: Pass uuid explicitly to event traces cxl/events: Promote CXL event structures to a core header cxl/events: Separate UUID from event structures cxl/events: Create a CXL event union firmware/efi: Process CXL Component Events cxl/memdev: Register for and process CPER events drivers/cxl/core/mbox.c | 65 ++++++++++------ drivers/cxl/core/trace.h | 34 ++++---- drivers/cxl/cxlmem.h | 96 ++--------------------- drivers/cxl/pci.c | 58 +++++++++++++- drivers/firmware/efi/cper.c | 15 ++++ drivers/firmware/efi/cper_cxl.c | 40 ++++++++++ drivers/firmware/efi/cper_cxl.h | 29 +++++++ include/linux/cxl-event.h | 164 +++++++++++++++++++++++++++++++++++++++ tools/testing/cxl/test/mem.c | 166 +++++++++++++++++++++++----------------- 9 files changed, 465 insertions(+), 202 deletions(-) --- base-commit: 7475e51b87969e01a6812eac713a1c8310372e8a change-id: 20230601-cxl-cper-26ffc839c6c6 Best regards,