From patchwork Wed May 31 11:25:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Serge Semin X-Patchwork-Id: 10100 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2805252vqr; Wed, 31 May 2023 04:29:58 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7p2Q4Yxo8nAG7s8bHjIfDpvn/m4ga/uY3dRi8vVbbnRpq+5+vixibbs0WiAUHE1FWPBUIC X-Received: by 2002:a17:902:d50e:b0:1b0:10a1:3da9 with SMTP id b14-20020a170902d50e00b001b010a13da9mr5718749plg.32.1685532598097; Wed, 31 May 2023 04:29:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685532598; cv=none; d=google.com; s=arc-20160816; b=Ys1YvBQuLiYLjgVtsezyct+EtgHUPO1X6yyC4cgifv1fbb5Iu0gBr7U+gmHq4TA+Sp OTbfa0y5iGUQP1kcjYIcP3m94tTzXPILxasOSgDTG4NnIiNrd0b4V6AAiwu52bscYf5I //mPS+O9CLESZ4bEl7Pt8P++hw1boDx7+invnbt8jAjXTkjkjTbv5+MLOYFqz2ZJ2hgI OvX4h2s0V1u/JMqQsmYztpoVpiKSDCDt25XEx8rGUNyJZELP02B0XSGEAqlr++5B0P1C 76RYr3yX86T0ZlbctOksChAU2Nq9yKA76XJsTJJPs9EyIXvA2zl10eKelpdunNNfGdPn icZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Hl82/s5xZmhkiS8NV0lDG/1nVA6g7+Pvsvq3KsV4rSo=; b=B2uBQEpRpjkrdswznwbaEtU+LZB5vi+N9pno6HtRDyhAAwPZZSPF9n/zSgJoDXNMeY Wcl7/s4fuJrdR/7myIdT7thV4VrMTGt+Eet8MBaSmLiV3YXLy7GpicXWuuP36h8tXVzE iGICsVhhpYcH7xR71Z+fE+fmFrDSu8KOkjFKjilF4pBakYJVPG5AIme3/kjCPjTXnXiI bhAKR9Lia2yGuWq70szFf/fhc85ZLdoOB7F497x2/c7CS9aXZbdnn9R25K3qf7dlp17A Xr+4MvIWiOfvPQKcAzbU3lQ7NB13DVWSoZY/QqVY0meLwkuwyPc86jHmrBpW/kzr4aiy +s8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baikalelectronics.ru header.s=post header.b=PJSZnfn3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=baikalelectronics.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x11-20020a170902ea8b00b001aad6ad4ebcsi731705plb.150.2023.05.31.04.29.46; Wed, 31 May 2023 04:29:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baikalelectronics.ru header.s=post header.b=PJSZnfn3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=baikalelectronics.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235591AbjEaL0T (ORCPT + 99 others); Wed, 31 May 2023 07:26:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234589AbjEaL0L (ORCPT ); Wed, 31 May 2023 07:26:11 -0400 Received: from post.baikalelectronics.com (post.baikalelectronics.com [213.79.110.86]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4BCBDE8; Wed, 31 May 2023 04:26:07 -0700 (PDT) Received: from post.baikalelectronics.com (localhost.localdomain [127.0.0.1]) by post.baikalelectronics.com (Proxmox) with ESMTP id 2B5C2E0DE7; Wed, 31 May 2023 14:26:06 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= baikalelectronics.ru; h=cc:cc:content-transfer-encoding :content-type:content-type:date:from:from:message-id :mime-version:reply-to:subject:subject:to:to; s=post; bh=Hl82/s5 xZmhkiS8NV0lDG/1nVA6g7+Pvsvq3KsV4rSo=; b=PJSZnfn3TUd/avJIKAlkG+F KbfnYxFrJ4z7YIVj8VLtubEvjTMbm4Q7qqX2bLxouqj2eQ0KFRywbpE6PuBMLvKk hvFA0mZE7buWB/AdZKu1x4j2EP7nkqQTOKU0C2lFXhObj/8x/KDLSB3QBZdG29LT ze2fFolGUlYzD2TueiG8= Received: from mail.baikal.int (mail.baikal.int [192.168.51.25]) by post.baikalelectronics.com (Proxmox) with ESMTP id 06498E0DE3; Wed, 31 May 2023 14:26:06 +0300 (MSK) Received: from localhost (10.8.30.6) by mail (192.168.51.25) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 31 May 2023 14:26:05 +0300 From: Serge Semin To: Bjorn Helgaas , Lorenzo Pieralisi , Jingoo Han , Gustavo Pimentel , Manivannan Sadhasivam , Yoshihiro Shimoda , Rob Herring CC: Serge Semin , Serge Semin , Alexey Malahov , Pavel Parkhomenko , , Subject: [PATCH RESEND v6 00/11] PCI: dwc: Relatively simple fixes and cleanups Date: Wed, 31 May 2023 14:25:51 +0300 Message-ID: <20230531112602.7222-1-Sergey.Semin@baikalelectronics.ru> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-Originating-IP: [10.8.30.6] X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767409029520148183?= X-GMAIL-MSGID: =?utf-8?q?1767409029520148183?= It turns out the recent DW PCIe-related patchset was merged in with several relatively trivial issues left unsettled (noted by Bjorn and Manivannan). All of these lefovers have been fixed in this patchset. Namely the series starts with two bug-fixes. The first one concerns the improper link-mode initialization in case if the CDM-check is enabled. The second unfortunate mistake I made in the IP-core version type helper. In particular instead of testing the IP-core version type the macro function referred to the just IP-core version which obviously wasn't what I intended. Afterwards two @Mani-noted fixes follow. Firstly the dma-ranges related warning message is fixed to start with "DMA-ranges" word instead of "Dma-ranges". Secondly the Baikal-T1 PCIe Host driver is converted to perform the asynchronous probe type which saved us of about 15% of bootup time if no any PCIe peripheral device attached to the port. Then the patchset contains the Baikal-T1 PCIe driver fix. The corresponding patch removes the false error message printed during the controller probe procedure. I accidentally added the unconditional dev_err_probe() method invocation. It was obviously wrong. Then two trivial cleanups are introduced. The first one concerns the duplicated fast-link-mode flag unsetting. The second one implies dropping a redundant empty line from the dw_pcie_link_set_max_speed() function. The series continues with a patch inspired by the last @Bjorn note regarding the generic resources request interface. As @Bjorn correctly said it would be nice to have the new interface used wider in the DW PCIe subsystem. Aside with the Baikal-T1 PCIe Host driver the Toshiba Visconti PCIe driver can be easily converted to using the generic clock names. That's what is done in the noted patch. The patchset is closed with a series of MAINTAINERS-list related patches. Firstly after getting the DW PCIe RP/EP DT-schemas refactored I forgot to update the MAINTAINER-list with the new files added in the framework of that procedure. All the snps,dw-pcie* schemas shall be maintained by the DW PCIe core driver maintainers. Secondly seeing how long it took for my patchsets to review and not having any comments from the original driver maintainers I'd suggest to add myself as the reviewer of the DW PCIe driver. Thus hopefully the new updates review process will be performed with much less latencies. For the same reason @Manivannan is added to the maintainers list of the DW PCIe/eDMA drivers as he already agreed to be in. Link: https://lore.kernel.org/linux-pci/20230217093956.27126-1-Sergey.Semin@baikalelectronics.ru/ Changelog v2: - Rebase onto the kernel 6.3-rc2. Link: https://lore.kernel.org/linux-pci/20230313200816.30105-1-Sergey.Semin@baikalelectronics.ru/ Changelog v3: - Drop the patch: [PATCH v2 01/11] PCI: dwc: Fix port link CSR improper init if CDM check enabled and rebase onto the already submitted by @Yoshihiro fix: commit cdce67099117 ("PCI: dwc: Fix PORT_LINK_CONTROL update when CDM check enabled") - Just resend. Link: https://lore.kernel.org/linux-pci/20230411033928.30397-1-Sergey.Semin@baikalelectronics.ru/ Changelog v4: - Demote @Gustavo to being DW PCIe/eDMA drivers reviewer: [PATCH v4 9/14] MAINTAINERS: Demote Gustavo Pimentel to DW PCIe core reviewer [PATCH v4 12/14] MAINTAINERS: Demote Gustavo Pimentel to DW EDMA driver reviewer - Add Manivannan to the DW PCIe/eDMA drivers maintainers list: [PATCH v4 10/14] MAINTAINERS: Add Manivannan to DW PCIe core maintainers list [PATCH v4 13/14] MAINTAINERS: Add Manivannan to DW eDMA driver maintainers list Link: https://lore.kernel.org/linux-pci/20230414021832.13167-1-Sergey.Semin@baikalelectronics.ru/ Changelog v5: - Rebase onto the kernel 6.4-rc1. - Just resend. Link: https://lore.kernel.org/linux-pci/20230511190902.28896-1-Sergey.Semin@baikalelectronics.ru/ Changelog v6: - Remove Vinod and DMA-engine mailing-list from Cc-list since the DMA-related patches have already been merged in. - Drop the next patches: [PATCH RESEND v5 12/14] MAINTAINERS: Demote Gustavo Pimentel to DW EDMA driver reviewer [PATCH RESEND v5 13/14] MAINTAINERS: Add Manivannan to DW eDMA driver maintainers list [PATCH RESEND v5 14/14] MAINTAINERS: Add myself as the DW eDMA driver reviewer since they are in the dmeengine next git-branch already. - Just resend. Signed-off-by: Serge Semin Cc: Alexey Malahov Cc: Pavel Parkhomenko Cc: linux-pci@vger.kernel.org Cc: linux-kernel@vger.kernel.org Serge Semin (11): PCI: dwc: Fix erroneous version type test helper PCI: dwc: Fix inbound iATU entries out-of-bounds warning message PCI: bt1: Enable async probe type PCI: bt1: Fix printing false error message PCI: dwc: Drop duplicated fast-link-mode flag unsetting PCI: dwc: Drop empty line from dw_pcie_link_set_max_speed() PCI: visconti: Convert to using generic resources getter MAINTAINERS: Add all generic DW PCIe RP/EP DT-schemas MAINTAINERS: Demote Gustavo Pimentel to DW PCIe core reviewer MAINTAINERS: Add Manivannan to DW PCIe core maintainers list MAINTAINERS: Add myself as the DW PCIe core reviewer MAINTAINERS | 7 ++-- drivers/pci/controller/dwc/pcie-bt1.c | 5 ++- .../pci/controller/dwc/pcie-designware-host.c | 2 +- drivers/pci/controller/dwc/pcie-designware.c | 2 - drivers/pci/controller/dwc/pcie-designware.h | 7 +++- drivers/pci/controller/dwc/pcie-visconti.c | 37 +++++++++---------- 6 files changed, 31 insertions(+), 29 deletions(-)