mbox series

[RESEND,0/2] Bluetooth: fix bdaddr quirks

Message ID 20230531090424.3187-1-johan+linaro@kernel.org
Headers
Series Bluetooth: fix bdaddr quirks |

Message

Johan Hovold May 31, 2023, 9:04 a.m. UTC 
  These patches fix a couple of issues with the two bdaddr quirks:

The first one allows HCI_QUIRK_INVALID_BDADDR to be used with
HCI_QUIRK_NON_PERSISTENT_SETUP.

The second patch restores the original semantics of the
HCI_QUIRK_USE_BDADDR_PROPERTY so that the controller is marked as
unconfigured when no device address is specified in the devicetree (as
the quirk is documented to work).

This specifically makes sure that Qualcomm HCI controllers such as
wcn6855 found on the Lenovo X13s are marked as unconfigured until user
space has provided a valid address.

Long term, the HCI_QUIRK_USE_BDADDR_PROPERTY should probably be dropped
in favour of HCI_QUIRK_INVALID_BDADDR and always checking the devicetree
property.

Johan


Johan Hovold (2):
  Bluetooth: fix invalid-bdaddr quirk for non-persistent setup
  Bluetooth: fix use-bdaddr-property quirk

 net/bluetooth/hci_sync.c | 30 +++++++++++-------------------
 1 file changed, 11 insertions(+), 19 deletions(-)

Comments

patchwork-bot+bluetooth@kernel.org May 31, 2023, 7 p.m. UTC | #1 
Hello:

This series was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 31 May 2023 11:04:22 +0200 you wrote:
> These patches fix a couple of issues with the two bdaddr quirks:
> 
> The first one allows HCI_QUIRK_INVALID_BDADDR to be used with
> HCI_QUIRK_NON_PERSISTENT_SETUP.
> 
> The second patch restores the original semantics of the
> HCI_QUIRK_USE_BDADDR_PROPERTY so that the controller is marked as
> unconfigured when no device address is specified in the devicetree (as
> the quirk is documented to work).
> 
> [...]

Here is the summary with links:
  - [RESEND,1/2] Bluetooth: fix invalid-bdaddr quirk for non-persistent setup
    https://git.kernel.org/bluetooth/bluetooth-next/c/92776a7e761e
  - [RESEND,2/2] Bluetooth: fix use-bdaddr-property quirk
    https://git.kernel.org/bluetooth/bluetooth-next/c/6ac517d8cf8b

You are awesome, thank you!