From patchwork Wed May 31 08:57:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 10087 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2740127vqr; Wed, 31 May 2023 02:18:05 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4EDnQXINS2MjWFzyI23SPcZiJyNt2jQsVANyd8Ld4DxaLsW+GsakV2pOFVMV4F2obJSulY X-Received: by 2002:a17:90a:e2d7:b0:24b:52cb:9a31 with SMTP id fr23-20020a17090ae2d700b0024b52cb9a31mr14291590pjb.22.1685524684666; Wed, 31 May 2023 02:18:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685524684; cv=none; d=google.com; s=arc-20160816; b=jPvb7srfau2eY+AM62PhRa2VIQ3xyjNRud3k3xbAvWu74t81t+M1hr9CyJCR1uBOZ4 dZCf2FRzCgnTOVOjGGMkneAuRs5rllFy6XO45arN66wnD1JUpd3HAVFWXcz9sWuWBa51 UYyWUYfCDT5jJaMXFgISdg5QM1iayoqC6RrFQ/tI8LT9i0nvITQl7+P6XKP7NH890q+X FHdTR/N+B2UaFycwpP0jjYpLSO+cSQ+9lw3eddile9RbR9s2hUiYAhaKUAD7W3ej+cZN X5q1kGWF81EEDbNl4BpIM/k052IcxlXchvRyMvH/Y+H/p6lSHXLV6xygtVet80f2uVuP 2a9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=MnHjBEY4Xs8+ykMceLAssT3vEsy/0HdJiPko3dLmGnc=; b=K1W3i1dv8G/1KwIwaqsFDZ7Z3WGaCK/lz9zbPyVJ1TZbo72OBy+NCOcXsiUBfTZ+WL ESfl7STFfRshFyrB1fQgmQRQIpM9UTfvRv5Rerdl2hDoM6lVTDIOASa6r235iuQOXP9h tZDLfqZ4n1yriXfhQzZTm7jRTyO5sHQi7ZXNJ1c6CiE3b+lYrRVlEdTZxrspXpgObMsK dJDQ3l0YXoRphqKMAuOIkaG6kP86+1tS9t8xCW7fvg2MNd3CpAMEs09IZcWgqZ5ntgiU imUztaM11RVIqZPLhjMjJt9g4f7i8BXztN0jhBFX81EtawQl5cuQwGBEjNo5GwYH0/fl cSHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EdgHBh4f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b186-20020a6334c3000000b0053087bce16esi615706pga.830.2023.05.31.02.17.52; Wed, 31 May 2023 02:18:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EdgHBh4f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235255AbjEaI6t (ORCPT + 99 others); Wed, 31 May 2023 04:58:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234644AbjEaI6l (ORCPT ); Wed, 31 May 2023 04:58:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76D64121; Wed, 31 May 2023 01:58:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C1F6B634A5; Wed, 31 May 2023 08:58:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21EFCC4339C; Wed, 31 May 2023 08:58:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685523518; bh=mJSo8BBhwI/dxw8GdROOGb5gjgq5W1wrGSLzQKQwoBM=; h=From:To:Cc:Subject:Date:From; b=EdgHBh4fKoarUjaCHDjrTETCm9eZRtZK+xB4AF1Cvyzt8RfhXhvfpaI39jYisNGel W+1HCggsHBWceZ+Wbd/KdUfbPmF6jywdVc49MKy+6LtxnZYzank29gYJh8Yjnm72HR vnIvAFUIM51knHrRGnCdp/UdStJKvbSIsem/YbdfN2tFUZ2H11UB1OpMz7eZNo8dU7 t/FDcSmg6o4Ji/IcGysS32iTV+6O25M7sJpMFOVmtFXdcdYyhqDdw5I2pPamrtIA+U qLIm1/9xqFneZmU5u5Ys37xbGukQj5AEcSQ68iZJHxMq5X3aCH8zmJVt/0ceSN1WYv vtPKAv85S5MSA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1q4HfE-0000jj-Ss; Wed, 31 May 2023 10:58:41 +0200 From: Johan Hovold To: Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Johan Hovold Subject: [PATCH RESEND 0/2] Bluetooth: fix debugfs registration Date: Wed, 31 May 2023 10:57:57 +0200 Message-Id: <20230531085759.2803-1-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767400731399505716?= X-GMAIL-MSGID: =?utf-8?q?1767400731399505716?= The HCI controller debugfs interface is created during setup or when a controller is configured, but there is nothing preventing a controller from being configured multiple times (e.g. by setting the device address), which results in a host of errors in the logs: debugfs: File 'features' in directory 'hci0' already present! debugfs: File 'manufacturer' in directory 'hci0' already present! debugfs: File 'hci_version' in directory 'hci0' already present! ... debugfs: File 'quirk_simultaneous_discovery' in directory 'hci0' already present! The Qualcomm driver suffers from a related problem for controllers with non-persistent setup. Johan Johan Hovold (2): Bluetooth: fix debugfs registration Bluetooth: hci_qca: fix debugfs registration drivers/bluetooth/hci_qca.c | 6 +++++- include/net/bluetooth/hci.h | 1 + net/bluetooth/hci_sync.c | 3 +++ 3 files changed, 9 insertions(+), 1 deletion(-)