mbox series

[RESEND,0/2] Bluetooth: fix debugfs registration

Message ID 20230531085759.2803-1-johan+linaro@kernel.org
Headers
Series Bluetooth: fix debugfs registration |

Message

Johan Hovold May 31, 2023, 8:57 a.m. UTC 
  The HCI controller debugfs interface is created during setup or when a
controller is configured, but there is nothing preventing a controller
from being configured multiple times (e.g. by setting the device
address), which results in a host of errors in the logs:

	debugfs: File 'features' in directory 'hci0' already present!
	debugfs: File 'manufacturer' in directory 'hci0' already present!
	debugfs: File 'hci_version' in directory 'hci0' already present!
	...
	debugfs: File 'quirk_simultaneous_discovery' in directory 'hci0' already present!

The Qualcomm driver suffers from a related problem for controllers with
non-persistent setup.

Johan


Johan Hovold (2):
  Bluetooth: fix debugfs registration
  Bluetooth: hci_qca: fix debugfs registration

 drivers/bluetooth/hci_qca.c | 6 +++++-
 include/net/bluetooth/hci.h | 1 +
 net/bluetooth/hci_sync.c    | 3 +++
 3 files changed, 9 insertions(+), 1 deletion(-)

Comments

patchwork-bot+bluetooth@kernel.org May 31, 2023, 7 p.m. UTC | #1 
Hello:

This series was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 31 May 2023 10:57:57 +0200 you wrote:
> The HCI controller debugfs interface is created during setup or when a
> controller is configured, but there is nothing preventing a controller
> from being configured multiple times (e.g. by setting the device
> address), which results in a host of errors in the logs:
> 
> 	debugfs: File 'features' in directory 'hci0' already present!
> 	debugfs: File 'manufacturer' in directory 'hci0' already present!
> 	debugfs: File 'hci_version' in directory 'hci0' already present!
> 	...
> 	debugfs: File 'quirk_simultaneous_discovery' in directory 'hci0' already present!
> 
> [...]

Here is the summary with links:
  - [RESEND,1/2] Bluetooth: fix debugfs registration
    https://git.kernel.org/bluetooth/bluetooth-next/c/3e972279b782
  - [RESEND,2/2] Bluetooth: hci_qca: fix debugfs registration
    https://git.kernel.org/bluetooth/bluetooth-next/c/22307d477e3f

You are awesome, thank you!