mbox series

[v3,0/6] MMCC MSM8998 fixes

Message ID 20230531-topic-8998_mmssclk-v3-0-ba1b1fd9ee75@linaro.org
Headers
Series MMCC MSM8998 fixes |

Message

Konrad Dybcio Aug. 9, 2023, 7:20 p.m. UTC 
  8998 has a couple of issues related to its clock controllers. This series
attemps to fix some of them.

The DT patch should go in first for bisectability, otherwise
clk/pd_ignore_unused will need to be used, as the SMMU GDSC is no longer
considered always-on.

This series results in less "clk stuck at 'on/off'" messages and should
marginally reduce power consumption.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
Changes in v3:
- Make the commit message more meaningful in patch 6 (krzk)
- Pick up tags
- Link to v2: https://lore.kernel.org/r/20230531-topic-8998_mmssclk-v2-0-34273e275c51@linaro.org

Changes in v2:
- Update bindings
- Separate out the dt patch into two
- Pick up tags
- Link to v1: https://lore.kernel.org/r/20230531-topic-8998_mmssclk-v1-0-2b5a8fc90991@linaro.org

---
Konrad Dybcio (6):
      arm64: dts: qcom: msm8998: Drop bus clock reference from MMSS SMMU
      arm64: dts: qcom: msm8998: Add missing power domain to MMSS SMMU
      clk: qcom: gcc-msm8998: Don't check halt bit on some branch clks
      clk: qcom: mmcc-msm8998: Don't check halt bit on some branch clks
      clk: qcom: mmcc-msm8998: Fix the SMMU GDSC
      dt-bindings: arm-smmu: Fix MSM8998 clocks description

 .../devicetree/bindings/iommu/arm,smmu.yaml        | 41 ++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/msm8998.dtsi              |  8 +++--
 drivers/clk/qcom/gcc-msm8998.c                     |  6 ++--
 drivers/clk/qcom/mmcc-msm8998.c                    |  7 +++-
 4 files changed, 55 insertions(+), 7 deletions(-)
---
base-commit: 21ef7b1e17d039053edaeaf41142423810572741
change-id: 20230531-topic-8998_mmssclk-fd4b2fb7f8c1

Best regards,

Comments

Will Deacon Aug. 11, 2023, 11:44 a.m. UTC | #1 
On Wed, 09 Aug 2023 21:20:23 +0200, Konrad Dybcio wrote:
> 8998 has a couple of issues related to its clock controllers. This series
> attemps to fix some of them.
> 
> The DT patch should go in first for bisectability, otherwise
> clk/pd_ignore_unused will need to be used, as the SMMU GDSC is no longer
> considered always-on.
> 
> [...]

Applied bindings patch to will (for-joerg/arm-smmu/bindings), thanks!

[6/6] dt-bindings: arm-smmu: Fix MSM8998 clocks description
      https://git.kernel.org/will/c/b606e2e8eded

Cheers,
Bjorn Andersson Aug. 14, 2023, 3:27 a.m. UTC | #2 
On Wed, 09 Aug 2023 21:20:23 +0200, Konrad Dybcio wrote:
> 8998 has a couple of issues related to its clock controllers. This series
> attemps to fix some of them.
> 
> The DT patch should go in first for bisectability, otherwise
> clk/pd_ignore_unused will need to be used, as the SMMU GDSC is no longer
> considered always-on.
> 
> [...]

Applied, thanks!

[3/6] clk: qcom: gcc-msm8998: Don't check halt bit on some branch clks
      commit: a6f1e8623836bb6ce64c347d110ecb6259ae73c4
[4/6] clk: qcom: mmcc-msm8998: Don't check halt bit on some branch clks
      (no commit info)

Best regards,
Bjorn Andersson Sept. 20, 2023, 5:14 p.m. UTC | #3 
On Wed, 09 Aug 2023 21:20:23 +0200, Konrad Dybcio wrote:
> 8998 has a couple of issues related to its clock controllers. This series
> attemps to fix some of them.
> 
> The DT patch should go in first for bisectability, otherwise
> clk/pd_ignore_unused will need to be used, as the SMMU GDSC is no longer
> considered always-on.
> 
> [...]

Applied, thanks!

[3/6] clk: qcom: gcc-msm8998: Don't check halt bit on some branch clks
      (no commit info)
[4/6] clk: qcom: mmcc-msm8998: Don't check halt bit on some branch clks
      commit: 9906c4140897bbdbff7bb71c6ae67903cb9954ce
[5/6] clk: qcom: mmcc-msm8998: Fix the SMMU GDSC
      commit: 1fc62c8347397faf4e18249e88ecd4470c0a5357

Best regards,