From patchwork Tue May 30 22:48:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Judith Mendez X-Patchwork-Id: 10068 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2509960vqr; Tue, 30 May 2023 15:52:14 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4IG+QWy4fhTQeM40euPaJun2xe/UngxICopZ7GkP2CkvT+Nv3l6feVclBGS4dbGTLggccm X-Received: by 2002:a17:902:e545:b0:1b0:f727:bc41 with SMTP id n5-20020a170902e54500b001b0f727bc41mr1098299plf.42.1685487134200; Tue, 30 May 2023 15:52:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685487134; cv=none; d=google.com; s=arc-20160816; b=n8DuxN1wGuo2XFn8tP49BxXXzjeGWANIFiqetawGNdL1zKiTPx7s7a4ATKt/oYMPfv 159YVtjJm+5LPriEsNGeKy51yICopMNFPgzxxpmIlBT4JYT80zYl3ueRSZnaTvwk+QhD M4/A6SRSzXyHKz/tA+r73kiPKcZ6T6wiPMvfwoDbtRx/XaolzUshrsttwJ/3JnW2LM2O cF+nAbOgf1CJN5rlpXZzDG3upZfKvNlD2fLnlBychVpbw/gSJ2HVkosOhjn/gfxBHYwx jjg2xi9xKluhQFKTz/zdwD2aa39eM6lsCar72+uW+/Z0NrVm2KC3AVPloex8/gIRsLYi HvQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=/rcFi88fFTflJh3lvZ6kawNLHnOf/3ME9U3laQEXsQM=; b=FcKzRCwgSVdJF0qFnGOF6WbFGIBz1TQJp06NEky17p9dMwiaXrUT8mI6vn5XhWUmPR /zG/4UwaAvbKkkUPO3uRTd9zIgzKgkc4kAZGxMHoExJLJK+uZml+4j1aPqcgKEQ7SlDv HC+xEIAZqrl845kB59To6WOuVN0wRZfO/OyUR6dZka71NgZfaPE6x4dJIn9FXCJMSZGl nhulzHxZUlu6pldRhhAZao3FnY2lKPzojb/iMOY6wk7cAJjFEk1AlbFm5/Z6cTJVxlsh XQXwv8Y5N5yDH0SNo8JYTQb1WHQKW/EA675Y03mZMeCPGngPzbkcoAUde0AUoh5jSTeT 9cyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=HqNW2uxy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cp5-20020a170902e78500b001aaff31bcccsi5816440plb.124.2023.05.30.15.52.00; Tue, 30 May 2023 15:52:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=HqNW2uxy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233524AbjE3Ws4 (ORCPT + 99 others); Tue, 30 May 2023 18:48:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229761AbjE3Wst (ORCPT ); Tue, 30 May 2023 18:48:49 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2C5B93; Tue, 30 May 2023 15:48:47 -0700 (PDT) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 34UMmL4G040747; Tue, 30 May 2023 17:48:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1685486901; bh=/rcFi88fFTflJh3lvZ6kawNLHnOf/3ME9U3laQEXsQM=; h=From:To:CC:Subject:Date; b=HqNW2uxy+ROUss3qO86+xe2+0cOtbhsVdgStraVz67ht+BnkYOLQEp4TqMaCn3Jcr abgjAm85/HzEWeG/w6hJWpLJahfbRYbloavKqQVUgWKTKKArTYckDmocJyQc06MUL4 FEn+74jteqFGb9yv3/f76thnKe5BBWCEsDHojHes= Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 34UMmLVP028852 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 30 May 2023 17:48:21 -0500 Received: from DFLE109.ent.ti.com (10.64.6.30) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 30 May 2023 17:48:20 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 30 May 2023 17:48:20 -0500 Received: from uda0498204.dhcp.ti.com (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 34UMmKxV112899; Tue, 30 May 2023 17:48:20 -0500 From: Judith Mendez To: Chandrasekar Ramakrishnan , CC: Wolfgang Grandegger , Marc Kleine-Budde , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , , , Schuyler Patton , Tero Kristo , Rob Herring , Krzysztof Kozlowski , , Oliver Hartkopp , Simon Horman , Conor Dooley , Tony Lindgren Subject: [PATCH v8 0/2] Enable multiple MCAN on AM62x Date: Tue, 30 May 2023 17:48:18 -0500 Message-ID: <20230530224820.303619-1-jm@ti.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767361357174867093?= X-GMAIL-MSGID: =?utf-8?q?1767361357174867093?= On AM62x there are two MCANs in MCU domain. The MCANs in MCU domain were not enabled since there is no hardware interrupt routed to A53 GIC interrupt controller. Therefore A53 Linux cannot be interrupted by MCU MCANs. This solution instantiates a hrtimer with 1 ms polling interval for MCAN device when there is no hardware interrupt property in DTB MCAN node. The hrtimer generates a recurring software interrupt which allows to call the isr. The isr will check if there is pending transaction by reading a register and proceed normally if there is. MCANs with hardware interrupt routed to A53 Linux will continue to use the hardware interrupt as expected. Timer polling method was tested on both classic CAN and CAN-FD at 125 KBPS, 250 KBPS, 1 MBPS and 2.5 MBPS with 4 MBPS bitrate switching. Letency and CPU load benchmarks were tested on 3x MCAN on AM62x. 1 MBPS timer polling interval is the better timer polling interval since it has comparable latency to hardware interrupt with the worse case being 1ms + CAN frame propagation time and CPU load is not substantial. Latency can be improved further with less than 1 ms polling intervals, howerver it is at the cost of CPU usage since CPU load increases at 0.5 ms. Note that in terms of power, enabling MCU MCANs with timer-polling implementation might have negative impact since we will have to wake up every 1 ms whether there are CAN packets pending in the RX FIFO or not. This might prevent the CPU from entering into deeper idle states for extended periods of time. v7: Link: https://lore.kernel.org/linux-can/20230523023749.4526-1-jm@ti.com/T/#t v6: Link: https://lore.kernel.org/linux-can/20230518193613.15185-1-jm@ti.com/T/#t v5: Link: https://lore.kernel.org/linux-can/20230510202952.27111-1-jm@ti.com/T/#t v4: Link: https://lore.kernel.org/linux-can/c3395692-7dbf-19b2-bd3f-31ba86fa4ac9@linaro.org/T/#t v2: Link: https://lore.kernel.org/linux-can/20230424195402.516-1-jm@ti.com/T/#t V1: Link: https://lore.kernel.org/linux-can/19d8ae7f-7b74-a869-a818-93b74d106709@ti.com/T/#t RFC: Link: https://lore.kernel.org/linux-can/52a37e51-4143-9017-42ee-8d17c67028e3@ti.com/T/#t v7: - Cancel hrtimer after interrupts in m_can_stop - Move assignment of hrtimer_callback to m_can_class_register() - Initialize irq = 0 if polling mode is used v6: - Clean up m_can_platform.c after removing poll-interval v6: - Move hrtimer stop/start function calls to m_can_open and m_can_close to support power suspend/resume v5: - Remove poll-interval in bindings - Change dev_dbg to dev_info if hardware int exists and polling is enabled v4: - Wrong patches sent v3: - Update binding poll-interval description - Add oneOf to select either interrupts/798d276b39e984345d52b933a900a71fa0815928 v2: - Add poll-interval property to bindings and MCAN DTB node - Add functionality to check for 'poll-interval' property in MCAN node - Bindings: add an example using poll-interval - Add 'polling' flag in driver to check if device is using polling method - Check for timer polling and hardware interrupt cases, default to hardware interrupt method - Change ns_to_ktime() to ms_to_ktime() Judith Mendez (2): dt-bindings: net: can: Remove interrupt properties for MCAN can: m_can: Add hrtimer to generate software interrupt .../bindings/net/can/bosch,m_can.yaml | 20 +++++++++-- drivers/net/can/m_can/m_can.c | 34 +++++++++++++++++-- drivers/net/can/m_can/m_can.h | 3 ++ drivers/net/can/m_can/m_can_platform.c | 24 +++++++++++-- 4 files changed, 74 insertions(+), 7 deletions(-) base-commit: 798d276b39e984345d52b933a900a71fa0815928