From patchwork Tue May 30 07:53:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabrizio Lamarque X-Patchwork-Id: 10006 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2019879vqr; Tue, 30 May 2023 01:24:10 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4FHd2Oa8bl+Le3IqhriUBd214sCZPT4BZuiAe7tDxLAD9K0n/XQ/lnBaoS4cPIOUlO9zft X-Received: by 2002:a05:6a21:339e:b0:111:5017:8cb8 with SMTP id yy30-20020a056a21339e00b0011150178cb8mr1815135pzb.4.1685435050499; Tue, 30 May 2023 01:24:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685435050; cv=none; d=google.com; s=arc-20160816; b=OeQtNDFN06PvFA+aYGJEXtC+TB6VUE8EEvLGwO7N1I4c5fmAtjv/qJK1UthnXAgKkL O4yZOoXX5PTGAxm9/jparLZa5hKbKgU6We3LkSsg38bwJlTM/XFdgSkXO0PJVjQ8nETm 9e9ksOoPLW9u3zAltd4y7yX5uvvfXtUga44o4D1uusRfLprpSIirtFPAT/7LPLrS237B i8qlJfcEAVYGJqYVSky5gGfXKPvT1Prq77YiLhp0qAjasuV/mjVrDPq9MSkS0qM5tAfV 6vLF3eMYGOcraf7CuWXNbnxHlmea5UzH/IrfHG7XLdTRSKbjkuYEhzi1g/GWFl61aYqK CqOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=iN1gw0mwm7WmvYXFIrcXk8pdCkRKPm8Ajl3S6Jy5MwI=; b=if+1gi+owvcZkloy0KsMQ/qySdMmy5gKRWtfZ9nRcIhjdnb9fI9yfHcrGCwuwZLJWt T3MoVbJ/tjp6p41SE/WL9PrN4klFuEPL9dsF7pYvr+2HQNsHjIAzq18ootBkyrRCW2tB yEtyw1VSMEOrpCfNqbzE7KCUuS5N7wFZDT8FusQxNZGDt5Joi13ngjldMNJl73lU/w6p mL7zNn7GNrF1b9bcQkOhJRXiEJMIaKQ+k5A7g+OLHPlT23d/m6wPZM8CgSHbI83wdVbd aH4O+tp8UIqe4dJVmUvZk9av4BPI2gIa0rtB0jBswYYxI6y5ti9Ds7806L974O+nKJKW q9jQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=ZrDagKrm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x16-20020aa79a50000000b0064f4eb8dd2dsi1319809pfj.204.2023.05.30.01.23.58; Tue, 30 May 2023 01:24:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=ZrDagKrm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229604AbjE3Hxe (ORCPT + 99 others); Tue, 30 May 2023 03:53:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229588AbjE3Hxc (ORCPT ); Tue, 30 May 2023 03:53:32 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FF28118; Tue, 30 May 2023 00:53:26 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-3f606912ebaso42741195e9.3; Tue, 30 May 2023 00:53:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685433205; x=1688025205; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=iN1gw0mwm7WmvYXFIrcXk8pdCkRKPm8Ajl3S6Jy5MwI=; b=ZrDagKrme3a6Hd3dwAsyc58nI93cJrUXLIBdL+tbD06gbNArOM7cJHn0IKhRdjXgX6 t9LUKxyWy/ySTqil0Ytjp7OyWIrGx/Mde1aNMbaBiY6uIKDg7nxH3xbEoG3sjNjIqfgH BO/nNFRzjk9B1bkO84yjbOJg01t0xRpjJeqt+ymrsmIfVVpjtVOHkIgjmQrl3MnrPymj DsEMdvtRXCEwoFSkSWpnT/TiyziFuhWUZ4Df77msnZ3mx1sXKrXMUYHJUM3Iim42H+nQ +JYnmt2S7n8h48ILWkHU++/bmUjaRiHKqtmr5B4b6fNIpIzo8WgyBuYucxT5V3gNUCSU nNAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685433205; x=1688025205; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iN1gw0mwm7WmvYXFIrcXk8pdCkRKPm8Ajl3S6Jy5MwI=; b=MkP8FcmClvbURcDmbY03Mu/deHtD6Z724zJyjT6GR8fVBml4N9lbCOrjm11YtRBcqo 6hkuNsI3IXDkR0Z2anQCZoQUvdCcUxOcgiHPXAw+SlEYQYSqznAHbonC5oxLe6V80Rew MMGqIpJFPFZdmYzI8qdG9vAXdD5yic4hFIGIBQXPpC49qWTHiWgTw8hWMjJFO1Kmxh9J EmYl/plz/50luBu8yN3LI83vmTlw3d3CON/XUcV+zZ2ghGX//shmlVK6vLz8VgG0CjXl +3LEbCmzYK18CSWiTfBQwD1dsbJy26zjsgLLLdYNeMg24r8qFBAPE6XmiLGgw/N8cKtN Ldyg== X-Gm-Message-State: AC+VfDzb3pF+IRnWPMmm0qTpZbCTQ+BX4iUDh6aqR+i92LxBCQkWWeSf 8QofiyKHekttLNgJsQZaGoZG8waMGKM= X-Received: by 2002:a05:600c:b44:b0:3f2:48dc:5e02 with SMTP id k4-20020a05600c0b4400b003f248dc5e02mr811929wmr.27.1685433204598; Tue, 30 May 2023 00:53:24 -0700 (PDT) Received: from PC-UT2.ad.ennebielettronica.com ([78.152.97.130]) by smtp.gmail.com with ESMTPSA id x21-20020a05600c21d500b003f6041f5a6csm16561275wmj.12.2023.05.30.00.53.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 00:53:24 -0700 (PDT) From: fl.scratchpad@gmail.com To: jic23@kernel.org Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Fabrizio Lamarque Subject: [PATCH v3 0/5] Fix ad7192 driver issues Date: Tue, 30 May 2023 09:53:06 +0200 Message-Id: <20230530075311.400686-1-fl.scratchpad@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767306743322145161?= X-GMAIL-MSGID: =?utf-8?q?1767306743322145161?= From: Fabrizio Lamarque Here is a patch set to overcome a number of issues in current ad7192 adc driver implementation prevending the driver to be loaded and behave correctly: - null pointer dereference causing kernel panic on driver probe; - wrong internal clock selection; - use of "avdd" regulator name in place of vref (reference voltage); - missing clock options in bindings docs only (already implemented). The first two issues are regressions. Backported patches have been tested on a platform with an ARM Cortex-A7 CPU from NXP with kernel 5.15. As a side note, on the tested platform there is still an issue with a pending interrupt that I worked around by setting the DRDY IRQ to LEVEL in place of EDGE sensing. Also, setting IRQ_DISABLE_UNLAZY flag does not help in my case. You may find further information here: https://lore.kernel.org/all/CAPJMGm4GaSjD6bdqMwCr2EVZGenWzT-nCCf3BMRaD1TSfAabpA@mail.gmail.com/ Version log: v2->v3 - Reworded commit messages - Split binding fixes v1->v2 - Obtained ad7192_state from iio_dev pointer - Added patch on bindings documentation Fabrizio Lamarque (5): iio: adc: ad7192: Fix null ad7192_state pointer access iio: adc: ad7192: Fix internal/external clock selection iio: adc: ad7192: Use VRef instead of AVdd as reference voltage source dt-bindings: iio: ad7192: Add mandatory reference voltage source dt-bindings: iio: ad7192: Allow selection of clock modes .../bindings/iio/adc/adi,ad7192.yaml | 32 +++++++++++++++++-- drivers/iio/adc/ad7192.c | 31 +++++++++++++++--- 2 files changed, 55 insertions(+), 8 deletions(-)