mbox series

[0/8] arm64: dts: qcom: msm8939: Rework regulator constraints

Message ID 20230530-msm8939-regulators-v1-0-a3c3ac833567@gerhold.net
Headers
Series arm64: dts: qcom: msm8939: Rework regulator constraints |

Message

Stephan Gerhold June 14, 2023, 7:15 a.m. UTC 
  Rework the regulator constraints for the MSM8939 device trees to be 
closer to reality. There are several mistakes in there, some of them 
taken over directly from Qualcomm's vendor kernel. Fortunately, none of 
the mistakes is absolutely critical because it turns out that the RPM 
firmware also validates the voltages and silently clamps the requests 
to a proper range. Still, this behavior should be clearly represented 
in the device tree rather than pretending to apply the wrong voltages.

Apply the same changes as previously for MSM8916 [1] and move the 
voltages for the standard components in the SoC to the shared 
msm8916-pm8939.dtsi. With this only the actual board-specific 
regulators are described in the board DT.

[1]: https://lore.kernel.org/linux-arm-msm/20230510-msm8916-regulators-v1-0-54d4960a05fc@gerhold.net/

Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
---
Stephan Gerhold (8):
      arm64: dts: qcom: msm8939-pm8916: Add missing pm8916_codec supplies
      arm64: dts: qcom: msm8939: Disable lpass_codec by default
      arm64: dts: qcom: msm8939-sony-tulip: Fix l10-l12 regulator voltages
      arm64: dts: qcom: msm8939-sony-tulip: Allow disabling pm8916_l6
      arm64: dts: qcom: msm8939: Fix regulator constraints
      arm64: dts: qcom: msm8939-pm8916: Clarify purpose
      arm64: dts: qcom: msm8939: Define regulator constraints next to usage
      arm64: dts: qcom: msm8939-pm8916: Mark always-on regulators

 arch/arm64/boot/dts/qcom/apq8039-t2.dts            | 102 +-----------------
 arch/arm64/boot/dts/qcom/msm8939-pm8916.dtsi       | 119 +++++++++++++++++----
 .../dts/qcom/msm8939-sony-xperia-kanuti-tulip.dts  |  99 -----------------
 arch/arm64/boot/dts/qcom/msm8939.dtsi              |   1 +
 4 files changed, 104 insertions(+), 217 deletions(-)
---
base-commit: 818e1fca81bfd773144d42f4fbe52b287235e8b4
change-id: 20230530-msm8939-regulators-dd631887ff4c

Best regards,

Comments

Bjorn Andersson June 14, 2023, 4:03 p.m. UTC | #1 
On Wed, 14 Jun 2023 09:15:58 +0200, Stephan Gerhold wrote:
> Rework the regulator constraints for the MSM8939 device trees to be
> closer to reality. There are several mistakes in there, some of them
> taken over directly from Qualcomm's vendor kernel. Fortunately, none of
> the mistakes is absolutely critical because it turns out that the RPM
> firmware also validates the voltages and silently clamps the requests
> to a proper range. Still, this behavior should be clearly represented
> in the device tree rather than pretending to apply the wrong voltages.
> 
> [...]

Applied, thanks!

[1/8] arm64: dts: qcom: msm8939-pm8916: Add missing pm8916_codec supplies
      commit: dce9254511d6c9ea0d5ed7e4f21e6206e2ca35ce
[2/8] arm64: dts: qcom: msm8939: Disable lpass_codec by default
      commit: 6002a78023cded6f02eac7c812b076046cab8060
[3/8] arm64: dts: qcom: msm8939-sony-tulip: Fix l10-l12 regulator voltages
      commit: 209aea1ad505519faf018b596e4fdca0d0569469
[4/8] arm64: dts: qcom: msm8939-sony-tulip: Allow disabling pm8916_l6
      commit: 8771308c91cefc072f36415cec0b802ee55b1d96
[5/8] arm64: dts: qcom: msm8939: Fix regulator constraints
      commit: 9187d555c4ba9544c7f117062d241aa085f59a06
[6/8] arm64: dts: qcom: msm8939-pm8916: Clarify purpose
      commit: 88028fa047fb72826dd206b51550be780777718c
[7/8] arm64: dts: qcom: msm8939: Define regulator constraints next to usage
      commit: 5cdab9a8c70c4d979909dd1bb6d1f3eacd9fa270
[8/8] arm64: dts: qcom: msm8939-pm8916: Mark always-on regulators
      commit: ecbfba694b5baf2b854689c63ef011e905810c59

Best regards,