mbox series

[v3,0/2] KVM: x86: Report actual nent from KVM_GET_CPUID2

Message ID 20230526210340.2799158-1-seanjc@google.com
Headers
Series KVM: x86: Report actual nent from KVM_GET_CPUID2 |

Message

Sean Christopherson May 26, 2023, 9:03 p.m. UTC 
  Essentially v3 of Takahiro's patch.  Update cpuid->nent on a successful
KVM_GET_CPUID2 so that userspace knows exactly how many entries were
filled.  Add a testcase to verify KVM's ABI.

v3:
 - Don't bother updating cpuid->nent in the error path, the data is never
   copied to userspace.
 - Add testcase to cpuid_test

v2: https://lore.kernel.org/all/20230413175844.21760-1-itazur@amazon.com
v1: https://lore.kernel.org/all/20230410141820.57328-1-itazur@amazon.com

Sean Christopherson (2):
  KVM: x86: Update number of entries for KVM_GET_CPUID2 on success, not
    failure
  KVM: selftests: Extend cpuid_test to verify KVM_GET_CPUID2 "nent"
    updates

 arch/x86/kvm/cpuid.c                          | 13 ++++--------
 .../testing/selftests/kvm/x86_64/cpuid_test.c | 21 +++++++++++++++++++
 2 files changed, 25 insertions(+), 9 deletions(-)


base-commit: b9846a698c9aff4eb2214a06ac83638ad098f33f

Comments

Sean Christopherson June 2, 2023, 1:21 a.m. UTC | #1 
On Fri, 26 May 2023 14:03:38 -0700, Sean Christopherson wrote:
> Essentially v3 of Takahiro's patch.  Update cpuid->nent on a successful
> KVM_GET_CPUID2 so that userspace knows exactly how many entries were
> filled.  Add a testcase to verify KVM's ABI.
> 
> v3:
>  - Don't bother updating cpuid->nent in the error path, the data is never
>    copied to userspace.
>  - Add testcase to cpuid_test
> 
> [...]

Applied to kvm-x86 misc, thanks!

[1/2] KVM: x86: Update number of entries for KVM_GET_CPUID2 on success, not failure
      https://github.com/kvm-x86/linux/commit/ab322c43cce9
[2/2] KVM: selftests: Extend cpuid_test to verify KVM_GET_CPUID2 "nent" updates
      https://github.com/kvm-x86/linux/commit/2c7613131998

--
https://github.com/kvm-x86/linux/tree/next
https://github.com/kvm-x86/linux/tree/fixes
Takahiro Itazuri June 2, 2023, 8:42 a.m. UTC | #2 
Date:   Fri, 26 May 2023 14:03:38 -0700
From:   Sean Christopherson <seanjc@google.com>
> Essentially v3 of Takahiro's patch.  Update cpuid->nent on a successful
> KVM_GET_CPUID2 so that userspace knows exactly how many entries were
> filled.  Add a testcase to verify KVM's ABI.

Sorry for my late reply and thank you for posting this revision!

Best regards,
Takahiro Itazuri