mbox series

[0/2] x86/tdx: Fix one more load_unaligned_zeropad() issue

Message ID 20230525225847.28592-1-kirill.shutemov@linux.intel.com
Headers
Series x86/tdx: Fix one more load_unaligned_zeropad() issue |

Message

Kirill A. Shutemov May 25, 2023, 10:58 p.m. UTC 
  During review of TDX guests on Hyper-V patchset Dave pointed to the
potential race between changing page private/shared status and
load_unaligned_zeropad().

Fix the issue.

Kirill A. Shutemov (2):
  x86/mm: Allow guest.enc_status_change_prepare() to fail
  x86/tdx: Fix race between set_memory_encrypted() and load_unaligned_zeropad()

 arch/x86/coco/tdx/tdx.c         | 56 +++++++++++++++++++++++++++++++--
 arch/x86/include/asm/x86_init.h |  2 +-
 arch/x86/kernel/x86_init.c      |  4 +--
 arch/x86/mm/mem_encrypt_amd.c   |  4 ++-
 arch/x86/mm/pat/set_memory.c    |  3 +-
 5 files changed, 61 insertions(+), 8 deletions(-)

Comments

Dexuan Cui May 26, 2023, 2:35 a.m. UTC | #1 
> From: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Sent: Thursday, May 25, 2023 3:59 PM
>  ...
> During review of TDX guests on Hyper-V patchset Dave pointed to the
> potential race between changing page private/shared status and
> load_unaligned_zeropad().
> 
> Fix the issue.

Hi Kirill, I tested the patches on Hyper-V, and didn't find any issue.

Thanks for the patches! It looks like the patches can address Dave's
concerns. I'll wait for your patches to go in first, and then I'll rebase
my patches.

Thanks,
Dexuan