From patchwork Thu May 25 22:39:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 9866 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp90341vqr; Thu, 25 May 2023 15:44:58 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5J6m/7G1fBIyjlahp8UjqmNhBNllHJWYZgRUisuMEmv3SQRsoZLnmL+qiD8mqazxDTARG6 X-Received: by 2002:a05:6a00:1823:b0:64c:aa98:a69f with SMTP id y35-20020a056a00182300b0064caa98a69fmr481145pfa.1.1685054698712; Thu, 25 May 2023 15:44:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685054698; cv=none; d=google.com; s=arc-20160816; b=cT6Bvbe64OcMwpyzj6Ygoar0ciSFfTSQnn9QY98FcElsnSb6DxaV32C2o//03Bl9bL sbAvzYXUXLXAG5rMk49MfpZbCzvn/JKKQT8W2Prhr3Z/nLuhCjG3hyHcHHPBCZazYhxP NW033V6Y4Xum6AUqFjdcVon0dlIGiVCtq1TTTtmZTt8MacG+L1ybiaiqgxzSZBDZzYxB qOFbndh1oWW9p9ldKzJDIuRJ9BcmaJU7Q80ECJzkjzO7rEPh3uUFC9h4DhzgUj1aM37B uVZQvUMDoRNokDg2jNv+5HgilGMXfI/Zg+Z1SAbHHbFHNUDsheD2GSZt/5GcQdigeu/m /0/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=XfXqmZRZyewS7hbeld3Fb741MiT0i4I4BJ+K3KWmVSM=; b=Rx85gF6Pn0i1VKgG0d/WFQGlH+4InWNuXlFiFegIyJmWhJQ9gSbNXlytnsiG2lb0a9 5mkZcbJPmdOvPnE0L6AxT6S2UOT/SlO0QtL+fEfvCB8ucnpeYnDvVatP/tI43hl4pgmk 3LIYBXhEHGSoncqQgb91GJte0dYnwV3Iz5apzqnAM1KBWjzSHvS7vmDabo47TlwIMYJ6 vVkt8SjIiiz9nZVXfsbWYne7pPVPQEUZXwpcfZoO9m5p8vGMHnw6RPHJi8Vvu5MvW7n1 3MMeVrVr0eWG7Yw3CgTzju4xdxjhYv+hOAmaeaOFotX1YewXnoPcz9rB3ckyQaMS5Fvp sAmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dfsqT4QS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a10-20020aa795aa000000b0064d28796335si2566480pfk.92.2023.05.25.15.44.46; Thu, 25 May 2023 15:44:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dfsqT4QS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235461AbjEYWlB (ORCPT + 99 others); Thu, 25 May 2023 18:41:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229832AbjEYWkw (ORCPT ); Thu, 25 May 2023 18:40:52 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E98D5A7 for ; Thu, 25 May 2023 15:40:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685054405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=XfXqmZRZyewS7hbeld3Fb741MiT0i4I4BJ+K3KWmVSM=; b=dfsqT4QSuec5c0yMGCxz5SCVRzl2fXGuySUhsoPy+Ro9G9jG9E42/IaX9BQst+ATFYwI7x tfAEIFPlbDCumwtcrfKaUZYVKRstsJiLeCID2LcAMaFmLol80yYvkOSltdFU8Y1eVdvbTU gvWCWtNFTkT27tssOFJ9e16+36FeQ0k= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-632-uSF_FvTSNk6_plfteQwiVw-1; Thu, 25 May 2023 18:39:59 -0400 X-MC-Unique: uSF_FvTSNk6_plfteQwiVw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A406D29AA39B; Thu, 25 May 2023 22:39:58 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.39.192.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id DC8D7C154D1; Thu, 25 May 2023 22:39:55 +0000 (UTC) From: David Howells To: Christoph Hellwig , David Hildenbrand Cc: David Howells , Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH v2 0/3] block: Make old dio use iov_iter_extract_pages() and page pinning Date: Thu, 25 May 2023 23:39:50 +0100 Message-Id: <20230525223953.225496-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766882794306395910?= X-GMAIL-MSGID: =?utf-8?q?1766907916022971190?= Hi Christoph, David, Since Christoph asked nicely[1] ;-), here are three patches that go on top of the similar patches for bio structs now in the block tree that make the old block direct-IO code use iov_iter_extract_pages() and page pinning. There are three patches: (1) Make page pinning not add or remove a pin to/from a ZERO_PAGE, thereby allowing the dio code to insert zero pages in the middle of dealing with pinned pages. A pair of functions are provided to wrap the testing of a page or folio to see if it is a zero page. (2) Provide a function to allow an additional pin to be taken on a page we already have pinned (and do nothing for a zero page). (3) Switch direct-io.c over to using page pinning and to use iov_iter_extract_pages() so that pages from non-user-backed iterators aren't pinned. I've pushed the patches here also: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=iov-old-dio David Changes ======= ver #2) - Fix use of ZERO_PAGE(). - Add wrappers for testing if a page is a zero page. - Return the zero page obtained, not ZERO_PAGE(0) unconditionally. - Need to set BIO_PAGE_PINNED conditionally, and not BIO_PAGE_REFFED. Link: https://lore.kernel.org/r/ZGxfrOLZ4aN9/MvE@infradead.org/ [1] Link: https://lore.kernel.org/r/20230525155102.87353-1-dhowells@redhat.com/ # v1 David Howells (3): mm: Don't pin ZERO_PAGE in pin_user_pages() mm: Provide a function to get an additional pin on a page block: Use iov_iter_extract_pages() and page pinning in direct-io.c fs/direct-io.c | 72 ++++++++++++++++++++++++----------------- include/linux/mm.h | 1 + include/linux/pgtable.h | 10 ++++++ mm/gup.c | 54 ++++++++++++++++++++++++++++++- 4 files changed, 107 insertions(+), 30 deletions(-)