From patchwork Thu May 25 15:50:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 9852 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp481815vqr; Thu, 25 May 2023 09:05:41 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6SsKmmxSOfu/4kX5XXI/lrwwKde3nKfkKD2sw8wuNTc+j9tG12Rig4FNXY2Ac+wG+uTmEz X-Received: by 2002:a05:6a20:5483:b0:10f:52e2:4a0a with SMTP id i3-20020a056a20548300b0010f52e24a0amr1420319pzk.18.1685030741364; Thu, 25 May 2023 09:05:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685030741; cv=none; d=google.com; s=arc-20160816; b=GRNRJR+onSez/ladY3B3562AdLrNX7kbol43Di6s06taoohz9MIWvFNkYmBntxiucl Q5BwbwwFIWZwBU7cJw8v8PMzMmKZO1frYn40+4pIIdja3ncqrv3omNgUmHYwDTI1fPwy G465Z1cgQSk8O4ReYx9jGOv4dtyRoJxwdWdjjr1j3HMElB2HtIflmDB/WIsE/OTu9xZE hSnepQ1rw/tneRoKzoJHb0vK8IqIhnJkjktByavtrMJCNj5f3xNiR157uQplAVcG7bpn FselTKlShkf/EXjBiwyNYXsWr/ihu7atfWnm2LS1MHoItDoJK2XSqGfMGr4OT8KbArd8 9rfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Dnh9Ymd0aXLnszSbYXuRCQIZeE9p62JOLrx7AW+9I7M=; b=Q+3y2LF2zPjY0a4yAPAotEdp0QHPORFa3BcW8w3csaUuIv2Utd8n5VQLUNKFE58VXz ddch9Ih0Q1xFpM1zy/f4rfqqmLVVttPUV0doyCIspG/IeY23qeMrUrseOKbkqnBV+Ykh B/8w2n0mcAdYW8myRohIZoCQkdYhZGZ3tndaCA9uVaO+5evFo3xqAudHmPLisMvJnhdk goBbFdErs9nL1T+SK51EupzC1NynKyrYfuTagUc7JFHCSmxr3jtPwHUkYxIlZXsPL9+J kHOlCr9e0HMD0v6j+AvqCeZUI+u3u2/8a70gcJkZAKE4PJFfToyZQp7r4mCucY8LkJkL f0zg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BHKXOef8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h35-20020a635323000000b0053b8c700f19si1358093pgb.529.2023.05.25.09.05.25; Thu, 25 May 2023 09:05:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BHKXOef8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241479AbjEYPwN (ORCPT + 99 others); Thu, 25 May 2023 11:52:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241387AbjEYPvv (ORCPT ); Thu, 25 May 2023 11:51:51 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86D24C0 for ; Thu, 25 May 2023 08:51:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685029873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Dnh9Ymd0aXLnszSbYXuRCQIZeE9p62JOLrx7AW+9I7M=; b=BHKXOef8H4clnsltF7EMqDwEmH53H536iDdNJ+Nmakv8dMscq0I7tPO/i1F6302zdjf8b5 64pu6wVHGi6A1sbZLTIesrI4IpJpNN0GSTfbZ6Q40CaysxohL0RjOMBXJjT3LD1CbdOZYL 01UHEwWjD7eybhd09iObEFHAe3r9wzo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-138-tBX-uUEGPaSF-e1H0150-Q-1; Thu, 25 May 2023 11:51:08 -0400 X-MC-Unique: tBX-uUEGPaSF-e1H0150-Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7E1DD8030D2; Thu, 25 May 2023 15:51:07 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.39.192.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7180D200BA65; Thu, 25 May 2023 15:51:04 +0000 (UTC) From: David Howells To: Christoph Hellwig , David Hildenbrand Cc: David Howells , Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 0/3] block: Make old dio use iov_iter_extract_pages() and page pinning Date: Thu, 25 May 2023 16:50:59 +0100 Message-Id: <20230525155102.87353-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766882794306395910?= X-GMAIL-MSGID: =?utf-8?q?1766882794306395910?= Hi Christoph, David, Since Christoph asked nicely[1] ;-), here are three patches that go on top of the similar patches for bio structs now in the block tree that make the old block direct-IO code use iov_iter_extract_pages() and page pinning. There are three patches: (1) Make page pinning not add or remove a pin to/from the ZERO_PAGE, thereby allowing the dio code to insert zero pages in the middle of dealing with pinned pages. (2) Provide a function to allow an additional pin to be taken on a page we already have pinned (and do nothing for the zero page). (3) Switch direct-io.c over to using page pinning and to use iov_iter_extract_pages() so that pages from non-user-backed iterators aren't pinned. Note that I haven't managed to test this yet as SELinux is refusing to let me mount things like ext2 filesystems on account of it not having xattrs:-/ I've pushed the patches here also: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=iov-old-dio David Link: https://lore.kernel.org/r/ZGxfrOLZ4aN9/MvE@infradead.org/ [1] David Howells (3): mm: Don't pin ZERO_PAGE in pin_user_pages() mm: Provide a function to get an additional pin on a page block: Use iov_iter_extract_pages() and page pinning in direct-io.c fs/direct-io.c | 68 ++++++++++++++++++++++++++++------------------ include/linux/mm.h | 1 + mm/gup.c | 54 +++++++++++++++++++++++++++++++++++- 3 files changed, 95 insertions(+), 28 deletions(-)