Message ID | 20230524112126.2242-1-tumic@gpxsee.org |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2716803vqo; Wed, 24 May 2023 02:41:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7KgBodd7TIGx8g319La8VVIN6Ip5pAWiJWqGvY1Mm4Rz04i4v1hcphADEkE7MfNF2o+G8s X-Received: by 2002:a17:902:cec2:b0:1af:cdd9:e970 with SMTP id d2-20020a170902cec200b001afcdd9e970mr5109098plg.12.1684921307685; Wed, 24 May 2023 02:41:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684921307; cv=none; d=google.com; s=arc-20160816; b=W0/h9VqTxsb7OdPYdANgaelQ5Xnc5lRVV/CR1IuZO1YaHHj+eYs3YdE9KTwQiSgXOh 9NfmTc7FxMPKnA4lqLhwAsFunqSZB3IyG+AQLgA3LCM0xDGwH5muG2zKyMNEiX4i1RIv loTZQHbXiBf+MH5KTBr0rhYWTP8f7SEqsjeBdA8onPGwR0XCgjFu01aM+jyX+3KJj1XH VpjbAXQ1RRhfT3njiReaMe4WyQeUwxviDxiFjFzKhKiZ9+J0zN6cX8UzlTsKHlV2xYbk 18s9WRKwh0IG/Yb2DpHY3ywCZY9RPdZdmibsGudpcty7HtBk65y8d3Txh7UDO/IFCth1 U4Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=JoRJPsO7VokYhMcWpUX66OX+/AkVUGJMKonYGX2Ldy0=; b=dFT44SsmzvO1LWFxzh8lySIzKCJRdw2v+A+Zak/q371OAlLRC4W2hJ12KwOlXS40NQ UPz7j1wTMnhR5s69B+wmm1Vm1b4H3/thtAgREtf+1ciGyKJVr9DTEOVrq71OAd+pijN2 N9eZdARpIn1J0KXdvkYp3pegygRLPJIwGoRKkPaKveK9W6SYCyqWIbAgtSLUC2xqliEl 0F9W0OIYNx1kGVfRfKrFFrc1wZs81V7KhMXOukqRJTiqZzijGUaPq+fxu2+aWHFL4V/S dJRhXBhxuoBGy5yv5MG+JfXFZGde78aP9oiu7fau6xNPQWB78PU6566QhbSJ70dzU5uF jCoQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x6-20020a170902ea8600b001a2513b8e14si3730487plb.84.2023.05.24.02.41.34; Wed, 24 May 2023 02:41:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230031AbjEXJkX (ORCPT <rfc822;ahmedalshaiji.dev@gmail.com> + 99 others); Wed, 24 May 2023 05:40:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231534AbjEXJju (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 24 May 2023 05:39:50 -0400 Received: from mx.gpxsee.org (mx.gpxsee.org [37.205.14.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E33A412E; Wed, 24 May 2023 02:39:42 -0700 (PDT) Received: from mgb4.digiteq.red (unknown [62.77.71.229]) by mx.gpxsee.org (Postfix) with ESMTPSA id A651345B34; Wed, 24 May 2023 11:21:28 +0200 (CEST) From: tumic@gpxsee.org To: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Martin_T=C5=AFma?= <martin.tuma@digiteqautomotive.com> Subject: [RESEND PATCH v6 0/1] Digiteq Automotive MGB4 driver Date: Wed, 24 May 2023 13:21:25 +0200 Message-Id: <20230524112126.2242-1-tumic@gpxsee.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766768045609099405?= X-GMAIL-MSGID: =?utf-8?q?1766768045609099405?= |
Series |
Digiteq Automotive MGB4 driver
|
|
Message
Martin Tůma
May 24, 2023, 11:21 a.m. UTC
From: Martin Tůma <martin.tuma@digiteqautomotive.com>
Hi,
This patch adds a driver for the Digiteq Automotive MGB4 grabber card.
MGB4 is a modular frame grabber PCIe card for automotive video interfaces
(FPD-Link and GMSL for now). It is based on a Xilinx FPGA and uses their
XDMA IP core for DMA transfers. Additionally, Xilinx I2C and SPI IP cores
which already have drivers in linux are used in the design.
The driver is a quite standard v4l2 driver, with one exception - there are
a lot of sysfs options that may/must be set before opening the v4l2 device
to adapt the card on a specific signal (see mgb4.rst for details)
as the card must be able to work with various signal sources (or displays)
that can not be auto-detected.
I have run the driver through the v4l2-compliance test suite for both the
input and the output and the results look fine to me (I can provide the
output if required).
Changes in v6:
* Rebased to current master that includes the Xilinx XDMA driver.
Changes in v5:
* Removed unused <linux/version.h> includes
Changes in v4:
* Redesigned the signal change handling logic. Now using the propper timings
API in the video input driver and a propper open() syscall check/logic in
the video output driver.
* Fixed all minor issues from v3 review.
* 'checkpatch.pl --strict' used for checking the code.
Changes in v3:
* Rebased the DMA transfers part to use the new XDMA driver from Xilinx/AMD
Changes in v2:
* Completely rewritten the original Xilinx's XDMA driver to meet kernel code
standards.
* Added all required "to" and "cc" mail addresses.
Martin Tůma (1):
Added Digiteq Automotive MGB4 driver
Documentation/admin-guide/media/mgb4.rst | 352 ++++++++
.../admin-guide/media/pci-cardlist.rst | 1 +
.../admin-guide/media/v4l-drivers.rst | 1 +
MAINTAINERS | 7 +
drivers/media/pci/Kconfig | 1 +
drivers/media/pci/Makefile | 1 +
drivers/media/pci/mgb4/Kconfig | 17 +
drivers/media/pci/mgb4/Makefile | 6 +
drivers/media/pci/mgb4/mgb4_cmt.c | 247 ++++++
drivers/media/pci/mgb4/mgb4_cmt.h | 16 +
drivers/media/pci/mgb4/mgb4_core.c | 641 ++++++++++++++
drivers/media/pci/mgb4/mgb4_core.h | 65 ++
drivers/media/pci/mgb4/mgb4_dma.c | 123 +++
drivers/media/pci/mgb4/mgb4_dma.h | 18 +
drivers/media/pci/mgb4/mgb4_i2c.c | 140 +++
drivers/media/pci/mgb4/mgb4_i2c.h | 35 +
drivers/media/pci/mgb4/mgb4_io.h | 39 +
drivers/media/pci/mgb4/mgb4_regs.c | 30 +
drivers/media/pci/mgb4/mgb4_regs.h | 35 +
drivers/media/pci/mgb4/mgb4_sysfs.h | 18 +
drivers/media/pci/mgb4/mgb4_sysfs_in.c | 780 ++++++++++++++++
drivers/media/pci/mgb4/mgb4_sysfs_out.c | 732 +++++++++++++++
drivers/media/pci/mgb4/mgb4_sysfs_pci.c | 86 ++
drivers/media/pci/mgb4/mgb4_trigger.c | 208 +++++
drivers/media/pci/mgb4/mgb4_trigger.h | 8 +
drivers/media/pci/mgb4/mgb4_vin.c | 830 ++++++++++++++++++
drivers/media/pci/mgb4/mgb4_vin.h | 63 ++
drivers/media/pci/mgb4/mgb4_vout.c | 501 +++++++++++
drivers/media/pci/mgb4/mgb4_vout.h | 58 ++
29 files changed, 5059 insertions(+)
create mode 100644 Documentation/admin-guide/media/mgb4.rst
create mode 100644 drivers/media/pci/mgb4/Kconfig
create mode 100644 drivers/media/pci/mgb4/Makefile
create mode 100644 drivers/media/pci/mgb4/mgb4_cmt.c
create mode 100644 drivers/media/pci/mgb4/mgb4_cmt.h
create mode 100644 drivers/media/pci/mgb4/mgb4_core.c
create mode 100644 drivers/media/pci/mgb4/mgb4_core.h
create mode 100644 drivers/media/pci/mgb4/mgb4_dma.c
create mode 100644 drivers/media/pci/mgb4/mgb4_dma.h
create mode 100644 drivers/media/pci/mgb4/mgb4_i2c.c
create mode 100644 drivers/media/pci/mgb4/mgb4_i2c.h
create mode 100644 drivers/media/pci/mgb4/mgb4_io.h
create mode 100644 drivers/media/pci/mgb4/mgb4_regs.c
create mode 100644 drivers/media/pci/mgb4/mgb4_regs.h
create mode 100644 drivers/media/pci/mgb4/mgb4_sysfs.h
create mode 100644 drivers/media/pci/mgb4/mgb4_sysfs_in.c
create mode 100644 drivers/media/pci/mgb4/mgb4_sysfs_out.c
create mode 100644 drivers/media/pci/mgb4/mgb4_sysfs_pci.c
create mode 100644 drivers/media/pci/mgb4/mgb4_trigger.c
create mode 100644 drivers/media/pci/mgb4/mgb4_trigger.h
create mode 100644 drivers/media/pci/mgb4/mgb4_vin.c
create mode 100644 drivers/media/pci/mgb4/mgb4_vin.h
create mode 100644 drivers/media/pci/mgb4/mgb4_vout.c
create mode 100644 drivers/media/pci/mgb4/mgb4_vout.h
base-commit: ae8373a5add4ea39f032563cf12a02946d1e3546
Comments
Hi Martin, Thank you for this patch. I've reviewed it, so I'm looking forward to v7. On 24/05/2023 13:21, tumic@gpxsee.org wrote: > From: Martin Tůma <martin.tuma@digiteqautomotive.com> > > Hi, > This patch adds a driver for the Digiteq Automotive MGB4 grabber card. > MGB4 is a modular frame grabber PCIe card for automotive video interfaces > (FPD-Link and GMSL for now). It is based on a Xilinx FPGA and uses their > XDMA IP core for DMA transfers. Additionally, Xilinx I2C and SPI IP cores > which already have drivers in linux are used in the design. > > The driver is a quite standard v4l2 driver, with one exception - there are > a lot of sysfs options that may/must be set before opening the v4l2 device > to adapt the card on a specific signal (see mgb4.rst for details) > as the card must be able to work with various signal sources (or displays) > that can not be auto-detected. > > I have run the driver through the v4l2-compliance test suite for both the > input and the output and the results look fine to me (I can provide the > output if required). Yes please! Just include the output in the cover letter next time. I always like to check it, especially for new drivers. Regards, Hans > > Changes in v6: > * Rebased to current master that includes the Xilinx XDMA driver. > > Changes in v5: > * Removed unused <linux/version.h> includes > > Changes in v4: > * Redesigned the signal change handling logic. Now using the propper timings > API in the video input driver and a propper open() syscall check/logic in > the video output driver. > * Fixed all minor issues from v3 review. > * 'checkpatch.pl --strict' used for checking the code. > > Changes in v3: > * Rebased the DMA transfers part to use the new XDMA driver from Xilinx/AMD > > Changes in v2: > * Completely rewritten the original Xilinx's XDMA driver to meet kernel code > standards. > * Added all required "to" and "cc" mail addresses. > > Martin Tůma (1): > Added Digiteq Automotive MGB4 driver > > Documentation/admin-guide/media/mgb4.rst | 352 ++++++++ > .../admin-guide/media/pci-cardlist.rst | 1 + > .../admin-guide/media/v4l-drivers.rst | 1 + > MAINTAINERS | 7 + > drivers/media/pci/Kconfig | 1 + > drivers/media/pci/Makefile | 1 + > drivers/media/pci/mgb4/Kconfig | 17 + > drivers/media/pci/mgb4/Makefile | 6 + > drivers/media/pci/mgb4/mgb4_cmt.c | 247 ++++++ > drivers/media/pci/mgb4/mgb4_cmt.h | 16 + > drivers/media/pci/mgb4/mgb4_core.c | 641 ++++++++++++++ > drivers/media/pci/mgb4/mgb4_core.h | 65 ++ > drivers/media/pci/mgb4/mgb4_dma.c | 123 +++ > drivers/media/pci/mgb4/mgb4_dma.h | 18 + > drivers/media/pci/mgb4/mgb4_i2c.c | 140 +++ > drivers/media/pci/mgb4/mgb4_i2c.h | 35 + > drivers/media/pci/mgb4/mgb4_io.h | 39 + > drivers/media/pci/mgb4/mgb4_regs.c | 30 + > drivers/media/pci/mgb4/mgb4_regs.h | 35 + > drivers/media/pci/mgb4/mgb4_sysfs.h | 18 + > drivers/media/pci/mgb4/mgb4_sysfs_in.c | 780 ++++++++++++++++ > drivers/media/pci/mgb4/mgb4_sysfs_out.c | 732 +++++++++++++++ > drivers/media/pci/mgb4/mgb4_sysfs_pci.c | 86 ++ > drivers/media/pci/mgb4/mgb4_trigger.c | 208 +++++ > drivers/media/pci/mgb4/mgb4_trigger.h | 8 + > drivers/media/pci/mgb4/mgb4_vin.c | 830 ++++++++++++++++++ > drivers/media/pci/mgb4/mgb4_vin.h | 63 ++ > drivers/media/pci/mgb4/mgb4_vout.c | 501 +++++++++++ > drivers/media/pci/mgb4/mgb4_vout.h | 58 ++ > 29 files changed, 5059 insertions(+) > create mode 100644 Documentation/admin-guide/media/mgb4.rst > create mode 100644 drivers/media/pci/mgb4/Kconfig > create mode 100644 drivers/media/pci/mgb4/Makefile > create mode 100644 drivers/media/pci/mgb4/mgb4_cmt.c > create mode 100644 drivers/media/pci/mgb4/mgb4_cmt.h > create mode 100644 drivers/media/pci/mgb4/mgb4_core.c > create mode 100644 drivers/media/pci/mgb4/mgb4_core.h > create mode 100644 drivers/media/pci/mgb4/mgb4_dma.c > create mode 100644 drivers/media/pci/mgb4/mgb4_dma.h > create mode 100644 drivers/media/pci/mgb4/mgb4_i2c.c > create mode 100644 drivers/media/pci/mgb4/mgb4_i2c.h > create mode 100644 drivers/media/pci/mgb4/mgb4_io.h > create mode 100644 drivers/media/pci/mgb4/mgb4_regs.c > create mode 100644 drivers/media/pci/mgb4/mgb4_regs.h > create mode 100644 drivers/media/pci/mgb4/mgb4_sysfs.h > create mode 100644 drivers/media/pci/mgb4/mgb4_sysfs_in.c > create mode 100644 drivers/media/pci/mgb4/mgb4_sysfs_out.c > create mode 100644 drivers/media/pci/mgb4/mgb4_sysfs_pci.c > create mode 100644 drivers/media/pci/mgb4/mgb4_trigger.c > create mode 100644 drivers/media/pci/mgb4/mgb4_trigger.h > create mode 100644 drivers/media/pci/mgb4/mgb4_vin.c > create mode 100644 drivers/media/pci/mgb4/mgb4_vin.h > create mode 100644 drivers/media/pci/mgb4/mgb4_vout.c > create mode 100644 drivers/media/pci/mgb4/mgb4_vout.h > > > base-commit: ae8373a5add4ea39f032563cf12a02946d1e3546