From patchwork Tue May 23 02:37:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Judith Mendez X-Patchwork-Id: 9708 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1850426vqo; Mon, 22 May 2023 19:41:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6uQ04CApmAqxZVk+bDaz7n0Omh5lIMPI1YxMYq/eQOQHBs3QMFVfvwZycgRfLt2qxM3Dpd X-Received: by 2002:a17:903:245:b0:1ae:35ba:8c8f with SMTP id j5-20020a170903024500b001ae35ba8c8fmr15061704plh.13.1684809694251; Mon, 22 May 2023 19:41:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684809694; cv=none; d=google.com; s=arc-20160816; b=SbICUzlpO3JsxrbmExQvksbudrBOI8y2JKw+hHWwBqC6aXFsklPU4E7B8LO+IqxLzG NJ3XbbH8fFB4ivKqXZUEIMS/e1E38WRN7Ld6yUr12+wWsPrblvv29pfAaPUjElJwTKIQ AwMF7+z4VZDB5S+Qn+qFlw7xb3krMNi5BGGXNwlo6ha1VCra2Z7Lf/5IYNvkkC3Bz0SR +fm1F4Rx4PXC5V24z9VMWHCg7SubUAYcoe4rF2ceu/bZ9a8sQmattOWQMp9bmRcI2VvS pOZe5fSMgtK5K/UI5kbYgHpD4Gj3V1NmFSombw3LvE7WA/5xlWyBrzD3IW3sSBUvXb6x L6aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from :dkim-signature; bh=hkhGcEhPR6UPrPlDGiGXc7Ka/ldbgk7SCCgn8nIuQ/w=; b=HfuDxZIRoDolIVls3InxMH9V6gImk9IqEphR31io/g//iGhUI50Qrf9slm5qYdqoJv DvuJoAsQx1p6IdT2oK26/tkKVOYJBBSWwTIokOkTimTLgkboL/jV5YTiigHUpWgnwSlK NBj73bxAgUnD3oEsfeLJKI24J3odgPLc/lZ+nWhtAE1ZzMtZFmTkRz5NDD1KuFGig8uh THfg6a3VC90V/MiNj/5VGSiXoAhQB9dTZCg1nEZYQb5EFGS6B4HSWlJLnZTrZa57Wx7d F6cKxGaFFIsbs5fBLaLhe81/Dmm/aZqZLVZd7SO/lK2nh7PEUguJ8rGqjm5cznTTh89x MLug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=dO3Y73RS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l6-20020a170902f68600b001ae5eb838easi5977310plg.292.2023.05.22.19.41.22; Mon, 22 May 2023 19:41:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=dO3Y73RS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234148AbjEWCiU (ORCPT + 99 others); Mon, 22 May 2023 22:38:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232332AbjEWCiS (ORCPT ); Mon, 22 May 2023 22:38:18 -0400 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8F16CA; Mon, 22 May 2023 19:38:16 -0700 (PDT) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 34N2bpBK020737; Mon, 22 May 2023 21:37:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1684809471; bh=hkhGcEhPR6UPrPlDGiGXc7Ka/ldbgk7SCCgn8nIuQ/w=; h=From:To:CC:Subject:Date; b=dO3Y73RSaVoMXz/rqUArHKOiuaKYOCbU+Y5ciJxtAdcrC1V0yFh/4Wq8QfQi0rUoF Y7JuBIedqMDOiwXSdcF5tuhZFyXnBmVjf2oJWuRRLcV51cEILu7AMcR028EAvEaCG8 kiU5/zqzXcxkhu9+vmWh09cuMVhhmu8FUnUIJ/IE= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 34N2bpMc032579 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 22 May 2023 21:37:51 -0500 Received: from DLEE107.ent.ti.com (157.170.170.37) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 22 May 2023 21:37:50 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 22 May 2023 21:37:50 -0500 Received: from a0498204.dal.design.ti.com (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 34N2bnsW031957; Mon, 22 May 2023 21:37:50 -0500 From: Judith Mendez To: Chandrasekar Ramakrishnan , CC: Wolfgang Grandegger , Marc Kleine-Budde , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , , , Schuyler Patton , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , Oliver Hartkopp , Tony Lindgren Subject: [PATCH v7 0/2] Enable multiple MCAN on AM62x Date: Mon, 22 May 2023 21:37:47 -0500 Message-ID: <20230523023749.4526-1-jm@ti.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766651010448837573?= X-GMAIL-MSGID: =?utf-8?q?1766651010448837573?= On AM62x there are two MCANs in MCU domain. The MCANs in MCU domain were not enabled since there is no hardware interrupt routed to A53 GIC interrupt controller. Therefore A53 Linux cannot be interrupted by MCU MCANs. This solution instantiates a hrtimer with 1 ms polling interval for MCAN device when there is no hardware interrupt property in DTB MCAN node. The hrtimer generates a recurring software interrupt which allows to call the isr. The isr will check if there is pending transaction by reading a register and proceed normally if there is. MCANs with hardware interrupt routed to A53 Linux will continue to use the hardware interrupt as expected. Timer polling method was tested on both classic CAN and CAN-FD at 125 KBPS, 250 KBPS, 1 MBPS and 2.5 MBPS with 4 MBPS bitrate switching. Letency and CPU load benchmarks were tested on 3x MCAN on AM62x. 1 MBPS timer polling interval is the better timer polling interval since it has comparable latency to hardware interrupt with the worse case being 1ms + CAN frame propagation time and CPU load is not substantial. Latency can be improved further with less than 1 ms polling intervals, howerver it is at the cost of CPU usage since CPU load increases at 0.5 ms. Note that in terms of power, enabling MCU MCANs with timer-polling implementation might have negative impact since we will have to wake up every 1 ms whether there are CAN packets pending in the RX FIFO or not. This might prevent the CPU from entering into deeper idle states for extended periods of time. v6: Link: https://lore.kernel.org/linux-can/20230518193613.15185-1-jm@ti.com/T/#t v5: Link: https://lore.kernel.org/linux-can/20230510202952.27111-1-jm@ti.com/T/#t v4: Link: https://lore.kernel.org/linux-can/c3395692-7dbf-19b2-bd3f-31ba86fa4ac9@linaro.org/T/#t v2: Link: https://lore.kernel.org/linux-can/20230424195402.516-1-jm@ti.com/T/#t V1: Link: https://lore.kernel.org/linux-can/19d8ae7f-7b74-a869-a818-93b74d106709@ti.com/T/#t RFC: Link: https://lore.kernel.org/linux-can/52a37e51-4143-9017-42ee-8d17c67028e3@ti.com/T/#t v6: - Clean up m_can_platform.c after removing poll-interval v6: - Move hrtimer stop/start function calls to m_can_open and m_can_close to support power suspend/resume v5: - Remove poll-interval in bindings - Change dev_dbg to dev_info if hardware int exists and polling is enabled v4: - Wrong patches sent v3: - Update binding poll-interval description - Add oneOf to select either interrupts/interrupt-names or poll-interval - Create a define for 1 ms polling interval - Change plarform_get_irq to optional to not print error msg v2: - Add poll-interval property to bindings and MCAN DTB node - Add functionality to check for 'poll-interval' property in MCAN node - Bindings: add an example using poll-interval - Add 'polling' flag in driver to check if device is using polling method - Check for timer polling and hardware interrupt cases, default to hardware interrupt method - Change ns_to_ktime() to ms_to_ktime() Judith Mendez (2): dt-bindings: net: can: Remove interrupt properties for MCAN can: m_can: Add hrtimer to generate software interrupt .../bindings/net/can/bosch,m_can.yaml | 20 +++++++++-- drivers/net/can/m_can/m_can.c | 33 +++++++++++++++++-- drivers/net/can/m_can/m_can.h | 4 +++ drivers/net/can/m_can/m_can_platform.c | 25 ++++++++++++-- 4 files changed, 75 insertions(+), 7 deletions(-) base-commit: 9f258af06b6268be8e960f63c3f66e88bdbbbdb0