mbox series

[v2,0/6] can: esd_usb: More preparation before supporting esd CAN-USB/3

Message ID 20230519195600.420644-1-frank.jungclaus@esd.eu
Headers
Series can: esd_usb: More preparation before supporting esd CAN-USB/3 |

Message

Frank Jungclaus May 19, 2023, 7:55 p.m. UTC 
  Apply another small batch of patches as preparation for adding support
of the newly available esd CAN-USB/3 to esd_usb.c.
---
* Changelog *

v1 -> v2:
* Make use of GENMASK() macro for ESD_USB_NO_BAUDRATE and
  ESD_USB_IDMASK
* Also use the BIT() macro for ESD_USB2_3_SAMPLES
* Removed comments with redundant hexadecimal values from
  BIT()-constants
* Reworded (shortened) the commit messages
* Changed the macro ESD_USB_3_SAMPLES to ESD_USB_TRIPLE_SAMPLES

v1:
* Link: https://lore.kernel.org/all/20230517192251.2405290-1-frank.jungclaus@esd.eu/

Frank Jungclaus (6):
  can: esd_usb: Make use of existing kernel macros
  can: esd_usb: Replace initializer macros used for struct
    can_bittiming_const
  can: esd_usb: Use consistent prefixes for macros
  can: esd_usb: Prefix all structures with the device name
  can: esd_usb: Replace hardcoded message length given to USB commands
  can: esd_usb: Don't bother the user with nonessential log message

 drivers/net/can/usb/esd_usb.c | 339 +++++++++++++++++-----------------
 1 file changed, 168 insertions(+), 171 deletions(-)


base-commit: 833e24aeb4d9a4803af3b836464df01293ce9041

Comments

Vincent Mailhol May 21, 2023, 9:20 a.m. UTC | #1 
Hi Frank,

On Sat. 20 mai 2023 à 04:57, Frank Jungclaus <frank.jungclaus@esd.eu> wrote:
> Apply another small batch of patches as preparation for adding support
> of the newly available esd CAN-USB/3 to esd_usb.c.
> ---

I sent two nitpicks but aside from that the series looks good. Thank
you for taking time to clean-up the existing code before introducing
the new changes.

I do not think I will need to review the v3, so in advance:

Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>