mbox series

[V4,0/6] Add PCIe support for IPQ9574

Message ID 20230519090219.15925-1-quic_devipriy@quicinc.com
Headers
Series Add PCIe support for IPQ9574 |

Message

Devi Priya May 19, 2023, 9:02 a.m. UTC 
  This series adds support for enabling the PCIe host devices (PCIe0, PCIe1,
PCIe2, PCIe3) found on IPQ9574 platform.
The PCIe0 & PCIe1 are 1-lane Gen3 host and PCIe2 & PCIe3 
are 2-lane Gen3 host.

DTS patch is based on the below series
https://lore.kernel.org/linux-arm-msm/20230517172527.1968-1-quic_devipriy@quicinc.com/

Changes in V4:
	- Rebased on the below series
https://lore.kernel.org/linux-arm-msm/20230517172527.1968-1-quic_devipriy@quicinc.com/
	- Change logs are added to the respective patches.

[V3]
https://lore.kernel.org/linux-arm-msm/20230421124938.21974-1-quic_devipriy@quicinc.com/
	- Dropped the phy driver and binding patches as they have been 
	  posted as a separate series.
	- Dropped the pinctrl binding fix patch as it is unrelated to the series
	  dt-bindings: pinctrl: qcom: Add few missing functions.
	- Rebased on linux-next/master.
	- Detailed change logs are added to the respective patches.
	
[V2]
https://lore.kernel.org/linux-arm-msm/20230404164828.8031-1-quic_devipriy@quicinc.com/
	- Reordered the patches and splitted the board DT changes
	  into a separate patch as suggested
	- Detailed change logs are added to the respective patches

[V1]
https://lore.kernel.org/linux-arm-msm/20230214164135.17039-1-quic_devipriy@quicinc.com/

Devi Priya (6):
  dt-bindings: clock: Add PCIe pipe clock definitions
  clk: qcom: gcc-ipq9574: Add PCIe pipe clocks
  dt-bindings: PCI: qcom: Add IPQ9574
  arm64: dts: qcom: ipq9574: Add PCIe PHYs and controller nodes
  arm64: dts: qcom: ipq9574: Enable PCIe PHYs and controllers
  PCI: qcom: Add support for IPQ9574

 .../devicetree/bindings/pci/qcom,pcie.yaml    |  48 +++
 arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts   | 113 ++++++
 arch/arm64/boot/dts/qcom/ipq9574.dtsi         | 365 ++++++++++++++++++
 drivers/clk/qcom/gcc-ipq9574.c                |  76 ++++
 drivers/pci/controller/dwc/pcie-qcom.c        |  57 ++-
 include/dt-bindings/clock/qcom,ipq9574-gcc.h  |   4 +
 6 files changed, 645 insertions(+), 18 deletions(-)

Comments

Lorenzo Pieralisi May 22, 2023, 9:22 a.m. UTC | #1 
On Fri, May 19, 2023 at 02:32:13PM +0530, Devi Priya wrote:
> This series adds support for enabling the PCIe host devices (PCIe0, PCIe1,
> PCIe2, PCIe3) found on IPQ9574 platform.
> The PCIe0 & PCIe1 are 1-lane Gen3 host and PCIe2 & PCIe3 
> are 2-lane Gen3 host.
> 
> DTS patch is based on the below series
> https://lore.kernel.org/linux-arm-msm/20230517172527.1968-1-quic_devipriy@quicinc.com/
> 
> Changes in V4:
> 	- Rebased on the below series
> https://lore.kernel.org/linux-arm-msm/20230517172527.1968-1-quic_devipriy@quicinc.com/
> 	- Change logs are added to the respective patches.

Mani, all,

can I pick up patches 3 and 6 from this series ?

Lorenzo

> [V3]
> https://lore.kernel.org/linux-arm-msm/20230421124938.21974-1-quic_devipriy@quicinc.com/
> 	- Dropped the phy driver and binding patches as they have been 
> 	  posted as a separate series.
> 	- Dropped the pinctrl binding fix patch as it is unrelated to the series
> 	  dt-bindings: pinctrl: qcom: Add few missing functions.
> 	- Rebased on linux-next/master.
> 	- Detailed change logs are added to the respective patches.
> 	
> [V2]
> https://lore.kernel.org/linux-arm-msm/20230404164828.8031-1-quic_devipriy@quicinc.com/
> 	- Reordered the patches and splitted the board DT changes
> 	  into a separate patch as suggested
> 	- Detailed change logs are added to the respective patches
> 
> [V1]
> https://lore.kernel.org/linux-arm-msm/20230214164135.17039-1-quic_devipriy@quicinc.com/
> 
> Devi Priya (6):
>   dt-bindings: clock: Add PCIe pipe clock definitions
>   clk: qcom: gcc-ipq9574: Add PCIe pipe clocks
>   dt-bindings: PCI: qcom: Add IPQ9574
>   arm64: dts: qcom: ipq9574: Add PCIe PHYs and controller nodes
>   arm64: dts: qcom: ipq9574: Enable PCIe PHYs and controllers
>   PCI: qcom: Add support for IPQ9574
> 
>  .../devicetree/bindings/pci/qcom,pcie.yaml    |  48 +++
>  arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts   | 113 ++++++
>  arch/arm64/boot/dts/qcom/ipq9574.dtsi         | 365 ++++++++++++++++++
>  drivers/clk/qcom/gcc-ipq9574.c                |  76 ++++
>  drivers/pci/controller/dwc/pcie-qcom.c        |  57 ++-
>  include/dt-bindings/clock/qcom,ipq9574-gcc.h  |   4 +
>  6 files changed, 645 insertions(+), 18 deletions(-)
> 
> -- 
> 2.17.1
>
Manivannan Sadhasivam May 28, 2023, 2:21 p.m. UTC | #2 
On Mon, May 22, 2023 at 11:22:12AM +0200, Lorenzo Pieralisi wrote:
> On Fri, May 19, 2023 at 02:32:13PM +0530, Devi Priya wrote:
> > This series adds support for enabling the PCIe host devices (PCIe0, PCIe1,
> > PCIe2, PCIe3) found on IPQ9574 platform.
> > The PCIe0 & PCIe1 are 1-lane Gen3 host and PCIe2 & PCIe3 
> > are 2-lane Gen3 host.
> > 
> > DTS patch is based on the below series
> > https://lore.kernel.org/linux-arm-msm/20230517172527.1968-1-quic_devipriy@quicinc.com/
> > 
> > Changes in V4:
> > 	- Rebased on the below series
> > https://lore.kernel.org/linux-arm-msm/20230517172527.1968-1-quic_devipriy@quicinc.com/
> > 	- Change logs are added to the respective patches.
> 
> Mani, all,
> 
> can I pick up patches 3 and 6 from this series ?
> 

Patch 3 needs to be reviewed by the DT maintainer and I have a comment too. So
this series should be put on hold until then.

- Mani

> Lorenzo
> 
> > [V3]
> > https://lore.kernel.org/linux-arm-msm/20230421124938.21974-1-quic_devipriy@quicinc.com/
> > 	- Dropped the phy driver and binding patches as they have been 
> > 	  posted as a separate series.
> > 	- Dropped the pinctrl binding fix patch as it is unrelated to the series
> > 	  dt-bindings: pinctrl: qcom: Add few missing functions.
> > 	- Rebased on linux-next/master.
> > 	- Detailed change logs are added to the respective patches.
> > 	
> > [V2]
> > https://lore.kernel.org/linux-arm-msm/20230404164828.8031-1-quic_devipriy@quicinc.com/
> > 	- Reordered the patches and splitted the board DT changes
> > 	  into a separate patch as suggested
> > 	- Detailed change logs are added to the respective patches
> > 
> > [V1]
> > https://lore.kernel.org/linux-arm-msm/20230214164135.17039-1-quic_devipriy@quicinc.com/
> > 
> > Devi Priya (6):
> >   dt-bindings: clock: Add PCIe pipe clock definitions
> >   clk: qcom: gcc-ipq9574: Add PCIe pipe clocks
> >   dt-bindings: PCI: qcom: Add IPQ9574
> >   arm64: dts: qcom: ipq9574: Add PCIe PHYs and controller nodes
> >   arm64: dts: qcom: ipq9574: Enable PCIe PHYs and controllers
> >   PCI: qcom: Add support for IPQ9574
> > 
> >  .../devicetree/bindings/pci/qcom,pcie.yaml    |  48 +++
> >  arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts   | 113 ++++++
> >  arch/arm64/boot/dts/qcom/ipq9574.dtsi         | 365 ++++++++++++++++++
> >  drivers/clk/qcom/gcc-ipq9574.c                |  76 ++++
> >  drivers/pci/controller/dwc/pcie-qcom.c        |  57 ++-
> >  include/dt-bindings/clock/qcom,ipq9574-gcc.h  |   4 +
> >  6 files changed, 645 insertions(+), 18 deletions(-)
> > 
> > -- 
> > 2.17.1
> >