[v4,0/4] Add JH7110 AON PMU support

Message ID 20230519060202.15296-1-changhuang.liang@starfivetech.com
Headers
Series Add JH7110 AON PMU support |

Message

Changhuang Liang May 19, 2023, 6:01 a.m. UTC
  This patchset adds aon power domain driver for the StarFive JH7110 SoC.
It is used to turn on/off dphy rx/tx power switch. It also can use syscon
operation. The series has been tested on the VisionFive 2 board.

This patchset should be applied after the patchset [1]:
[1] https://lore.kernel.org/all/20230512022036.97987-1-xingyu.wu@starfivetech.com/

changes since v3:
- Rebased on tag v6.4-rc1.
- Dropped the contents changed by the yaml in patch 1.
- Dropped patch 5: Add AON PMU node.

v3: https://lore.kernel.org/all/20230510015311.27505-1-changhuang.liang@starfivetech.com/

changes since v2:
- Updated commit message.
- Changed "starfive,jh7110-aon-pmu" to "starfive,jh7110-aon-syscon".
- Dropped patch 3: Modify ioremap to regmap.
- Changed "pmu_parse_dt" to "pmu_parse_irq".
- Dropped "pmu_parse_dt" function in aon pmu.
- Changed copyright to "2022-2023" in "starfive,jh7110-pmu.h".
- Replaced regread/regwrite operation with io_read/io_write operation.

v2: https://lore.kernel.org/all/20230419035646.43702-1-changhuang.liang@starfivetech.com/

changes since v1:
- Updated commit message.
- Changed "starfive,jh7110-pmu-dphy" to "starfive,jh7110-aon-pmu".
- Put if condition under allOf in .yaml file.
- Updated spelling error.
- Dropped patch 4: Add pmu type operation.
- Changed "jh71xx_pmu_general_set_state" to "jh7110_pmu_set_state" and moved it in call back.
- Changed "jh7110_pmu_general_parse_dt" to "jh7110_pmu_parse_dt" and moved it in call back.
- Used pmu_status save the pmu status offset.
- Changed "JH71XX_PMU_DPHY_SWITCH" to "JH71XX_AON_PMU_SWITCH"
- Changed copyright to "2022-2023"

v1: https://lore.kernel.org/all/20230411064743.273388-1-changhuang.liang@starfivetech.com/

Changhuang Liang (4):
  dt-bindings: power: Add power-domain header for JH7110
  soc: starfive: Replace SOC_STARFIVE with ARCH_STARFIVE
  soc: starfive: Extract JH7110 pmu private operations
  soc: starfive: Add JH7110 AON PMU support

 MAINTAINERS                                   |   1 +
 drivers/soc/starfive/Kconfig                  |   4 +-
 drivers/soc/starfive/jh71xx_pmu.c             | 138 ++++++++++++++----
 .../dt-bindings/power/starfive,jh7110-pmu.h   |   5 +-
 4 files changed, 117 insertions(+), 31 deletions(-)


base-commit: ac9a78681b921877518763ba0e89202254349d1b
--
2.25.1
  

Comments

Changhuang Liang July 20, 2023, 3:46 a.m. UTC | #1
On 2023/5/19 14:01, Changhuang Liang wrote:
> This patchset adds aon power domain driver for the StarFive JH7110 SoC.
> It is used to turn on/off dphy rx/tx power switch. It also can use syscon
> operation. The series has been tested on the VisionFive 2 board.
> 
> This patchset should be applied after the patchset [1]:
> [1] https://lore.kernel.org/all/20230512022036.97987-1-xingyu.wu@starfivetech.com/
> 

Hi, Conor

Pll series is accepted, should I need to send a new version about this series?

Best regards,
Changhuang
  
Conor Dooley July 20, 2023, 6:48 a.m. UTC | #2
On Thu, Jul 20, 2023 at 11:46:27AM +0800, Changhuang Liang wrote:
> On 2023/5/19 14:01, Changhuang Liang wrote:
> > This patchset adds aon power domain driver for the StarFive JH7110 SoC.
> > It is used to turn on/off dphy rx/tx power switch. It also can use syscon
> > operation. The series has been tested on the VisionFive 2 board.
> > 
> > This patchset should be applied after the patchset [1]:
> > [1] https://lore.kernel.org/all/20230512022036.97987-1-xingyu.wu@starfivetech.com/
 
> Pll series is accepted, should I need to send a new version about this series?

I don't think so, there were no changes requested here. Let me check.
  
Conor Dooley July 20, 2023, 5:12 p.m. UTC | #3
From: Conor Dooley <conor.dooley@microchip.com>

On Thu, 18 May 2023 23:01:58 -0700, Changhuang Liang wrote:
> This patchset adds aon power domain driver for the StarFive JH7110 SoC.
> It is used to turn on/off dphy rx/tx power switch. It also can use syscon
> operation. The series has been tested on the VisionFive 2 board.
> 
> This patchset should be applied after the patchset [1]:
> [1] https://lore.kernel.org/all/20230512022036.97987-1-xingyu.wu@starfivetech.com/
> 
> [...]

Applied to riscv-soc-for-next, thanks!

[1/4] dt-bindings: power: Add power-domain header for JH7110
      https://git.kernel.org/conor/c/2b8f8c6e797c
[2/4] soc: starfive: Replace SOC_STARFIVE with ARCH_STARFIVE
      https://git.kernel.org/conor/c/36393facfabf
[3/4] soc: starfive: Extract JH7110 pmu private operations
      https://git.kernel.org/conor/c/bd0c0d3dae34
[4/4] soc: starfive: Add JH7110 AON PMU support
      https://git.kernel.org/conor/c/30fb4784483b

I expect I'll get an email tomorrow from SFR pointing out some conflicts
with the new genpd stuff. I think the plan is for Arnd to sort those
things out prior to the next merge window.

Thanks,
Conor.
  
Changhuang Liang July 21, 2023, 3:01 a.m. UTC | #4
On 2023/7/21 1:12, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> On Thu, 18 May 2023 23:01:58 -0700, Changhuang Liang wrote:
>> This patchset adds aon power domain driver for the StarFive JH7110 SoC.
>> It is used to turn on/off dphy rx/tx power switch. It also can use syscon
>> operation. The series has been tested on the VisionFive 2 board.
>>
>> This patchset should be applied after the patchset [1]:
>> [1] https://lore.kernel.org/all/20230512022036.97987-1-xingyu.wu@starfivetech.com/
>>
>> [...]
> 
> Applied to riscv-soc-for-next, thanks!
> 
> [1/4] dt-bindings: power: Add power-domain header for JH7110
>       https://git.kernel.org/conor/c/2b8f8c6e797c
> [2/4] soc: starfive: Replace SOC_STARFIVE with ARCH_STARFIVE
>       https://git.kernel.org/conor/c/36393facfabf
> [3/4] soc: starfive: Extract JH7110 pmu private operations
>       https://git.kernel.org/conor/c/bd0c0d3dae34
> [4/4] soc: starfive: Add JH7110 AON PMU support
>       https://git.kernel.org/conor/c/30fb4784483b
> 
> I expect I'll get an email tomorrow from SFR pointing out some conflicts
> with the new genpd stuff. I think the plan is for Arnd to sort those
> things out prior to the next merge window.
> 

Thank you all!