Message ID | 20230516231713.2882879-1-florian.fainelli@broadcom.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp757834vqo; Tue, 16 May 2023 16:19:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6WlXdvTclMkWABELbXdYpbFY3+xKoaufVJFW/pwnSq9cVrmkVUDtUDIyLhfgnIx4iT2aN0 X-Received: by 2002:a05:6a00:228e:b0:643:b330:4b78 with SMTP id f14-20020a056a00228e00b00643b3304b78mr52323313pfe.14.1684279183341; Tue, 16 May 2023 16:19:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684279183; cv=none; d=google.com; s=arc-20160816; b=ElIhnd0rv7arW8qYyWxsKOW8vnMpQl3V8hFKOTF3zFMbI/oNClpClUeQyZbfKjJYp2 3OGrURWqhveKsn0GJyWLglgloJ4brvV0YLom+IiZ1IYQp6HPV2D5/hs9f0ECxcxa+0w6 BqaXK29Z7inFo5luTLCoGTMxVYiyOFtn4uJWr6i1/vIBIdoTzHK/fYR+exffDiHODG7J va8KT021G0oQNxSBZbVW+ixo8qiViCcNokzxJqTfd2g6cBPDzLSokjcDyPd4fD3NGuaM AMjgqAkEVkPlM7H3Q1nykrTOh3J7bhH3T0Y01yBBCtUAQ+tmzXOiLPbzSncDSsoS5nyB Q9Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from :dkim-signature; bh=eTpBn23vcjve8G08XVjCHY4GXuZt06y6RVhsJ8JMX9U=; b=XJw9W2SnrMRvswAL20xik+fK2Z9Si25HQUQhIcMytMqKhm2SHXc8EohQjAQSli+NZI QQr+yn6kCrTMbFD1eNKzEBh5K15fdoFdS9eb28o6GK9TvGXB3c1FK1/WP7gmDo/wQQ4z DDyjTMvB54HivAEBRWVa+vcnnu6SWbMCgY9nf6I/yZ5ejSAimL7zxOFfb5htuPY8Y4ou G2wUT3fiI9UE65AZrQffmg7GgvGSvub1ojsZdXt4PtP/HfZseHGygr52umSi3Ij9OVzE lfeZT+vqZB4CHWtj3KnRvW0F//54G7xsAL3Rn7CxXmfokcUBYSPwl8obWxuOFNnXHQiM s7ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=FLh2NEiN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c186-20020a621cc3000000b0063b88d7c754si20615602pfc.210.2023.05.16.16.19.30; Tue, 16 May 2023 16:19:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=FLh2NEiN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229862AbjEPXRX (ORCPT <rfc822;peekingduck44@gmail.com> + 99 others); Tue, 16 May 2023 19:17:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231345AbjEPXRT (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 16 May 2023 19:17:19 -0400 Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EAC376BE for <linux-kernel@vger.kernel.org>; Tue, 16 May 2023 16:17:18 -0700 (PDT) Received: by mail-qv1-xf2f.google.com with SMTP id 6a1803df08f44-61b40562054so702416d6.2 for <linux-kernel@vger.kernel.org>; Tue, 16 May 2023 16:17:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1684279037; x=1686871037; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=eTpBn23vcjve8G08XVjCHY4GXuZt06y6RVhsJ8JMX9U=; b=FLh2NEiN9QNcdiyVKTAWkAoNC4XFKMfFRMIp/dPADD+t83CgTEbSoSzZ1I+pvBh9wC 8v8gj5Y8L8HluUXo8UYS8Ua+arqIvpKE2doy4Vqej+emZlvnJRiJBLTFvHK8p2KrQOKk yTlkumjBAnkfoh01UE4UAQrLR+wbuWroRvgbg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684279037; x=1686871037; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=eTpBn23vcjve8G08XVjCHY4GXuZt06y6RVhsJ8JMX9U=; b=FSpV+vUjMbjJ2YT7jj1iImXpqVD61qZZl2h0oCSwghHTj57Ht3kWQP26NxBFeeibWV zXO+bFzUdG5LRbqLmXUu2X2L05WBLDO/FC6N4XqLceraJ51EpprEpskIAquXzyvar1rF nhtGGfjCu1H3o1PUKIrqzjyDZh/qAi4NqugcEFy2xXjxWNgLvUNlz3My2C10CH6T6IZb 4kNZdTF3UU0kwzlz7CrxnZT2yvkf62fsZPFWSoK1yp7/c4gYIn/UMN7LbRi2Gv706dRh kFg2jS7QvhrSgAhglxCHpMROMTLFtioWEXcq6jUfa3XuTf+s6Ry7p0ddWhqmEkqro239 rT3Q== X-Gm-Message-State: AC+VfDwH6Skp9rEqYnRpqQEhJHiPNXP3Y58V9XbSg+YJkJ3mXF89uEbq B24deWm8IemQTD0V9e7+BpC6GiLdav6mU4Whmf4= X-Received: by 2002:a05:6214:2501:b0:5f4:357c:3bf5 with SMTP id gf1-20020a056214250100b005f4357c3bf5mr70621371qvb.13.1684279037115; Tue, 16 May 2023 16:17:17 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id g17-20020a0cf851000000b0061b7784b3basm5495427qvo.84.2023.05.16.16.17.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 May 2023 16:17:16 -0700 (PDT) From: Florian Fainelli <florian.fainelli@broadcom.com> To: netdev@vger.kernel.org Cc: Florian Fainelli <florian.fainelli@broadcom.com>, Doug Berger <opendmb@gmail.com>, Florian Fainelli <f.fainelli@gmail.com>, Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>, Russell King <linux@armlinux.org.uk>, linux-kernel@vger.kernel.org (open list) Subject: [PATCH net-next 0/3] WAKE_FILTER for Broadcom PHY Date: Tue, 16 May 2023 16:17:10 -0700 Message-Id: <20230516231713.2882879-1-florian.fainelli@broadcom.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000ba680b05fbd7c5ec" X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MIME_NO_TEXT, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766094728574386846?= X-GMAIL-MSGID: =?utf-8?q?1766094728574386846?= |
Series | WAKE_FILTER for Broadcom PHY | |
Message
Florian Fainelli
May 16, 2023, 11:17 p.m. UTC
This patch series adds support for WAKE_FILTER to the Broadcom PHY with the narrow use case of being able to program a custom Ethernet MAC DA to be waking up from. This is currently useful for Set-top-box applications where we might want to wake-up from select multicast MAC DA pertaining to mDNS for instance (Wake-on-Cast typically). The approach taken here is the same as what has been pioneered and proposed before for the GENET and SYSTEMPORT drivers. Thanks! Florian Fainelli (3): net: phy: Add pluming for ethtool_{get,set}_rxnfc net: phy: broadcom: Add support for WAKE_FILTER net: bcmgenet: Interrogate PHY for WAKE_FILTER programming .../net/ethernet/broadcom/genet/bcmgenet.c | 12 ++ drivers/net/phy/bcm-phy-lib.c | 147 +++++++++++++++++- drivers/net/phy/bcm-phy-lib.h | 6 + drivers/net/phy/broadcom.c | 15 ++ drivers/net/phy/phy.c | 19 +++ include/linux/phy.h | 8 + 6 files changed, 206 insertions(+), 1 deletion(-)
Comments
On Tue, May 16, 2023 at 04:17:10PM -0700, Florian Fainelli wrote: > This patch series adds support for WAKE_FILTER to the Broadcom PHY with > the narrow use case of being able to program a custom Ethernet MAC DA to > be waking up from. > > This is currently useful for Set-top-box applications where we might > want to wake-up from select multicast MAC DA pertaining to mDNS for > instance (Wake-on-Cast typically). > > The approach taken here is the same as what has been pioneered and > proposed before for the GENET and SYSTEMPORT drivers. > > Thanks! Hi Florian, I hate to be a pain. But this series doesn't apply on net-next. -- pw-bot: cr
On 5/17/2023 2:24 AM, Simon Horman wrote: > On Tue, May 16, 2023 at 04:17:10PM -0700, Florian Fainelli wrote: >> This patch series adds support for WAKE_FILTER to the Broadcom PHY with >> the narrow use case of being able to program a custom Ethernet MAC DA to >> be waking up from. >> >> This is currently useful for Set-top-box applications where we might >> want to wake-up from select multicast MAC DA pertaining to mDNS for >> instance (Wake-on-Cast typically). >> >> The approach taken here is the same as what has been pioneered and >> proposed before for the GENET and SYSTEMPORT drivers. >> >> Thanks! > > Hi Florian, > > I hate to be a pain. > But this series doesn't apply on net-next. Right, that's because it depends upon "[PATCH net-next] net: phy: broadcom: Register dummy IRQ handler". I did not make that clear in the cover letter but definitively should have.
On Wed, May 17, 2023 at 08:18:25AM -0700, Florian Fainelli wrote: > > > On 5/17/2023 2:24 AM, Simon Horman wrote: > > On Tue, May 16, 2023 at 04:17:10PM -0700, Florian Fainelli wrote: > > > This patch series adds support for WAKE_FILTER to the Broadcom PHY with > > > the narrow use case of being able to program a custom Ethernet MAC DA to > > > be waking up from. > > > > > > This is currently useful for Set-top-box applications where we might > > > want to wake-up from select multicast MAC DA pertaining to mDNS for > > > instance (Wake-on-Cast typically). > > > > > > The approach taken here is the same as what has been pioneered and > > > proposed before for the GENET and SYSTEMPORT drivers. > > > > > > Thanks! > > > > Hi Florian, > > > > I hate to be a pain. > > But this series doesn't apply on net-next. > > Right, that's because it depends upon "[PATCH net-next] net: phy: broadcom: > Register dummy IRQ handler". I did not make that clear in the cover letter > but definitively should have. Thanks Florian, got it. Of course review can occur within that context. But perhaps it is best to repost once those patches are in, so the CI can run.