mbox series

[-next,v2,0/6] blk-wbt: minor fix and cleanup

Message ID 20230512093554.911753-1-yukuai1@huaweicloud.com
Headers
Series blk-wbt: minor fix and cleanup |

Message

Yu Kuai May 12, 2023, 9:35 a.m. UTC 
  From: Yu Kuai <yukuai3@huawei.com>

Changes in v2:
 - make the code more readable for patch 1
 - add a new attr_group that is only visible for rq based device
 - explain in detail for patch 4
 - add review tag for patch 2,3,5

Yu Kuai (6):
  blk-wbt: fix that wbt can't be disabled by default
  blk-wbt: don't create wbt sysfs entry if CONFIG_BLK_WBT is disabled
  blk-wbt: remove dead code to handle wbt enable/disable with io
    inflight
  blk-wbt: cleanup rwb_enabled() and wbt_disabled()
  blk-iocost: move wbt_enable/disable_default() out of spinlock
  blk-sysfs: add a new attr_group for blk_mq

 block/blk-iocost.c |   7 +-
 block/blk-sysfs.c  | 181 ++++++++++++++++++++++++++-------------------
 block/blk-wbt.c    |  33 +++------
 block/blk-wbt.h    |  19 -----
 4 files changed, 117 insertions(+), 123 deletions(-)

Comments

Jens Axboe May 12, 2023, 2:58 p.m. UTC | #1 
On 5/12/23 3:35 AM, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
> 
> Changes in v2:
>  - make the code more readable for patch 1
>  - add a new attr_group that is only visible for rq based device
>  - explain in detail for patch 4
>  - add review tag for patch 2,3,5
> 
> Yu Kuai (6):
>   blk-wbt: fix that wbt can't be disabled by default
>   blk-wbt: don't create wbt sysfs entry if CONFIG_BLK_WBT is disabled
>   blk-wbt: remove dead code to handle wbt enable/disable with io
>     inflight
>   blk-wbt: cleanup rwb_enabled() and wbt_disabled()
>   blk-iocost: move wbt_enable/disable_default() out of spinlock
>   blk-sysfs: add a new attr_group for blk_mq
> 
>  block/blk-iocost.c |   7 +-
>  block/blk-sysfs.c  | 181 ++++++++++++++++++++++++++-------------------
>  block/blk-wbt.c    |  33 +++------
>  block/blk-wbt.h    |  19 -----
>  4 files changed, 117 insertions(+), 123 deletions(-)

We need a 6.4 version of the fix to get rid of the regression. If you
want to do cleanups on top of that, then that's fine and that can go into
6.5. But don't mix them up.
Linux regression tracking (Thorsten Leemhuis) May 22, 2023, noon UTC | #2 
On 12.05.23 16:58, Jens Axboe wrote:
> On 5/12/23 3:35 AM, Yu Kuai wrote:
>> From: Yu Kuai <yukuai3@huawei.com>
>>
>> Changes in v2:
>>  - make the code more readable for patch 1
>>  - add a new attr_group that is only visible for rq based device
>>  - explain in detail for patch 4
>>  - add review tag for patch 2,3,5
>>
>> Yu Kuai (6):
>>   blk-wbt: fix that wbt can't be disabled by default
>>   blk-wbt: don't create wbt sysfs entry if CONFIG_BLK_WBT is disabled
>>   blk-wbt: remove dead code to handle wbt enable/disable with io
>>     inflight
>>   blk-wbt: cleanup rwb_enabled() and wbt_disabled()
>>   blk-iocost: move wbt_enable/disable_default() out of spinlock
>>   blk-sysfs: add a new attr_group for blk_mq
>>
>>  block/blk-iocost.c |   7 +-
>>  block/blk-sysfs.c  | 181 ++++++++++++++++++++++++++-------------------
>>  block/blk-wbt.c    |  33 +++------
>>  block/blk-wbt.h    |  19 -----
>>  4 files changed, 117 insertions(+), 123 deletions(-)
> 
> We need a 6.4 version of the fix to get rid of the regression. If you
> want to do cleanups on top of that, then that's fine and that can go into
> 6.5. But don't mix them up.

Hmm, it seems nothing has happened here since ten days to fix this
regression that likely is still present in 6.3. Yu Kuai, did it fall
through the cracks, or is what Jens asked for more complicated than it
sounds?

Or was progress made and I just missed it?

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

#regzbot poke
Yu Kuai May 22, 2023, 12:12 p.m. UTC | #3 
Hi,

在 2023/05/22 20:00, Linux regression tracking (Thorsten Leemhuis) 写道:
> On 12.05.23 16:58, Jens Axboe wrote:
>> On 5/12/23 3:35 AM, Yu Kuai wrote:
>>> From: Yu Kuai <yukuai3@huawei.com>
>>>
>>> Changes in v2:
>>>   - make the code more readable for patch 1
>>>   - add a new attr_group that is only visible for rq based device
>>>   - explain in detail for patch 4
>>>   - add review tag for patch 2,3,5
>>>
>>> Yu Kuai (6):
>>>    blk-wbt: fix that wbt can't be disabled by default
>>>    blk-wbt: don't create wbt sysfs entry if CONFIG_BLK_WBT is disabled
>>>    blk-wbt: remove dead code to handle wbt enable/disable with io
>>>      inflight
>>>    blk-wbt: cleanup rwb_enabled() and wbt_disabled()
>>>    blk-iocost: move wbt_enable/disable_default() out of spinlock
>>>    blk-sysfs: add a new attr_group for blk_mq
>>>
>>>   block/blk-iocost.c |   7 +-
>>>   block/blk-sysfs.c  | 181 ++++++++++++++++++++++++++-------------------
>>>   block/blk-wbt.c    |  33 +++------
>>>   block/blk-wbt.h    |  19 -----
>>>   4 files changed, 117 insertions(+), 123 deletions(-)
>>
>> We need a 6.4 version of the fix to get rid of the regression. If you
>> want to do cleanups on top of that, then that's fine and that can go into
>> 6.5. But don't mix them up.
> 
> Hmm, it seems nothing has happened here since ten days to fix this
> regression that likely is still present in 6.3. Yu Kuai, did it fall
> through the cracks, or is what Jens asked for more complicated than it
> sounds?

Sorry for the delay, I was waiting for the last patch to be reviewed.
But the regression is only related to the first patch, I'll send it
seperately.

Thanks,
Kuai
> 
> Or was progress made and I just missed it?
> 
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.
> 
> #regzbot poke
> 
> .
>