From patchwork Thu May 11 01:12:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yunsheng Lin X-Patchwork-Id: 9176 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp4037350vqo; Wed, 10 May 2023 18:26:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6uMjRMnTucSqgb5IZ5azhz5CYnEwO/wwR8Vs7seYkLMO2is5bOmWxPWz8yfbwhO8cv0jiT X-Received: by 2002:a17:902:d512:b0:1ab:723:1acc with SMTP id b18-20020a170902d51200b001ab07231accmr24440174plg.35.1683768399654; Wed, 10 May 2023 18:26:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683768399; cv=none; d=google.com; s=arc-20160816; b=Owrp+hDURTF2FWsjD5wegyCPsTF472vVGXYpjmgfO3vSAiO+bokCFSbERXv1T96lpT B3AsteBGhUifrIYQXLnABFuGZ+Bd46DZPcr0GyWMPBPxqINfL6RUV+No5i8d0m2eeWVg 0g/UfWn3Em3ImATFpOsby5dJu7jV0TSa5IpQrdbJRcVfGzaZFZu8UaHvbr7j9upuVhPV 0yPMsNApwEOHcmrDFAISoIDWupMLPaSAzXsI/9Rwh6Y4xmlDVera1ySdIraauQAu+AEs 4/XrfC2VYrNVNeeLXy3ZtVHf/mYQC5GFwufJFXYV+RvHI1oElKrYOO49j4VEZAtp2gkn OZSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=HptjDTAjR7EmZ3ym6LVrpEno5no6iIXvMK3Di/y0ciQ=; b=wmP4NTAuB9ZhpI+y3ImXLwqF82OOc+a/N6Gc8M7Ye75oex+EPUsQtZwkwJdPYVPDZF MBq/k0z00wID4C+LIFdhuszqs4lHDJPzxwPRhEI+z3Ake2d2o6UJ0vS3qWiMAKWISc9o im2LhcdE0RtsPPlH1tZj4Dogzz30hz2Q3pAlrPye3P+4Yz8oe1QD/nTnSY3eMx88RWO5 0OOOvkkoQjjNU31A6f6J80wfN5KOEQsascgu6Wn8aNutb1SnP154V0p67VmLCna+j0FR fXi+Et19KoptM9cpHIe3C3/rxILo9R3ZkbYuSyIEhH11+RBlYCciMidsJIHC+SNVqnaJ ZjFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h21-20020a170902f7d500b0019ca7d69673si5203671plw.196.2023.05.10.18.26.27; Wed, 10 May 2023 18:26:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236172AbjEKBOv (ORCPT + 99 others); Wed, 10 May 2023 21:14:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236082AbjEKBOr (ORCPT ); Wed, 10 May 2023 21:14:47 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91FF5E70; Wed, 10 May 2023 18:14:45 -0700 (PDT) Received: from dggpemm500005.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QGv4S3XMqzLpmy; Thu, 11 May 2023 09:11:52 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 11 May 2023 09:14:42 +0800 From: Yunsheng Lin To: , , CC: , , Yunsheng Lin , Subject: [PATCH net-next v2 0/2] introduce skb_frag_fill_page_desc() Date: Thu, 11 May 2023 09:12:11 +0800 Message-ID: <20230511011213.59091-1-linyunsheng@huawei.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 X-Originating-IP: [10.69.192.56] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500005.china.huawei.com (7.185.36.74) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765559133508841941?= X-GMAIL-MSGID: =?utf-8?q?1765559133508841941?= Most users use __skb_frag_set_page()/skb_frag_off_set()/ skb_frag_size_set() to fill the page desc for a skb frag. It does not make much sense to calling __skb_frag_set_page() without calling skb_frag_off_set(), as the offset may depend on whether the page is head page or tail page, so add skb_frag_fill_page_desc() to fill the page desc for a skb frag. In the future, we can make sure the page in the frag is head page of compound page or a base page, if not, we may warn about that and convert the tail page to head page and update the offset accordingly, if we see a warning about that, we also fix the caller to fill the head page in the frag. when the fixing is done, we may remove the warning and converting. In this way, we can remove the compound_head() or use page_ref_*() like the below case: https://elixir.bootlin.com/linux/latest/source/net/core/page_pool.c#L881 https://elixir.bootlin.com/linux/latest/source/include/linux/skbuff.h#L3383 It may also convert net stack to use the folio easier. V1: repost with all the ack/review tags included. RFC: remove a local variable as pointed out by Simon. Yunsheng Lin (2): net: introduce and use skb_frag_fill_page_desc() net: remove __skb_frag_set_page() .../net/ethernet/aquantia/atlantic/aq_ring.c | 6 +-- drivers/net/ethernet/broadcom/bnx2.c | 1 - drivers/net/ethernet/broadcom/bnxt/bnxt.c | 10 ++--- drivers/net/ethernet/chelsio/cxgb3/sge.c | 5 +-- drivers/net/ethernet/emulex/benet/be_main.c | 32 ++++++++------- drivers/net/ethernet/freescale/enetc/enetc.c | 5 +-- .../net/ethernet/fungible/funeth/funeth_rx.c | 5 +-- drivers/net/ethernet/marvell/mvneta.c | 5 +-- .../net/ethernet/mellanox/mlx5/core/en_rx.c | 4 +- drivers/net/ethernet/sun/cassini.c | 8 +--- drivers/net/virtio_net.c | 4 +- drivers/net/vmxnet3/vmxnet3_drv.c | 4 +- drivers/net/xen-netback/netback.c | 4 +- include/linux/skbuff.h | 39 +++++-------------- net/bpf/test_run.c | 3 +- net/core/gro.c | 4 +- net/core/pktgen.c | 13 ++++--- net/core/skbuff.c | 7 ++-- net/tls/tls_device.c | 10 ++--- net/xfrm/xfrm_ipcomp.c | 5 +-- 20 files changed, 65 insertions(+), 109 deletions(-)