From patchwork Wed May 10 20:29:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Judith Mendez X-Patchwork-Id: 9171 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp3904301vqo; Wed, 10 May 2023 13:36:23 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5QEIkByfYJ3v1eJqBZ5a+pQlfc79gTCEdAY6c+Dh0a17BThNx3idPVXLAzaig7SZG0gYik X-Received: by 2002:a17:902:ea82:b0:1aa:e653:1c0d with SMTP id x2-20020a170902ea8200b001aae6531c0dmr19487965plb.19.1683750983571; Wed, 10 May 2023 13:36:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683750983; cv=none; d=google.com; s=arc-20160816; b=WH1LQ+PvvYBKfQPh/2UZZBPnLPHjI1CYzCZiV0+X9AiVGpP2+4KofMl1pSTx1B6qib GPa9kyNySFecHRxnGmYSjQpkLhdsbgLX9I2Yjc6ym+EoQvHfneJtwIY5nqn2eNUJPeHZ FjJfAy42bazAB9gMc5QcceIE76lskM01Rg0Mxde1HQqPTQwaQCQKPRQDWMPHik7RsOJf fthVb9Zi9Ere5pGwSV5+I7kwBCyocz6UKQKz8fGiVXDUdf4288Wge9ZmFT+dfI/u0OJf ztYBiQvdSLlC3fZS5DPxLbPNW5jPQU7S4QM8FKLqv7tVaai/pAtAE2TeC8JZHoicHZwg ERlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from :dkim-signature; bh=2cJZIs81lmPryiqiEfHY5tjqz/GEf9161fy47W1PJgw=; b=lcKKrDJE7+Fb39OfuUjAgdd0A9nYJZRbT4Ub5+zW4m1zwJvkMl/ux7mm3YstWeVBiv c7fyRgwYWEb5ORwspi+q6dAsKQNGYiO9rGV8rw/bSD3u0MeZlqTDZCMMxklQzhh6HXpK GSWQ+0oumgdqPSyBW6mp/uiYPfptsVkp+eejdtvuiIQsiB0VoFN/bZCKHTM6TgHxXTp+ iYYMBk+YXDh67vnKwMY8vtmAYnvNozcMF/mkYgBr9XBKf0wn+6rcrjT4PPCLSedVgULE 4+22lIIJwspOye+83IpqU8pIem8FRSlJVoGw5KUw1PgE2ts9B87gpiqFs7E7hupYg2T6 Tj9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=MtbBHDmy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ix1-20020a170902f80100b001a691f376e8si4705700plb.415.2023.05.10.13.36.08; Wed, 10 May 2023 13:36:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=MtbBHDmy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236485AbjEJUaa (ORCPT + 99 others); Wed, 10 May 2023 16:30:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231465AbjEJUaZ (ORCPT ); Wed, 10 May 2023 16:30:25 -0400 Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C9734EC5; Wed, 10 May 2023 13:30:22 -0700 (PDT) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 34AKTsU2106837; Wed, 10 May 2023 15:29:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1683750594; bh=2cJZIs81lmPryiqiEfHY5tjqz/GEf9161fy47W1PJgw=; h=From:To:CC:Subject:Date; b=MtbBHDmyGxI2eKyuv4dWWvnRdLZLxE2H0gcUao0kjDpP8FptkPsSwvgUG7vhixeDd 7tAXCe0qh/TavDTtpo5hi1HEa5FCHcCgrTPCjFO1ZOjF1uQfYoazeEEmdDA4bDIPhM q1kjFa5pw20a9yir9XgyacK9FlJl0vBVZeqsDO10= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 34AKTsu2026223 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 10 May 2023 15:29:54 -0500 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 10 May 2023 15:29:53 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 10 May 2023 15:29:53 -0500 Received: from a0498204.dal.design.ti.com (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 34AKTqDG003872; Wed, 10 May 2023 15:29:52 -0500 From: Judith Mendez To: , Chandrasekar Ramakrishnan CC: Wolfgang Grandegger , Marc Kleine-Budde , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , , , Schuyler Patton , , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Oliver Hartkopp , Subject: [PATCH v5 0/2] Enable multiple MCAN on AM62x Date: Wed, 10 May 2023 15:29:50 -0500 Message-ID: <20230510202952.27111-1-jm@ti.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765540871159593417?= X-GMAIL-MSGID: =?utf-8?q?1765540871159593417?= On AM62x there are two MCANs in MCU domain. The MCANs in MCU domain were not enabled since there is no hardware interrupt routed to A53 GIC interrupt controller. Therefore A53 Linux cannot be interrupted by MCU MCANs. This solution instantiates a hrtimer with 1 ms polling interval for MCAN device when there is no hardware interrupt property in DTB MCAN node. The hrtimer generates a recurring software interrupt which allows to call the isr. The isr will check if there is pending transaction by reading a register and proceed normally if there is. MCANs with hardware interrupt routed to A53 Linux will continue to use the hardware interrupt as expected. Timer polling method was tested on both classic CAN and CAN-FD at 125 KBPS, 250 KBPS, 1 MBPS and 2.5 MBPS with 4 MBPS bitrate switching. Letency and CPU load benchmarks were tested on 3x MCAN on AM62x. 1 MBPS timer polling interval is the better timer polling interval since it has comparable latency to hardware interrupt with the worse case being 1ms + CAN frame propagation time and CPU load is not substantial. Latency can be improved further with less than 1 ms polling intervals, howerver it is at the cost of CPU usage since CPU load increases at 0.5 ms. Note that in terms of power, enabling MCU MCANs with timer-polling implementation might have negative impact since we will have to wake up every 1 ms whether there are CAN packets pending in the RX FIFO or not. This might prevent the CPU from entering into deeper idle states for extended periods of time. v4: Link: https://lore.kernel.org/linux-can/c3395692-7dbf-19b2-bd3f-31ba86fa4ac9@linaro.org/T/#t v2: Link: https://lore.kernel.org/linux-can/20230424195402.516-1-jm@ti.com/T/#t V1: Link: https://lore.kernel.org/linux-can/19d8ae7f-7b74-a869-a818-93b74d106709@ti.com/T/#t RFC: Link: https://lore.kernel.org/linux-can/52a37e51-4143-9017-42ee-8d17c67028e3@ti.com/T/#t Changes since v4: - Remove poll-interval in bindings - Change dev_dbg to dev_info for case where hardware int exists and polling is enabled Changes since v3: - Wrong patches sent Changes since v2: - Change binding patch first - Update binding poll-interval description - Add oneOf to select either interrupts/interrupt-names or poll-interval - Sort list of includes - Create a define for 1 ms polling interval - Change plarform_get_irq to optional to not print error msg - Fix indentations, lengths of code lines, and added other style changes Changes since v1: - Add poll-interval property to bindings and MCAN DTB node - Add functionality to check for 'poll-interval' property in MCAN node - Bindings: add an example using poll-interval - Add 'polling' flag in driver to check if device is using polling method - Check for both timer polling and hardware interrupt case, default to hardware interrupt method - Change ns_to_ktime() to ms_to_ktime() Judith Mendez (2): dt-bindings: net: can: Add poll-interval for MCAN can: m_can: Add hrtimer to generate software interrupt .../bindings/net/can/bosch,m_can.yaml | 20 +++++++++-- drivers/net/can/m_can/m_can.c | 28 ++++++++++++++- drivers/net/can/m_can/m_can.h | 4 +++ drivers/net/can/m_can/m_can_platform.c | 35 +++++++++++++++++-- 4 files changed, 81 insertions(+), 6 deletions(-) base-commit: 578215f3e21c472c08d70b8796edf1ac58f88578