mbox series

[0/8] arm64: dts: qcom: msm8916: Rework regulator constraints

Message ID 20230510-msm8916-regulators-v1-0-54d4960a05fc@gerhold.net
Headers
Series arm64: dts: qcom: msm8916: Rework regulator constraints |

Message

Stephan Gerhold May 17, 2023, 6:48 p.m. UTC 
  Rework the regulator constraints for the MSM8916 device trees to be 
closer to reality. There are several mistakes in there, some of them 
taken over directly from Qualcomm's vendor kernel. Fortunately, none of 
the mistakes is absolutely critical because it turns out that the RPM 
firmware also validates the voltages and silently clamps the requests 
to a proper range. Still, this behavior should be clearly represented 
in the device tree rather than pretending to apply the wrong voltages.

To make the regulator constraints more easily maintainable with a large 
number of similar MSM8916 boards I propose moving the voltages for the 
standard components in the SoC to the shared msm8916-pm8916.dtsi 
include. With this only the actual board-specific regulators are 
described in the board DT.

Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
---
Stephan Gerhold (8):
      arm64: dts: qcom: apq8016-sbc: Fix regulator constraints
      arm64: dts: qcom: apq8016-sbc: Fix 1.8V power rail on LS expansion
      arm64: dts: qcom: msm8916: Fix regulator constraints
      arm64: dts: qcom: msm8916: Disable audio codecs by default
      arm64: dts: qcom: pm8916: Move default regulator "-supply"s
      arm64: dts: qcom: msm8916-pm8916: Clarify purpose
      arm64: dts: qcom: msm8916: Define regulator constraints next to usage
      arm64: dts: qcom: msm8916-pm8916: Mark always-on regulators

 arch/arm64/boot/dts/qcom/apq8016-sbc.dts           | 145 +++++----------------
 arch/arm64/boot/dts/qcom/msm8916-acer-a1-724.dts   | 115 ++--------------
 .../boot/dts/qcom/msm8916-alcatel-idol347.dts      | 110 +---------------
 arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dts     | 110 +---------------
 arch/arm64/boot/dts/qcom/msm8916-gplus-fl8005a.dts | 110 +---------------
 arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dts     | 125 ++++--------------
 .../boot/dts/qcom/msm8916-longcheer-l8150.dts      | 110 +---------------
 .../boot/dts/qcom/msm8916-longcheer-l8910.dts      | 110 +---------------
 arch/arm64/boot/dts/qcom/msm8916-pm8916.dtsi       | 121 ++++++++++++++---
 .../dts/qcom/msm8916-samsung-a2015-common.dtsi     | 110 +---------------
 .../boot/dts/qcom/msm8916-samsung-gt5-common.dtsi  | 110 +---------------
 .../boot/dts/qcom/msm8916-samsung-j5-common.dtsi   | 103 ---------------
 .../boot/dts/qcom/msm8916-samsung-serranove.dts    | 103 ---------------
 arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi          | 103 ---------------
 .../boot/dts/qcom/msm8916-wingtech-wt88047.dts     | 119 +++--------------
 arch/arm64/boot/dts/qcom/msm8916.dtsi              |   1 +
 arch/arm64/boot/dts/qcom/pm8916.dtsi               |   4 +-
 17 files changed, 236 insertions(+), 1473 deletions(-)
---
base-commit: 4272e06e19f388ccfe1f04f19060ea84d2a19a8b
change-id: 20230510-msm8916-regulators-97fa33735efe

Best regards,

Comments

Bjorn Andersson May 25, 2023, 4:54 a.m. UTC | #1 
On Wed, 17 May 2023 20:48:39 +0200, Stephan Gerhold wrote:
> Rework the regulator constraints for the MSM8916 device trees to be
> closer to reality. There are several mistakes in there, some of them
> taken over directly from Qualcomm's vendor kernel. Fortunately, none of
> the mistakes is absolutely critical because it turns out that the RPM
> firmware also validates the voltages and silently clamps the requests
> to a proper range. Still, this behavior should be clearly represented
> in the device tree rather than pretending to apply the wrong voltages.
> 
> [...]

Applied, thanks!

[1/8] arm64: dts: qcom: apq8016-sbc: Fix regulator constraints
      commit: e27654df20d77ad7549a3cf6739ebaa3aa59a088
[2/8] arm64: dts: qcom: apq8016-sbc: Fix 1.8V power rail on LS expansion
      commit: 5500f823db38db073d30557af159b77fb1f2bf26
[3/8] arm64: dts: qcom: msm8916: Fix regulator constraints
      commit: 355750828c5519c88de6ac0d09202d2a7e5892c5
[4/8] arm64: dts: qcom: msm8916: Disable audio codecs by default
      commit: a5cf21b14666c42912327c7bece38711f6e0d708
[5/8] arm64: dts: qcom: pm8916: Move default regulator "-supply"s
      commit: 38218822a72fd31e89affc7fc457d527f65581aa
[6/8] arm64: dts: qcom: msm8916-pm8916: Clarify purpose
      commit: f193264986b5944216e574b9962616f2524aac08
[7/8] arm64: dts: qcom: msm8916: Define regulator constraints next to usage
      commit: b0a8f16ae4a0eb423122256691849b3ebc64efc2
[8/8] arm64: dts: qcom: msm8916-pm8916: Mark always-on regulators
      commit: 8bbd35771f903a9d14fe95bcba8c7b9f07aeb958

Best regards,