Message ID | 20230509065230.32552-1-ed.tsai@mediatek.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2674943vqo; Tue, 9 May 2023 00:03:24 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5q8q16xgrpUpsXFSUcqutiJ/T9gfHSsH3Cgh6gn8eYo3A6KajgNS+BBZ1lZGAt9wKd2HlT X-Received: by 2002:a05:6a20:4326:b0:100:3258:d163 with SMTP id h38-20020a056a20432600b001003258d163mr8924743pzk.35.1683615804403; Tue, 09 May 2023 00:03:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683615804; cv=none; d=google.com; s=arc-20160816; b=ToYShGZxd5/ukCIt7l47r7e0kSSabxSQ4EmnnY+qUXSzPxfF+l/bFXc5OV8/0hhMlW mZOGQG/hHEOHtaQPHnqIBdgVUjKyDejHkCdMElk2gcuIxvjjfYeJp8cjPFsgdktp6ALf ubYdGeNbChuZdzDQgFOk20QvbusiF2BXpuTvyLRdXJ+7v66Uz5cvMHByzfBXEuUQuhXQ m+a2ZQ0Uf7RNVnHzdNkOtLHu+jDPwlslPDpRuILbpQIe1Vcag+aYxJPWgblmwbGLvl+3 MZPQgkGllIDYn8aXiq1wNw8FGEo0kaD0bnU7A+ngQAd4CFdoRog3sFiWC8N32MlX8pwd N1ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from :dkim-signature; bh=6zZhM6OjKFAMCL2ZrfNektKJnwU1fC+GI7+J+76jWEQ=; b=gTrVjQjamOlSCHJYdI/VZ2F3ktCOhJHL8prd/CC5FueaOwjudQv/BZVgDd7jbct4/m DvCdI3OHGErm9oA9yUbBYsUIRCeu+SfJsqzKim7iAj8OOaToV2eRznxZfjbWIaYEOdMB 3ILByWc1lZnDJsVf+Oar6kG7cYM6H1FGxLZildmM1EjDob5+0XmEI7y+7MolnQXQRYkc uLvMFUU8+FsaFqau10SKpwiRFjS/ubZcVWTLrCfduMs0rhFPYmKGgfU2ahd9NuSBfyk5 GlG7UhoMNEkRIBVjpAyCO5OeKoOOc7nkLBOIXY9GVqRnp1buYZfDFyFcr2tV3M5xEbHB rL4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=OpBD8AFM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j5-20020a637a45000000b005303a26dbf8si865083pgn.408.2023.05.09.00.03.11; Tue, 09 May 2023 00:03:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=OpBD8AFM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235100AbjEIGxN (ORCPT <rfc822;jeantsuru.cumc.mandola@gmail.com> + 99 others); Tue, 9 May 2023 02:53:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235070AbjEIGwt (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 9 May 2023 02:52:49 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92ABD4C03; Mon, 8 May 2023 23:52:46 -0700 (PDT) X-UUID: 16d5a80cee3611edb20a276fd37b9834-20230509 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=6zZhM6OjKFAMCL2ZrfNektKJnwU1fC+GI7+J+76jWEQ=; b=OpBD8AFMxgDrrGSbOtvGpkBbtNN5CJhhFF/3XoLmTdVlvPluHo325p7gDTf02c29zabb1Y6WfZZXghZ0LemBsJSSm3miBvmM35vZQPsy5THS1LhJqeQpO46vvLfZ/mwdw9K4w0s6DItiqnaHI4RGqNWMtBngiMMV7AzN9TpsqAY=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.23,REQID:03fbfabb-c0eb-4eb5-900f-e5b5ae64c48d,IP:0,U RL:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:697ab71,CLOUDID:59153dc0-e32c-4c97-918d-fbb3fc224d4e,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-UUID: 16d5a80cee3611edb20a276fd37b9834-20230509 Received: from mtkmbs13n2.mediatek.inc [(172.21.101.108)] by mailgw02.mediatek.com (envelope-from <ed.tsai@mediatek.com>) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 988925971; Tue, 09 May 2023 14:52:39 +0800 Received: from mtkmbs13n2.mediatek.inc (172.21.101.108) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Tue, 9 May 2023 14:52:39 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs13n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Tue, 9 May 2023 14:52:39 +0800 From: Ed Tsai <ed.tsai@mediatek.com> To: <axboe@kernel.dk> CC: <linux-block@vger.kernel.org>, <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <martin.petersen@oracle.com>, <bvanassche@acm.org>, <stanley.chu@mediatek.com>, <peter.wang@mediatek.com>, <chun-hung.wu@mediatek.com>, <alice.chao@mediatek.com>, <powen.kao@mediatek.com>, <naomi.chu@mediatek.com>, <wsd_upstream@mediatek.com>, Ed Tsai <ed.tsai@mediatek.com> Subject: [PATCH 0/2] block: improve the share tag set performance Date: Tue, 9 May 2023 14:52:28 +0800 Message-ID: <20230509065230.32552-1-ed.tsai@mediatek.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 Content-Type: text/plain X-MTK: N X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765399125410735091?= X-GMAIL-MSGID: =?utf-8?q?1765399125410735091?= |
Series |
block: improve the share tag set performance
|
|
Message
Ed Tsai (蔡宗軒)
May 9, 2023, 6:52 a.m. UTC
The tag allocation is limited by the number of active queues and a queue is marked as inactive by the queue timeout worker after up to 30Hz by default. UFS devices have multiple logical units, and they can limit the depth of data LUNs by the fair tag sharing algorithm. Make the fair tag sharing configurable and improve the performance for UFS devices. See also https://lore.kernel.org/all/20230103195337.158625-1-bvanassche@acm.org Ed Tsai (2): block: make the fair sharing of tag configurable ufs: don't use the fair tag sharings block/blk-mq-debugfs.c | 1 + block/blk-mq-tag.c | 1 + block/blk-mq.c | 3 ++- drivers/ufs/core/ufshcd.c | 3 +++ include/linux/blkdev.h | 6 +++++- 5 files changed, 12 insertions(+), 2 deletions(-)
Comments
On 5/8/23 23:52, Ed Tsai wrote: > The tag allocation is limited by the number of active queues and a > queue is marked as inactive by the queue timeout worker after up to 30Hz > by default. > > UFS devices have multiple logical units, and they can limit the depth of > data LUNs by the fair tag sharing algorithm. Make the fair tag sharing > configurable and improve the performance for UFS devices. > > See also https://lore.kernel.org/all/20230103195337.158625-1-bvanassche@acm.org Hi Jens, This patch series is slightly more complicated than the patch that I posted in January. Do you prefer the approach of this patch series or rather the approach of the patch that I posted in January? Thank you, Bart.