mbox series

[V2,0/2] perf parse-events: Do not break up AUX event group

Message ID 20230508093952.27482-1-adrian.hunter@intel.com
Headers
Series perf parse-events: Do not break up AUX event group |

Message

Adrian Hunter May 8, 2023, 9:39 a.m. UTC 
  Hi

Here is a fix needed in v6.4, but dependent on Ian's patch
"perf evsel: Modify group pmu name for software events", refer:

https://lore.kernel.org/lkml/20230502223851.2234828-20-irogers@google.com/

There is also a test amendment to test the AUX event group fix for
Intel PT.


Changes in V2:

   Add an Intel PT test amendment for the AUX event group fix
   Change AUX event group fix as suggested by Ian


Adrian Hunter (2):
      perf test: test_intel_pt.sh: Test sample mode with named PMU
      perf parse-events: Do not break up AUX event group

 tools/perf/tests/shell/test_intel_pt.sh | 7 +++++++
 tools/perf/util/evsel.c                 | 9 +++------
 2 files changed, 10 insertions(+), 6 deletions(-)


Regards
Adrian

Comments

Arnaldo Carvalho de Melo May 10, 2023, 5:13 p.m. UTC | #1 
Em Mon, May 08, 2023 at 12:39:50PM +0300, Adrian Hunter escreveu:
> Hi
> 
> Here is a fix needed in v6.4, but dependent on Ian's patch
> "perf evsel: Modify group pmu name for software events", refer:
> 
> https://lore.kernel.org/lkml/20230502223851.2234828-20-irogers@google.com/
> 
> There is also a test amendment to test the AUX event group fix for
> Intel PT.

Ok, so I think I can add your Tested-by for that "perf evsel: Modify
group pmu name for software events" patch, ok?

- Arnaldo
 
> 
> Changes in V2:
> 
>    Add an Intel PT test amendment for the AUX event group fix
>    Change AUX event group fix as suggested by Ian
> 
> 
> Adrian Hunter (2):
>       perf test: test_intel_pt.sh: Test sample mode with named PMU
>       perf parse-events: Do not break up AUX event group
> 
>  tools/perf/tests/shell/test_intel_pt.sh | 7 +++++++
>  tools/perf/util/evsel.c                 | 9 +++------
>  2 files changed, 10 insertions(+), 6 deletions(-)
Arnaldo Carvalho de Melo May 10, 2023, 5:15 p.m. UTC | #2 
Em Mon, May 08, 2023 at 12:39:50PM +0300, Adrian Hunter escreveu:
> Hi
> 
> Here is a fix needed in v6.4, but dependent on Ian's patch
> "perf evsel: Modify group pmu name for software events", refer:

Thanks, applied to perf-core, for v6.4.

- Arnaldo
 
> https://lore.kernel.org/lkml/20230502223851.2234828-20-irogers@google.com/
> 
> There is also a test amendment to test the AUX event group fix for
> Intel PT.
> 
> 
> Changes in V2:
> 
>    Add an Intel PT test amendment for the AUX event group fix
>    Change AUX event group fix as suggested by Ian
> 
> 
> Adrian Hunter (2):
>       perf test: test_intel_pt.sh: Test sample mode with named PMU
>       perf parse-events: Do not break up AUX event group
> 
>  tools/perf/tests/shell/test_intel_pt.sh | 7 +++++++
>  tools/perf/util/evsel.c                 | 9 +++------
>  2 files changed, 10 insertions(+), 6 deletions(-)
> 
> 
> Regards
> Adrian
Adrian Hunter May 10, 2023, 5:38 p.m. UTC | #3 
On 10/05/23 20:13, Arnaldo Carvalho de Melo wrote:
> Em Mon, May 08, 2023 at 12:39:50PM +0300, Adrian Hunter escreveu:
>> Hi
>>
>> Here is a fix needed in v6.4, but dependent on Ian's patch
>> "perf evsel: Modify group pmu name for software events", refer:
>>
>> https://lore.kernel.org/lkml/20230502223851.2234828-20-irogers@google.com/
>>
>> There is also a test amendment to test the AUX event group fix for
>> Intel PT.
> 
> Ok, so I think I can add your Tested-by for that "perf evsel: Modify
> group pmu name for software events" patch, ok?

Yes, thank you!

> 
> - Arnaldo
>  
>>
>> Changes in V2:
>>
>>    Add an Intel PT test amendment for the AUX event group fix
>>    Change AUX event group fix as suggested by Ian
>>
>>
>> Adrian Hunter (2):
>>       perf test: test_intel_pt.sh: Test sample mode with named PMU
>>       perf parse-events: Do not break up AUX event group
>>
>>  tools/perf/tests/shell/test_intel_pt.sh | 7 +++++++
>>  tools/perf/util/evsel.c                 | 9 +++------
>>  2 files changed, 10 insertions(+), 6 deletions(-)