mbox series

[v3,0/2] Add support for the ICM 20600 IMU

Message ID 20230505054853.2155326-1-chenhuiz@axis.com
Headers
Series Add support for the ICM 20600 IMU |

Message

Hermes Zhang May 5, 2023, 5:48 a.m. UTC 
  The Invensense ICM-20600 is a 6-axis MotionTracking device that combines a
3-axis gyroscope and an 3-axis accelerometer. It is very similar to the
ICM20602 imu which is already supported by the mpu6050 driver. The main
difference is that the ICM-20600 has a different WHOAMI value.

Notes:
    v2: require specifying "invensense,icm20602" as a fallback compatible
        in the binding, as suggested
    v3: reorder "invensense,icm20602" entry before icm20608 and add
        Reviewed-by tag from Krzysztof

Hermes Zhang (2):
  dt-bindings: iio: imu: mpu6050: Add icm20600 bindings to mpu6050
  iio: imu: mpu6050: Add support for the ICM 20600 IMU

 .../bindings/iio/imu/invensense,mpu6050.yaml           |  3 +++
 drivers/iio/imu/inv_mpu6050/Kconfig                    |  4 ++--
 drivers/iio/imu/inv_mpu6050/inv_mpu_core.c             | 10 ++++++++++
 drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c              |  6 ++++++
 drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h              |  2 ++
 drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c              |  5 +++++
 6 files changed, 28 insertions(+), 2 deletions(-)

Comments

Jonathan Cameron May 6, 2023, 4:37 p.m. UTC | #1 
On Fri, 5 May 2023 13:48:51 +0800
Hermes Zhang <chenhuiz@axis.com> wrote:

> The Invensense ICM-20600 is a 6-axis MotionTracking device that combines a
> 3-axis gyroscope and an 3-axis accelerometer. It is very similar to the
> ICM20602 imu which is already supported by the mpu6050 driver. The main
> difference is that the ICM-20600 has a different WHOAMI value.
> 
> Notes:
>     v2: require specifying "invensense,icm20602" as a fallback compatible
>         in the binding, as suggested
>     v3: reorder "invensense,icm20602" entry before icm20608 and add
>         Reviewed-by tag from Krzysztof

Looks good to me.  I want to leave a little more time for Jean-Baptiste to take
a look.  If it looks like I've forgotten this in 2 weeks, feel free to give me
a poke.

Thanks,

Jonathan


> 
> Hermes Zhang (2):
>   dt-bindings: iio: imu: mpu6050: Add icm20600 bindings to mpu6050
>   iio: imu: mpu6050: Add support for the ICM 20600 IMU
> 
>  .../bindings/iio/imu/invensense,mpu6050.yaml           |  3 +++
>  drivers/iio/imu/inv_mpu6050/Kconfig                    |  4 ++--
>  drivers/iio/imu/inv_mpu6050/inv_mpu_core.c             | 10 ++++++++++
>  drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c              |  6 ++++++
>  drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h              |  2 ++
>  drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c              |  5 +++++
>  6 files changed, 28 insertions(+), 2 deletions(-)
>
Jonathan Cameron May 13, 2023, 5:58 p.m. UTC | #2 
On Sat, 6 May 2023 17:37:17 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> On Fri, 5 May 2023 13:48:51 +0800
> Hermes Zhang <chenhuiz@axis.com> wrote:
> 
> > The Invensense ICM-20600 is a 6-axis MotionTracking device that combines a
> > 3-axis gyroscope and an 3-axis accelerometer. It is very similar to the
> > ICM20602 imu which is already supported by the mpu6050 driver. The main
> > difference is that the ICM-20600 has a different WHOAMI value.
> > 
> > Notes:
> >     v2: require specifying "invensense,icm20602" as a fallback compatible
> >         in the binding, as suggested
> >     v3: reorder "invensense,icm20602" entry before icm20608 and add
> >         Reviewed-by tag from Krzysztof  
> 
> Looks good to me.  I want to leave a little more time for Jean-Baptiste to take
> a look.  If it looks like I've forgotten this in 2 weeks, feel free to give me
> a poke.

Series applied to the togreg branch of iio.git and initially pushed out as
testing for 0-day to take a look and see if we missed anything.

Thanks,

Jonathan

> 
> Thanks,
> 
> Jonathan
> 
> 
> > 
> > Hermes Zhang (2):
> >   dt-bindings: iio: imu: mpu6050: Add icm20600 bindings to mpu6050
> >   iio: imu: mpu6050: Add support for the ICM 20600 IMU
> > 
> >  .../bindings/iio/imu/invensense,mpu6050.yaml           |  3 +++
> >  drivers/iio/imu/inv_mpu6050/Kconfig                    |  4 ++--
> >  drivers/iio/imu/inv_mpu6050/inv_mpu_core.c             | 10 ++++++++++
> >  drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c              |  6 ++++++
> >  drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h              |  2 ++
> >  drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c              |  5 +++++
> >  6 files changed, 28 insertions(+), 2 deletions(-)
> >   
>