mbox series

[v5,0/2] Add new ti,no-thermistor property

Message ID 20230504093037.2056146-1-chenhuiz@axis.com
Headers
Series Add new ti,no-thermistor property |

Message

Hermes Zhang May 4, 2023, 9:30 a.m. UTC 
  The TS pin is used to detect the temperature and suspend the charging
when it's voltage out of range. If the NTC is not connect in HW, the
TS_IGNORE bit need to be set to 1 to make charge work. The new
"ti,no-thermistor" is used to set TS_IGNORE to 1 when HW doesn't work
with NTC.

Description from datasheet:
Battery temperature qualification voltage input. Connect a negative temperature
coefficient thermistor (NTC). Program temperature window with a resistor divider
from REGN to TS to GND. Charge and Boost mode suspend when TS pin voltage is
out of range. When TS pin is not used, connect a 10-kΩ resistor from REGN to TS
and a 10-kΩ resistor from TS to GND or set TS_IGNORE to HIGH to ignore TS pin.
It is recommended to use a 103AT-2 thermistor.

Notes:
    v2: change property name to ti,no-thermistor

    v3: drop "|" in property description

    v4: rebase bq256xx_charger.c

    v5: add Reviewed-by tag from Krzysztof Kozlowski

Hermes Zhang (2):
  dt-bindings: power: supply: bq256xx: Add ti,no-thermistor property
  power: supply: bq256xx: Apply TS_IGNORE from devicetree

 .../bindings/power/supply/bq256xx.yaml        | 18 ++++++++++++
 drivers/power/supply/bq256xx_charger.c        | 28 +++++++++++++++++++
 2 files changed, 46 insertions(+)

Comments

Sebastian Reichel May 8, 2023, 12:18 p.m. UTC | #1 
Hi,

On Thu, May 04, 2023 at 05:30:35PM +0800, Hermes Zhang wrote:
> The TS pin is used to detect the temperature and suspend the charging
> when it's voltage out of range. If the NTC is not connect in HW, the
> TS_IGNORE bit need to be set to 1 to make charge work. The new
> "ti,no-thermistor" is used to set TS_IGNORE to 1 when HW doesn't work
> with NTC.
> 
> Description from datasheet:
> Battery temperature qualification voltage input. Connect a negative temperature
> coefficient thermistor (NTC). Program temperature window with a resistor divider
> from REGN to TS to GND. Charge and Boost mode suspend when TS pin voltage is
> out of range. When TS pin is not used, connect a 10-kΩ resistor from REGN to TS
> and a 10-kΩ resistor from TS to GND or set TS_IGNORE to HIGH to ignore TS pin.
> It is recommended to use a 103AT-2 thermistor.
> 
> Notes:
>     v2: change property name to ti,no-thermistor
> 
>     v3: drop "|" in property description
> 
>     v4: rebase bq256xx_charger.c
> 
>     v5: add Reviewed-by tag from Krzysztof Kozlowski
> 
> Hermes Zhang (2):
>   dt-bindings: power: supply: bq256xx: Add ti,no-thermistor property
>   power: supply: bq256xx: Apply TS_IGNORE from devicetree
> 
>  .../bindings/power/supply/bq256xx.yaml        | 18 ++++++++++++
>  drivers/power/supply/bq256xx_charger.c        | 28 +++++++++++++++++++
>  2 files changed, 46 insertions(+)

Thanks, queued.

-- Sebastian