mbox series

[0/3] afs: Fix directory size handling

Message ID 20230502163528.1564398-1-dhowells@redhat.com
Headers
Series afs: Fix directory size handling |

Message

David Howells May 2, 2023, 4:35 p.m. UTC 
  Hi Linus,

Could you apply these three fixes to AFS directory handling?

 (1) Make sure that afs_read_dir() sees any increase in file size if the
     file unexpectedly changed on the server (e.g. due to another client
     making a change).

 (2) Make afs_getattr() always return the server's dir file size, not the
     locally edited one, so that pagecache eviction doesn't cause the dir
     file size to change unexpectedly.

 (3) Prevent afs_read_dir() from getting into an endless loop if the server
     indicates that the directory file size is larger than expected.

The patches can be found here:

	https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=afs-fixes

Thanks,
David

---
%(shortlog)s
%(diffstat)s

David Howells (1):
  afs: Fix getattr to report server i_size on dirs, not local size

Marc Dionne (2):
  afs: Fix updating of i_size with dv jump from server
  afs: Avoid endless loop if file is larger than expected

 fs/afs/dir.c   |  4 ++++
 fs/afs/inode.c | 10 +++++++++-
 2 files changed, 13 insertions(+), 1 deletion(-)

Comments

Linus Torvalds May 2, 2023, 5:56 p.m. UTC | #1 
On Tue, May 2, 2023 at 9:35 AM David Howells <dhowells@redhat.com> wrote:
>
> The patches can be found here:
>
>         https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=afs-fixes

Ok, I started pulling this, and then I realized that this is the first
time in this release window that I've gotten a non-signed pull
request.

(Not that it was a proper pull request format anyway - the above is
just a gitweb pointer, not a real git branch pointer, but it was close
enough)

So can you please just make this a proper signed tag, and maybe we'll
have the first release ever when every single pull is done with
signage?

I know you can do this properly, since  I have several pull requests
from you that were signed, including for AFS.

                 Linus