From patchwork Mon May 1 22:46:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Judith Mendez X-Patchwork-Id: 8817 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp227024vqo; Mon, 1 May 2023 16:03:31 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4vwSmgr/6Fo9lJ8Quvn6BCzz3wUscAaavi8YT2vhGkekZEjzSeVT2SA9FoqT0ZptqaeDoi X-Received: by 2002:a17:902:ec83:b0:1a6:f93a:a135 with SMTP id x3-20020a170902ec8300b001a6f93aa135mr17652873plg.61.1682982211584; Mon, 01 May 2023 16:03:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682982211; cv=none; d=google.com; s=arc-20160816; b=AjE8A52G/ZQ8XqK2CApx6HK4D4sL3P24wJvjy5lBi4XCpXQyrlWXWbiIi2JsnB5uUU uG73lFsTmwsTev7TWu8HGI4v0lFr1wrLKjADIKAyt3zxgAneA5dUoYb3qDw37aYXjfE7 HfeIJev+3fm6ZOW7JLviP2FPeu9j3QCsfI5umpvarEP4euLvuRYaSRBTQ2h3hbPEFePZ 5Vmqk3+stk+M3wSIHVW1XRW5WsRdMG3CT2t9DvsJRLXexMiX+35+AJJlReWkuuAKwtK0 2USDEZfT6Bdbi70JBbyKgfMXZu80XSFOGleLy+4snI4vkB61x8uyZ8hMhwWjJB+tKnGN 89Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from :dkim-signature; bh=qY/0qRa3aQKgIxqooRRhbfOQoOpi41u3zZ7KiGXu1jM=; b=e0I055gikA0gmAOnu+oVRftprO1tdzdeismzDNGyvbdoxlfbt37iNwp0i4S0LzF9ll A1zS2kQY6nBKSzUNDzCTMe0TsujazwIVVN+GKEn7CHj/eUO4Xi9Jl8/XAP9P5uTBvPvy dohickvs/tDnPeGUTnxx8WyFEbbDCyEI0nvvHQYfjB2KY4ieU3Ij64P6hDY/BepyzRqw YU44L6oHSMAZorJe37TEClvF5H6NrlPu/pOFgD43zijULqMZsNlYOQcjO53cUX5ipBju wzRPM/E542t6X2NMmsR6L6gqKd4zdbTUbpcCH7wT1uEKsThNlHxvVPedggHN/JZyjOLG FOGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=F4nZcsue; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x12-20020a63484c000000b00519a3fb282esi28591282pgk.864.2023.05.01.16.03.17; Mon, 01 May 2023 16:03:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=F4nZcsue; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233167AbjEAWrE (ORCPT + 99 others); Mon, 1 May 2023 18:47:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232985AbjEAWq5 (ORCPT ); Mon, 1 May 2023 18:46:57 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A60D269E; Mon, 1 May 2023 15:46:56 -0700 (PDT) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 341MkO1l097648; Mon, 1 May 2023 17:46:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1682981184; bh=qY/0qRa3aQKgIxqooRRhbfOQoOpi41u3zZ7KiGXu1jM=; h=From:To:CC:Subject:Date; b=F4nZcsuezxIq6Jzp33lDZ8d9M7XU2cPhoS5lyEXOpQZl4LBTHdVUIEbAlnRJTqhSl gtYqavDzY2G638UryUjIag4pPsz0cHL8XsI3xa7BqUmVRwu/CjJiEXFd57DgvuX1Xr AiYNi4FrFDpKT1ZwieVZF5unyqlK6x7auY2n/OcI= Received: from DLEE106.ent.ti.com (dlee106.ent.ti.com [157.170.170.36]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 341MkOdX066896 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 1 May 2023 17:46:24 -0500 Received: from DLEE104.ent.ti.com (157.170.170.34) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 1 May 2023 17:46:24 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 1 May 2023 17:46:24 -0500 Received: from a0498204.dal.design.ti.com (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 341MkOhd002097; Mon, 1 May 2023 17:46:24 -0500 From: Judith Mendez To: Chandrasekar Ramakrishnan , Wolfgang Grandegger , Marc Kleine-Budde , Krzysztof Kozlowski CC: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , , , , Schuyler Patton , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , , , Oliver Hartkopp , Simon Horman Subject: [PATCH v4 0/4] Enable multiple MCAN on AM62x Date: Mon, 1 May 2023 17:46:20 -0500 Message-ID: <20230501224624.13866-1-jm@ti.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764732825655560351?= X-GMAIL-MSGID: =?utf-8?q?1764734755204827370?= On AM62x there is one MCAN in MAIN domain and two in MCU domain. The MCANs in MCU domain were not enabled since there is no hardware interrupt routed to A53 GIC interrupt controller. Therefore A53 Linux cannot be interrupted by MCU MCANs. This solution instantiates a hrtimer with 1 ms polling interval for MCAN device when there is no hardware interrupt and there is poll-interval property in DTB MCAN node. The hrtimer generates a recurring software interrupt which allows to call the isr. The isr will check if there is pending transaction by reading a register and proceed normally if there is. On AM62x, this series enables two MCU MCAN which will use the hrtimer implementation. MCANs with hardware interrupt routed to A53 Linux will continue to use the hardware interrupt as expected. Timer polling method was tested on both classic CAN and CAN-FD at 125 KBPS, 250 KBPS, 1 MBPS and 2.5 MBPS with 4 MBPS bitrate switching. Letency and CPU load benchmarks were tested on 3x MCAN on AM62x. 1 MBPS timer polling interval is the better timer polling interval since it has comparable latency to hardware interrupt with the worse case being 1ms + CAN frame propagation time and CPU load is not substantial. Latency can be improved further with less than 1 ms polling intervals, howerver it is at the cost of CPU usage since CPU load increases at 0.5 ms. Note that in terms of power, enabling MCU MCANs with timer-polling implementation might have negative impact since we will have to wake up every 1 ms whether there are CAN packets pending in the RX FIFO or not. This might prevent the CPU from entering into deeper idle states for extended periods of time. This patch series depends on 'Enable CAN PHY transceiver driver': Link: https://lore.kernel.org/lkml/775ec9ce-7668-429c-a977-6c8995968d6e@app.fastmail.com/T/ v2: Link: https://lore.kernel.org/linux-can/20230424195402.516-1-jm@ti.com/T/#t V1: Link: https://lore.kernel.org/linux-can/19d8ae7f-7b74-a869-a818-93b74d106709@ti.com/T/#t RFC: Link: https://lore.kernel.org/linux-can/52a37e51-4143-9017-42ee-8d17c67028e3@ti.com/T/#t Changes since v3: - Wrong patch sent, resend correct patch series Changes since v2: - Change binding patch first - Update binding poll-interval description - Add oneOf to select either interrupts/interrupt-names or poll-interval - Sort list of includes - Create a define for 1 ms polling interval - Change plarform_get_irq to optional to not print error msg - Fix indentations, lengths of code lines, and added other style changes Changes since v1: - Add poll-interval property to bindings and MCAN DTB node - Add functionality to check for 'poll-interval' property in MCAN node - Bindings: add an example using poll-interval - Add 'polling' flag in driver to check if device is using polling method - Check for both timer polling and hardware interrupt case, default to hardware interrupt method - Change ns_to_ktime() to ms_to_ktime() Judith Mendez (4): dt-bindings: net: can: Add poll-interval for MCAN can: m_can: Add hrtimer to generate software interrupt arm64: dts: ti: Add AM62x MCAN MAIN domain transceiver overlay arm64: dts: ti: Enable MCU MCANs for AM62x .../bindings/net/can/bosch,m_can.yaml | 36 +++++++++++- arch/arm64/boot/dts/ti/Makefile | 2 + arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi | 24 ++++++++ .../boot/dts/ti/k3-am625-sk-mcan-main.dtso | 35 ++++++++++++ .../boot/dts/ti/k3-am625-sk-mcan-mcu.dtso | 57 +++++++++++++++++++ drivers/net/can/m_can/m_can.c | 29 +++++++++- drivers/net/can/m_can/m_can.h | 4 ++ drivers/net/can/m_can/m_can_platform.c | 32 ++++++++++- 8 files changed, 212 insertions(+), 7 deletions(-) create mode 100644 arch/arm64/boot/dts/ti/k3-am625-sk-mcan-main.dtso create mode 100644 arch/arm64/boot/dts/ti/k3-am625-sk-mcan-mcu.dtso base-commit: 92e815cf07ed24ee1c51b122f24ffcf2964b4b13