From patchwork Mon May 1 18:57:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Almeida?= X-Patchwork-Id: 8809 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp128678vqo; Mon, 1 May 2023 12:10:03 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6K/a9L73hsuDAyDAm2B6mIHE3KMQAKONliuwbE6A8FAkoxb2/0VXxM2YZOVrfrik8XPMZ/ X-Received: by 2002:a17:902:d484:b0:1a8:1e8c:95f5 with SMTP id c4-20020a170902d48400b001a81e8c95f5mr17684247plg.69.1682968203111; Mon, 01 May 2023 12:10:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682968203; cv=none; d=google.com; s=arc-20160816; b=Av1WMbbCj5Yrj5mvVzXvETEG6OpviIc8q8E0Zav7PyBHXheN6uPXMn8yIPR5r6xWDV IayOg+EJcC4C7REqmBgIAD9J7m/9+T25gMt04uDlYiG4wcWly2MX3fnI9NG8B5udXYDh 0ivbNXS4dMkldW2a5ISypdKHh/VAZJDtqkgZXj9D1iSpc+I0rxsEdVrACG0os8NvfnOP pl061J2Z2cKKv3tbaQzcle6+lbQC55MVoPFITPVq1Cc+fkOjRqHA2B9sgmyYiGK7LcAK NEg8sMn/G635Mw+bFJ1sc1QQwvGkGVp/M93RqQ9Y7Mq7roj/+1ZIikPD00+K3F7QNAy1 qTow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=hZemwKqI+XbJvZCmRaGMFa4GqKWtdAWoykUnIAnqKOI=; b=nj2EnqfXhDrEDaQRczUiTMfNbTTmhFxg1EQsuKcvUKH60hXHj0CnBdib5EsS7TYuQF qe7YEMqH3QAeXyZNZdNlQi1SOka8YP/BahQiXqE1m7ylMuvx37WAYY1DDRkD6FbSNqE+ bArHNlumg+nvuEBIQ9svjFtLoeqGO7xx6isUG9E10S7B8Ando7pqIfU0jm9IrdS6QHMn jGY1iyIsXZRNbVzEhzEvbyKOkDOrUbzckWX4Qdqxg2F6WIN+QNJTxw7OD38IcLkBBRVd IHtI97L1RKM8Qyt24cNA8hjCdpiXvof/7UvIghm3imEvfzNly/bsgPRCxXEeCcQBSiMX 9KAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@igalia.com header.s=20170329 header.b="eOZ/Xgo+"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g11-20020a1709026b4b00b0019e95180a08si28564089plt.59.2023.05.01.12.09.47; Mon, 01 May 2023 12:10:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@igalia.com header.s=20170329 header.b="eOZ/Xgo+"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232719AbjEAS6r (ORCPT + 99 others); Mon, 1 May 2023 14:58:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229861AbjEAS6q (ORCPT ); Mon, 1 May 2023 14:58:46 -0400 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 110801708 for ; Mon, 1 May 2023 11:58:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=hZemwKqI+XbJvZCmRaGMFa4GqKWtdAWoykUnIAnqKOI=; b=eOZ/Xgo+w1avvUZ+ctjJLSHe4R 3PO7t7pJxOMDpP1SwWDO6KhBpE+vxfmaAhSWlRNyAuX5KyzvoUPDibdD1c525ZUoBDeOBOIGkkry2 pMBeT1wsv4GaR+MrbEZX945Y5c8d2bbWGzEoKZdR5Dh1TXA2IWFPDY5zV2fRHHIMIlpoUw2ynbljK N1gRQypiTIe1M/BZLxs+yQ3ZUtltDY4tbFNF2gjufV/DRkcV5wD8xMLk20NuoB9rj2akR9zi3pjUE muA/hWG58TT2ZlG4mnehsuEIWGGBAIbEAj4ZKGwUfZwaEq/qaEk0eBr3fIki9pJQ9/9YDH/qZzMwY 1AxjAfRg==; Received: from [179.113.250.147] (helo=steammachine.lan) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1ptYjO-00H3BT-Q4; Mon, 01 May 2023 20:58:39 +0200 From: =?utf-8?q?Andr=C3=A9_Almeida?= To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: kernel-dev@igalia.com, alexander.deucher@amd.com, christian.koenig@amd.com, pierre-eric.pelloux-prayer@amd.com, =?utf-8?b?J01hcmVrIE9sxaHDoWsn?= , Samuel Pitoiset , Bas Nieuwenhuizen , =?utf-8?q?Timur_Krist=C3=B3f?= , michel.daenzer@mailbox.org, =?utf-8?q?Andr=C3=A9_Almeida?= Subject: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl Date: Mon, 1 May 2023 15:57:46 -0300 Message-Id: <20230501185747.33519-1-andrealmeid@igalia.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764720066583283088?= X-GMAIL-MSGID: =?utf-8?q?1764720066583283088?= Currently UMD hasn't much information on what went wrong during a GPU reset. To help with that, this patch proposes a new IOCTL that can be used to query information about the resources that caused the hang. The goal of this RFC is to gather feedback about this interface. The mesa part can be found at https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22785 The current implementation is racy, meaning that if two resets happens (even on different rings), the app will get the last reset information available, rather than the one that is looking for. Maybe this can be fixed with a ring_id parameter to query the information for a specific ring, but this also requires an interface to tell the UMD which ring caused it. I know that devcoredump is also used for this kind of information, but I believe that using an IOCTL is better for interfacing Mesa + Linux rather than parsing a file that its contents are subjected to be changed. André Almeida (1): drm/amdgpu: Add interface to dump guilty IB on GPU hang drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 7 ++++++ drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 1 + drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 29 ++++++++++++++++++++++++ include/uapi/drm/amdgpu_drm.h | 7 ++++++ 7 files changed, 52 insertions(+), 1 deletion(-)