mbox series

[0/5] Improvements for drv260x driver and add to Huawei Watch

Message ID 20230430-drv260x-improvements-v1-0-1fb28b4cc698@z3ntu.xyz
Headers
Series Improvements for drv260x driver and add to Huawei Watch |

Message

Luca Weiss April 30, 2023, 6:20 p.m. UTC 
  Clean up some issues with the driver I've noticed while working on it,
then fix the magnitude handling which previously resulted the driver
discarding the upper 8 bits of the magnitude value, and finally we can
add the drv260x to the APQ8026 Huawei Watch.

While the "fix magnitude handling" commit technically changes behavior
and could change behavior of existing user space applications that deal
with this quirky behavior, it's definitely not correct and results in
very unexpected behavior if the user space doesn't look out for it
(meaning only use 0x00-0xFF magnitude, and also know that the magnitude
was interpreted as signed value, see more details in the commit message
there).

There's currently only one other upstream user of the driver,
qcom/msm8996-xiaomi-gemini where I've added the dts authors to this
patch series (Raffaele & Yassine) and some tests on that device would be
nice since it's operating in LRA mode, mine does in ERM mode.

Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
Luca Weiss (5):
      Input: drv260x - fix typo in register value define
      Input: drv260x - sleep between polling GO bit
      Input: drv260x - remove unused .reg_defaults
      Input: drv260x - fix magnitude handling
      ARM: dts: qcom: apq8026-huawei-sturgeon: Add vibrator

 arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts | 28 +++++++++++
 drivers/input/misc/drv260x.c                       | 56 ++++------------------
 2 files changed, 37 insertions(+), 47 deletions(-)
---
base-commit: fa55d47c433364df7361fd4f9b169b5845b06914
change-id: 20230430-drv260x-improvements-e218894a0c5c

Best regards,

Comments

Dmitry Torokhov May 2, 2023, 12:29 a.m. UTC | #1 
On Sun, Apr 30, 2023 at 08:20:52PM +0200, Luca Weiss wrote:
> Clean up some issues with the driver I've noticed while working on it,
> then fix the magnitude handling which previously resulted the driver
> discarding the upper 8 bits of the magnitude value, and finally we can
> add the drv260x to the APQ8026 Huawei Watch.
> 
> While the "fix magnitude handling" commit technically changes behavior
> and could change behavior of existing user space applications that deal
> with this quirky behavior, it's definitely not correct and results in
> very unexpected behavior if the user space doesn't look out for it
> (meaning only use 0x00-0xFF magnitude, and also know that the magnitude
> was interpreted as signed value, see more details in the commit message
> there).
> 
> There's currently only one other upstream user of the driver,
> qcom/msm8996-xiaomi-gemini where I've added the dts authors to this
> patch series (Raffaele & Yassine) and some tests on that device would be
> nice since it's operating in LRA mode, mine does in ERM mode.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> Luca Weiss (5):
>       Input: drv260x - fix typo in register value define
>       Input: drv260x - sleep between polling GO bit
>       Input: drv260x - remove unused .reg_defaults
>       Input: drv260x - fix magnitude handling
>       ARM: dts: qcom: apq8026-huawei-sturgeon: Add vibrator

Applied patches 1-4.

Thanks.
Bjorn Andersson May 27, 2023, 1:07 a.m. UTC | #2 
On Sun, 30 Apr 2023 20:20:52 +0200, Luca Weiss wrote:
> Clean up some issues with the driver I've noticed while working on it,
> then fix the magnitude handling which previously resulted the driver
> discarding the upper 8 bits of the magnitude value, and finally we can
> add the drv260x to the APQ8026 Huawei Watch.
> 
> While the "fix magnitude handling" commit technically changes behavior
> and could change behavior of existing user space applications that deal
> with this quirky behavior, it's definitely not correct and results in
> very unexpected behavior if the user space doesn't look out for it
> (meaning only use 0x00-0xFF magnitude, and also know that the magnitude
> was interpreted as signed value, see more details in the commit message
> there).
> 
> [...]

Applied, thanks!

[5/5] ARM: dts: qcom: apq8026-huawei-sturgeon: Add vibrator
      commit: ad318f9ce5a2e815816bfcf7f187a3ac32905523

Best regards,