mbox series

[net,0/3] rxrpc: Timeout handling fixes

Message ID 20230428202756.1186269-1-dhowells@redhat.com
Headers
Series rxrpc: Timeout handling fixes |

Message

David Howells April 28, 2023, 8:27 p.m. UTC 
  Here are three patches to fix timeouts handling in AF_RXRPC:

 (1) The hard call timeout should be interpreted in seconds, not
     milliseconds.

 (2) Allow a waiting call to be aborted (thereby cancelling the call) in
     the case a signal interrupts sendmsg() and leaves it hanging until it
     is granted a channel on a connection.

 (3) Kernel-generated calls get the timer started on them even if they're
     still waiting to be attached to a connection.  If the timer expires
     before the wait is complete and a conn is attached, an oops will
     occur.

David

---
The patches can be found here also:

	http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-fixes

David Howells (3):
  rxrpc: Fix hard call timeout units
  rxrpc: Make it so that a waiting process can be aborted
  rxrpc: Fix timeout of a call that hasn't yet been granted a channel

 fs/afs/afs.h            |  4 ++--
 fs/afs/internal.h       |  2 +-
 fs/afs/rxrpc.c          |  8 +++-----
 include/net/af_rxrpc.h  | 21 +++++++++++----------
 net/rxrpc/af_rxrpc.c    |  3 +++
 net/rxrpc/ar-internal.h |  1 +
 net/rxrpc/call_object.c |  9 ++++++++-
 net/rxrpc/sendmsg.c     | 10 +++++++---
 8 files changed, 36 insertions(+), 22 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org May 1, 2023, 6:50 a.m. UTC | #1 
Hello:

This series was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Fri, 28 Apr 2023 21:27:53 +0100 you wrote:
> Here are three patches to fix timeouts handling in AF_RXRPC:
> 
>  (1) The hard call timeout should be interpreted in seconds, not
>      milliseconds.
> 
>  (2) Allow a waiting call to be aborted (thereby cancelling the call) in
>      the case a signal interrupts sendmsg() and leaves it hanging until it
>      is granted a channel on a connection.
> 
> [...]

Here is the summary with links:
  - [net,1/3] rxrpc: Fix hard call timeout units
    https://git.kernel.org/netdev/net/c/0d098d83c5d9
  - [net,2/3] rxrpc: Make it so that a waiting process can be aborted
    https://git.kernel.org/netdev/net/c/0eb362d25481
  - [net,3/3] rxrpc: Fix timeout of a call that hasn't yet been granted a channel
    https://git.kernel.org/netdev/net/c/db099c625b13

You are awesome, thank you!